ddf19c
From 33d4e21cfd236aecd9e4dbe8228d058fd1f22400 Mon Sep 17 00:00:00 2001
ddf19c
From: Thomas Huth <thuth@redhat.com>
ddf19c
Date: Fri, 29 May 2020 05:54:12 -0400
ddf19c
Subject: [PATCH 30/42] s390x: protvirt: Move diag 308 data over SIDA
ddf19c
ddf19c
RH-Author: Thomas Huth <thuth@redhat.com>
ddf19c
Message-id: <20200529055420.16855-31-thuth@redhat.com>
ddf19c
Patchwork-id: 97048
ddf19c
O-Subject: [RHEL-8.3.0 qemu-kvm PATCH v2 30/38] s390x: protvirt: Move diag 308 data over SIDA
ddf19c
Bugzilla: 1828317
ddf19c
RH-Acked-by: Claudio Imbrenda <cimbrend@redhat.com>
ddf19c
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
ddf19c
RH-Acked-by: David Hildenbrand <david@redhat.com>
ddf19c
ddf19c
From: Janosch Frank <frankja@linux.ibm.com>
ddf19c
ddf19c
For protected guests the IPIB is written/read to/from the SIDA, so we
ddf19c
need those accesses to go through s390_cpu_pv_mem_read/write().
ddf19c
ddf19c
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
ddf19c
Reviewed-by: David Hildenbrand <david@redhat.com>
ddf19c
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
ddf19c
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
ddf19c
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
ddf19c
Message-Id: <20200319131921.2367-12-frankja@linux.ibm.com>
ddf19c
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
ddf19c
(cherry picked from commit 9c61e11238cfa8f70e3eb90aac5d3e5646e5432f)
ddf19c
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
ddf19c
---
ddf19c
 target/s390x/diag.c | 25 ++++++++++++++++++++-----
ddf19c
 1 file changed, 20 insertions(+), 5 deletions(-)
ddf19c
ddf19c
diff --git a/target/s390x/diag.c b/target/s390x/diag.c
ddf19c
index b2cbefb8cf..1a48429564 100644
ddf19c
--- a/target/s390x/diag.c
ddf19c
+++ b/target/s390x/diag.c
ddf19c
@@ -75,6 +75,7 @@ void handle_diag_308(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)
ddf19c
 {
ddf19c
     bool valid;
ddf19c
     CPUState *cs = env_cpu(env);
ddf19c
+    S390CPU *cpu = S390_CPU(cs);
ddf19c
     uint64_t addr =  env->regs[r1];
ddf19c
     uint64_t subcode = env->regs[r3];
ddf19c
     IplParameterBlock *iplb;
ddf19c
@@ -111,13 +112,22 @@ void handle_diag_308(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)
ddf19c
             return;
ddf19c
         }
ddf19c
         iplb = g_new0(IplParameterBlock, 1);
ddf19c
-        cpu_physical_memory_read(addr, iplb, sizeof(iplb->len));
ddf19c
+        if (!s390_is_pv()) {
ddf19c
+            cpu_physical_memory_read(addr, iplb, sizeof(iplb->len));
ddf19c
+        } else {
ddf19c
+            s390_cpu_pv_mem_read(cpu, 0, iplb, sizeof(iplb->len));
ddf19c
+        }
ddf19c
+
ddf19c
         if (!iplb_valid_len(iplb)) {
ddf19c
             env->regs[r1 + 1] = DIAG_308_RC_INVALID;
ddf19c
             goto out;
ddf19c
         }
ddf19c
 
ddf19c
-        cpu_physical_memory_read(addr, iplb, be32_to_cpu(iplb->len));
ddf19c
+        if (!s390_is_pv()) {
ddf19c
+            cpu_physical_memory_read(addr, iplb, be32_to_cpu(iplb->len));
ddf19c
+        } else {
ddf19c
+            s390_cpu_pv_mem_read(cpu, 0, iplb, be32_to_cpu(iplb->len));
ddf19c
+        }
ddf19c
 
ddf19c
         valid = subcode == DIAG308_PV_SET ? iplb_valid_pv(iplb) : iplb_valid(iplb);
ddf19c
         if (!valid) {
ddf19c
@@ -140,12 +150,17 @@ out:
ddf19c
         } else {
ddf19c
             iplb = s390_ipl_get_iplb();
ddf19c
         }
ddf19c
-        if (iplb) {
ddf19c
+        if (!iplb) {
ddf19c
+            env->regs[r1 + 1] = DIAG_308_RC_NO_CONF;
ddf19c
+            return;
ddf19c
+        }
ddf19c
+
ddf19c
+        if (!s390_is_pv()) {
ddf19c
             cpu_physical_memory_write(addr, iplb, be32_to_cpu(iplb->len));
ddf19c
-            env->regs[r1 + 1] = DIAG_308_RC_OK;
ddf19c
         } else {
ddf19c
-            env->regs[r1 + 1] = DIAG_308_RC_NO_CONF;
ddf19c
+            s390_cpu_pv_mem_write(cpu, 0, iplb, be32_to_cpu(iplb->len));
ddf19c
         }
ddf19c
+        env->regs[r1 + 1] = DIAG_308_RC_OK;
ddf19c
         return;
ddf19c
     case DIAG308_PV_START:
ddf19c
         iplb = s390_ipl_get_iplb_pv();
ddf19c
-- 
ddf19c
2.27.0
ddf19c