|
 |
1be5c7 |
From ddfee9d393af322938e4df466cd01b8f9570a1c9 Mon Sep 17 00:00:00 2001
|
|
|
1be5c7 |
From: Thomas Huth <thuth@redhat.com>
|
|
|
1be5c7 |
Date: Tue, 5 Apr 2022 10:20:59 +0200
|
|
|
1be5c7 |
Subject: [PATCH 1/6] s390x/ipl: support extended kernel command line size
|
|
|
1be5c7 |
|
|
|
1be5c7 |
RH-Author: Thomas Huth <thuth@redhat.com>
|
|
|
1be5c7 |
RH-MergeRequest: 144: s390x/ipl: support extended kernel command line size
|
|
|
1be5c7 |
RH-Commit: [1/1] be227e50af5dbe7802605f873db29ac5358aa196
|
|
|
1be5c7 |
RH-Bugzilla: 2043830
|
|
|
1be5c7 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
1be5c7 |
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
1be5c7 |
RH-Acked-by: David Hildenbrand <david@redhat.com>
|
|
|
1be5c7 |
|
|
|
1be5c7 |
Bugzilla: http://bugzilla.redhat.com/2043830
|
|
|
1be5c7 |
|
|
|
1be5c7 |
commit b2173046a64beed76715f310f98538f159276af1
|
|
|
1be5c7 |
Author: Marc Hartmayer <mhartmay@linux.ibm.com>
|
|
|
1be5c7 |
Date: Mon Nov 22 12:29:09 2021 +0100
|
|
|
1be5c7 |
|
|
|
1be5c7 |
s390x/ipl: support extended kernel command line size
|
|
|
1be5c7 |
|
|
|
1be5c7 |
In the past s390 used a fixed command line length of 896 bytes. This has changed
|
|
|
1be5c7 |
with the Linux commit 5ecb2da660ab ("s390: support command lines longer than 896
|
|
|
1be5c7 |
bytes"). There is now a parm area indicating the maximum command line size. This
|
|
|
1be5c7 |
parm area has always been initialized to zero, so with older kernels this field
|
|
|
1be5c7 |
would read zero and we must then assume that only 896 bytes are available.
|
|
|
1be5c7 |
|
|
|
1be5c7 |
Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
|
|
|
1be5c7 |
Reviewed-by: David Hildenbrand <david@redhat.com>
|
|
|
1be5c7 |
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
|
|
|
1be5c7 |
Acked-by: Viktor Mihajlovski <mihajlov@de.ibm.com>
|
|
|
1be5c7 |
Message-Id: <20211122112909.18138-1-mhartmay@linux.ibm.com>
|
|
|
1be5c7 |
[thuth: Cosmetic fixes, and use PRIu64 instead of %lu]
|
|
|
1be5c7 |
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
|
1be5c7 |
|
|
|
1be5c7 |
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
|
1be5c7 |
---
|
|
|
1be5c7 |
hw/s390x/ipl.c | 27 +++++++++++++++++++++++----
|
|
|
1be5c7 |
1 file changed, 23 insertions(+), 4 deletions(-)
|
|
|
1be5c7 |
|
|
|
1be5c7 |
diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
|
|
|
1be5c7 |
index 7ddca0127f..eb7fc4c4ae 100644
|
|
|
1be5c7 |
--- a/hw/s390x/ipl.c
|
|
|
1be5c7 |
+++ b/hw/s390x/ipl.c
|
|
|
1be5c7 |
@@ -37,8 +37,9 @@
|
|
|
1be5c7 |
|
|
|
1be5c7 |
#define KERN_IMAGE_START 0x010000UL
|
|
|
1be5c7 |
#define LINUX_MAGIC_ADDR 0x010008UL
|
|
|
1be5c7 |
+#define KERN_PARM_AREA_SIZE_ADDR 0x010430UL
|
|
|
1be5c7 |
#define KERN_PARM_AREA 0x010480UL
|
|
|
1be5c7 |
-#define KERN_PARM_AREA_SIZE 0x000380UL
|
|
|
1be5c7 |
+#define LEGACY_KERN_PARM_AREA_SIZE 0x000380UL
|
|
|
1be5c7 |
#define INITRD_START 0x800000UL
|
|
|
1be5c7 |
#define INITRD_PARM_START 0x010408UL
|
|
|
1be5c7 |
#define PARMFILE_START 0x001000UL
|
|
|
1be5c7 |
@@ -110,6 +111,21 @@ static uint64_t bios_translate_addr(void *opaque, uint64_t srcaddr)
|
|
|
1be5c7 |
return srcaddr + dstaddr;
|
|
|
1be5c7 |
}
|
|
|
1be5c7 |
|
|
|
1be5c7 |
+static uint64_t get_max_kernel_cmdline_size(void)
|
|
|
1be5c7 |
+{
|
|
|
1be5c7 |
+ uint64_t *size_ptr = rom_ptr(KERN_PARM_AREA_SIZE_ADDR, sizeof(*size_ptr));
|
|
|
1be5c7 |
+
|
|
|
1be5c7 |
+ if (size_ptr) {
|
|
|
1be5c7 |
+ uint64_t size;
|
|
|
1be5c7 |
+
|
|
|
1be5c7 |
+ size = be64_to_cpu(*size_ptr);
|
|
|
1be5c7 |
+ if (size) {
|
|
|
1be5c7 |
+ return size;
|
|
|
1be5c7 |
+ }
|
|
|
1be5c7 |
+ }
|
|
|
1be5c7 |
+ return LEGACY_KERN_PARM_AREA_SIZE;
|
|
|
1be5c7 |
+}
|
|
|
1be5c7 |
+
|
|
|
1be5c7 |
static void s390_ipl_realize(DeviceState *dev, Error **errp)
|
|
|
1be5c7 |
{
|
|
|
1be5c7 |
MachineState *ms = MACHINE(qdev_get_machine());
|
|
|
1be5c7 |
@@ -197,10 +213,13 @@ static void s390_ipl_realize(DeviceState *dev, Error **errp)
|
|
|
1be5c7 |
ipl->start_addr = KERN_IMAGE_START;
|
|
|
1be5c7 |
/* Overwrite parameters in the kernel image, which are "rom" */
|
|
|
1be5c7 |
if (parm_area) {
|
|
|
1be5c7 |
- if (cmdline_size > KERN_PARM_AREA_SIZE) {
|
|
|
1be5c7 |
+ uint64_t max_cmdline_size = get_max_kernel_cmdline_size();
|
|
|
1be5c7 |
+
|
|
|
1be5c7 |
+ if (cmdline_size > max_cmdline_size) {
|
|
|
1be5c7 |
error_setg(errp,
|
|
|
1be5c7 |
- "kernel command line exceeds maximum size: %zu > %lu",
|
|
|
1be5c7 |
- cmdline_size, KERN_PARM_AREA_SIZE);
|
|
|
1be5c7 |
+ "kernel command line exceeds maximum size:"
|
|
|
1be5c7 |
+ " %zu > %" PRIu64,
|
|
|
1be5c7 |
+ cmdline_size, max_cmdline_size);
|
|
|
1be5c7 |
return;
|
|
|
1be5c7 |
}
|
|
|
1be5c7 |
|
|
|
1be5c7 |
--
|
|
|
1be5c7 |
2.27.0
|
|
|
1be5c7 |
|