77c23f
From cd7da3cf1b19fef0a497fd556562040a85e579a7 Mon Sep 17 00:00:00 2001
77c23f
From: Thomas Huth <thuth@redhat.com>
77c23f
Date: Fri, 29 May 2020 05:53:57 -0400
77c23f
Subject: [PATCH 15/42] s390/sclp: improve special wait psw logic
77c23f
MIME-Version: 1.0
77c23f
Content-Type: text/plain; charset=UTF-8
77c23f
Content-Transfer-Encoding: 8bit
77c23f
77c23f
RH-Author: Thomas Huth <thuth@redhat.com>
77c23f
Message-id: <20200529055420.16855-16-thuth@redhat.com>
77c23f
Patchwork-id: 97037
77c23f
O-Subject: [RHEL-8.3.0 qemu-kvm PATCH v2 15/38] s390/sclp: improve special wait psw logic
77c23f
Bugzilla: 1828317
77c23f
RH-Acked-by: Claudio Imbrenda <cimbrend@redhat.com>
77c23f
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
77c23f
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
77c23f
RH-Acked-by: David Hildenbrand <david@redhat.com>
77c23f
77c23f
From: Christian Borntraeger <borntraeger@de.ibm.com>
77c23f
77c23f
There is a special quiesce PSW that we check for "shutdown". Otherwise disabled
77c23f
wait is detected as "crashed". Architecturally we must only check PSW bits
77c23f
116-127. Fix this.
77c23f
77c23f
Cc: qemu-stable@nongnu.org
77c23f
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
77c23f
Message-Id: <1582204582-22995-1-git-send-email-borntraeger@de.ibm.com>
77c23f
Reviewed-by: David Hildenbrand <david@redhat.com>
77c23f
Acked-by: Janosch Frank <frankja@linux.ibm.com>
77c23f
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
77c23f
(cherry picked from commit 8b51c0961cc13e55b26bb6665ec3a341abdc7658)
77c23f
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
77c23f
---
77c23f
 target/s390x/helper.c | 2 +-
77c23f
 1 file changed, 1 insertion(+), 1 deletion(-)
77c23f
77c23f
diff --git a/target/s390x/helper.c b/target/s390x/helper.c
77c23f
index a3a49164e4..6808dfda01 100644
77c23f
--- a/target/s390x/helper.c
77c23f
+++ b/target/s390x/helper.c
77c23f
@@ -89,7 +89,7 @@ hwaddr s390_cpu_get_phys_addr_debug(CPUState *cs, vaddr vaddr)
77c23f
 static inline bool is_special_wait_psw(uint64_t psw_addr)
77c23f
 {
77c23f
     /* signal quiesce */
77c23f
-    return psw_addr == 0xfffUL;
77c23f
+    return (psw_addr & 0xfffUL) == 0xfffUL;
77c23f
 }
77c23f
 
77c23f
 void s390_handle_wait(S390CPU *cpu)
77c23f
-- 
77c23f
2.27.0
77c23f