9ae3a8
From 1f08301adf98c235ccc4e978f809c3f60833452c Mon Sep 17 00:00:00 2001
9ae3a8
From: Markus Armbruster <armbru@redhat.com>
9ae3a8
Date: Wed, 27 Jul 2016 07:35:00 +0200
9ae3a8
Subject: [PATCH 02/16] qjson: Apply nesting limit more sanely
9ae3a8
9ae3a8
RH-Author: Markus Armbruster <armbru@redhat.com>
9ae3a8
Message-id: <1469604913-12442-4-git-send-email-armbru@redhat.com>
9ae3a8
Patchwork-id: 71468
9ae3a8
O-Subject: [RHEL-7.3 qemu-kvm PATCH v2 02/15] qjson: Apply nesting limit more sanely
9ae3a8
Bugzilla: 1276036
9ae3a8
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
9ae3a8
RH-Acked-by: John Snow <jsnow@redhat.com>
9ae3a8
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
9ae3a8
9ae3a8
The nesting limit from commit 29c75dd "json-streamer: limit the
9ae3a8
maximum recursion depth and maximum token count" applies separately to
9ae3a8
braces and brackets.  This makes no sense.  Apply it to their sum,
9ae3a8
because that's actually a measure of recursion depth.
9ae3a8
9ae3a8
Signed-off-by: Markus Armbruster <armbru@redhat.com>
9ae3a8
Reviewed-by: Eric Blake <eblake@redhat.com>
9ae3a8
Message-Id: <1448486613-17634-2-git-send-email-armbru@redhat.com>
9ae3a8
(cherry picked from commit 4f2d31fbc0bfdf41feea7d1be49f4f7ffa005534)
9ae3a8
Signed-off-by: Markus Armbruster <armbru@redhat.com>
9ae3a8
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
9ae3a8
---
9ae3a8
 qobject/json-streamer.c | 3 +--
9ae3a8
 1 file changed, 1 insertion(+), 2 deletions(-)
9ae3a8
9ae3a8
diff --git a/qobject/json-streamer.c b/qobject/json-streamer.c
9ae3a8
index 1b2f9b1..dced2c7 100644
9ae3a8
--- a/qobject/json-streamer.c
9ae3a8
+++ b/qobject/json-streamer.c
9ae3a8
@@ -64,8 +64,7 @@ static void json_message_process_token(JSONLexer *lexer, QString *token, JSONTok
9ae3a8
          parser->bracket_count == 0)) {
9ae3a8
         goto out_emit;
9ae3a8
     } else if (parser->token_size > MAX_TOKEN_SIZE ||
9ae3a8
-               parser->bracket_count > MAX_NESTING ||
9ae3a8
-               parser->brace_count > MAX_NESTING) {
9ae3a8
+               parser->bracket_count + parser->brace_count > MAX_NESTING) {
9ae3a8
         /* Security consideration, we limit total memory allocated per object
9ae3a8
          * and the maximum recursion depth that a message can force.
9ae3a8
          */
9ae3a8
-- 
9ae3a8
1.8.3.1
9ae3a8