|
 |
7f1c5b |
From f628a08d20b9ab6be24c2ab18b38a934a314c78b Mon Sep 17 00:00:00 2001
|
|
|
7f1c5b |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
7f1c5b |
Date: Fri, 18 Nov 2022 18:40:56 +0100
|
|
|
7f1c5b |
Subject: [PATCH 14/31] qed: Don't yield in bdrv_qed_co_drain_begin()
|
|
|
7f1c5b |
|
|
|
7f1c5b |
RH-Author: Stefano Garzarella <sgarzare@redhat.com>
|
|
|
7f1c5b |
RH-MergeRequest: 135: block: Simplify drain to prevent QEMU from crashing during snapshot
|
|
|
7f1c5b |
RH-Bugzilla: 2155112
|
|
|
7f1c5b |
RH-Acked-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
|
|
7f1c5b |
RH-Acked-by: Hanna Czenczek <hreitz@redhat.com>
|
|
|
7f1c5b |
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
7f1c5b |
RH-Commit: [2/16] f18e9aebb7e04a62e309b656bac8f2ab83df657f (sgarzarella/qemu-kvm-c-9-s)
|
|
|
7f1c5b |
|
|
|
7f1c5b |
We want to change .bdrv_co_drained_begin() back to be a non-coroutine
|
|
|
7f1c5b |
callback, so in preparation, avoid yielding in its implementation.
|
|
|
7f1c5b |
|
|
|
7f1c5b |
Because we increase bs->in_flight and bdrv_drained_begin() polls, the
|
|
|
7f1c5b |
behaviour is unchanged.
|
|
|
7f1c5b |
|
|
|
7f1c5b |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
7f1c5b |
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
|
|
7f1c5b |
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
|
|
7f1c5b |
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
|
|
|
7f1c5b |
Message-Id: <20221118174110.55183-2-kwolf@redhat.com>
|
|
|
7f1c5b |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
7f1c5b |
(cherry picked from commit 6d47eb0c8bf2d50682c7dccae74d24104076fe23)
|
|
|
7f1c5b |
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
|
7f1c5b |
---
|
|
|
7f1c5b |
block/qed.c | 20 +++++++++++++++++---
|
|
|
7f1c5b |
1 file changed, 17 insertions(+), 3 deletions(-)
|
|
|
7f1c5b |
|
|
|
7f1c5b |
diff --git a/block/qed.c b/block/qed.c
|
|
|
7f1c5b |
index 2f36ad342c..013f826c44 100644
|
|
|
7f1c5b |
--- a/block/qed.c
|
|
|
7f1c5b |
+++ b/block/qed.c
|
|
|
7f1c5b |
@@ -282,9 +282,8 @@ static void coroutine_fn qed_unplug_allocating_write_reqs(BDRVQEDState *s)
|
|
|
7f1c5b |
qemu_co_mutex_unlock(&s->table_lock);
|
|
|
7f1c5b |
}
|
|
|
7f1c5b |
|
|
|
7f1c5b |
-static void coroutine_fn qed_need_check_timer_entry(void *opaque)
|
|
|
7f1c5b |
+static void coroutine_fn qed_need_check_timer(BDRVQEDState *s)
|
|
|
7f1c5b |
{
|
|
|
7f1c5b |
- BDRVQEDState *s = opaque;
|
|
|
7f1c5b |
int ret;
|
|
|
7f1c5b |
|
|
|
7f1c5b |
trace_qed_need_check_timer_cb(s);
|
|
|
7f1c5b |
@@ -310,9 +309,20 @@ static void coroutine_fn qed_need_check_timer_entry(void *opaque)
|
|
|
7f1c5b |
(void) ret;
|
|
|
7f1c5b |
}
|
|
|
7f1c5b |
|
|
|
7f1c5b |
+static void coroutine_fn qed_need_check_timer_entry(void *opaque)
|
|
|
7f1c5b |
+{
|
|
|
7f1c5b |
+ BDRVQEDState *s = opaque;
|
|
|
7f1c5b |
+
|
|
|
7f1c5b |
+ qed_need_check_timer(opaque);
|
|
|
7f1c5b |
+ bdrv_dec_in_flight(s->bs);
|
|
|
7f1c5b |
+}
|
|
|
7f1c5b |
+
|
|
|
7f1c5b |
static void qed_need_check_timer_cb(void *opaque)
|
|
|
7f1c5b |
{
|
|
|
7f1c5b |
+ BDRVQEDState *s = opaque;
|
|
|
7f1c5b |
Coroutine *co = qemu_coroutine_create(qed_need_check_timer_entry, opaque);
|
|
|
7f1c5b |
+
|
|
|
7f1c5b |
+ bdrv_inc_in_flight(s->bs);
|
|
|
7f1c5b |
qemu_coroutine_enter(co);
|
|
|
7f1c5b |
}
|
|
|
7f1c5b |
|
|
|
7f1c5b |
@@ -363,8 +373,12 @@ static void coroutine_fn bdrv_qed_co_drain_begin(BlockDriverState *bs)
|
|
|
7f1c5b |
* header is flushed.
|
|
|
7f1c5b |
*/
|
|
|
7f1c5b |
if (s->need_check_timer && timer_pending(s->need_check_timer)) {
|
|
|
7f1c5b |
+ Coroutine *co;
|
|
|
7f1c5b |
+
|
|
|
7f1c5b |
qed_cancel_need_check_timer(s);
|
|
|
7f1c5b |
- qed_need_check_timer_entry(s);
|
|
|
7f1c5b |
+ co = qemu_coroutine_create(qed_need_check_timer_entry, s);
|
|
|
7f1c5b |
+ bdrv_inc_in_flight(bs);
|
|
|
7f1c5b |
+ aio_co_enter(bdrv_get_aio_context(bs), co);
|
|
|
7f1c5b |
}
|
|
|
7f1c5b |
}
|
|
|
7f1c5b |
|
|
|
7f1c5b |
--
|
|
|
7f1c5b |
2.31.1
|
|
|
7f1c5b |
|