218e99
From 08a3a60a9a3cdd4d67e858981e4446d8f1d31fe4 Mon Sep 17 00:00:00 2001
218e99
From: Max Reitz <mreitz@redhat.com>
218e99
Date: Mon, 4 Nov 2013 22:32:31 +0100
218e99
Subject: [PATCH 38/87] qcow2: Add overlap-check options
218e99
218e99
RH-Author: Max Reitz <mreitz@redhat.com>
218e99
Message-id: <1383604354-12743-41-git-send-email-mreitz@redhat.com>
218e99
Patchwork-id: 55340
218e99
O-Subject: [RHEL-7.0 qemu-kvm PATCH 40/43] qcow2: Add overlap-check options
218e99
Bugzilla: 1004347
218e99
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
218e99
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
218e99
RH-Acked-by: Fam Zheng <famz@redhat.com>
218e99
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
218e99
218e99
BZ: 1004347
218e99
218e99
Add runtime options to tune the overlap checks to be performed before
218e99
write accesses.
218e99
218e99
Signed-off-by: Max Reitz <mreitz@redhat.com>
218e99
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
218e99
(cherry picked from commit 05de7e86cab3ed3830de38b38b39bbc711bc1158)
218e99
218e99
Signed-off-by: Max Reitz <mreitz@redhat.com>
218e99
---
218e99
 block/qcow2.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
218e99
 block/qcow2.h |  9 +++++++++
218e99
 2 files changed, 55 insertions(+)
218e99
218e99
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
218e99
---
218e99
 block/qcow2.c |   46 ++++++++++++++++++++++++++++++++++++++++++++++
218e99
 block/qcow2.h |    9 +++++++++
218e99
 2 files changed, 55 insertions(+), 0 deletions(-)
218e99
218e99
diff --git a/block/qcow2.c b/block/qcow2.c
218e99
index 157361f..c47286f 100644
218e99
--- a/block/qcow2.c
218e99
+++ b/block/qcow2.c
218e99
@@ -354,6 +354,52 @@ static QemuOptsList qcow2_runtime_opts = {
218e99
             .type = QEMU_OPT_BOOL,
218e99
             .help = "Generate discard requests when other clusters are freed",
218e99
         },
218e99
+        {
218e99
+            .name = QCOW2_OPT_OVERLAP,
218e99
+            .type = QEMU_OPT_STRING,
218e99
+            .help = "Selects which overlap checks to perform from a range of "
218e99
+                    "templates (none, constant, cached, all)",
218e99
+        },
218e99
+        {
218e99
+            .name = QCOW2_OPT_OVERLAP_MAIN_HEADER,
218e99
+            .type = QEMU_OPT_BOOL,
218e99
+            .help = "Check for unintended writes into the main qcow2 header",
218e99
+        },
218e99
+        {
218e99
+            .name = QCOW2_OPT_OVERLAP_ACTIVE_L1,
218e99
+            .type = QEMU_OPT_BOOL,
218e99
+            .help = "Check for unintended writes into the active L1 table",
218e99
+        },
218e99
+        {
218e99
+            .name = QCOW2_OPT_OVERLAP_ACTIVE_L2,
218e99
+            .type = QEMU_OPT_BOOL,
218e99
+            .help = "Check for unintended writes into an active L2 table",
218e99
+        },
218e99
+        {
218e99
+            .name = QCOW2_OPT_OVERLAP_REFCOUNT_TABLE,
218e99
+            .type = QEMU_OPT_BOOL,
218e99
+            .help = "Check for unintended writes into the refcount table",
218e99
+        },
218e99
+        {
218e99
+            .name = QCOW2_OPT_OVERLAP_REFCOUNT_BLOCK,
218e99
+            .type = QEMU_OPT_BOOL,
218e99
+            .help = "Check for unintended writes into a refcount block",
218e99
+        },
218e99
+        {
218e99
+            .name = QCOW2_OPT_OVERLAP_SNAPSHOT_TABLE,
218e99
+            .type = QEMU_OPT_BOOL,
218e99
+            .help = "Check for unintended writes into the snapshot table",
218e99
+        },
218e99
+        {
218e99
+            .name = QCOW2_OPT_OVERLAP_INACTIVE_L1,
218e99
+            .type = QEMU_OPT_BOOL,
218e99
+            .help = "Check for unintended writes into an inactive L1 table",
218e99
+        },
218e99
+        {
218e99
+            .name = QCOW2_OPT_OVERLAP_INACTIVE_L2,
218e99
+            .type = QEMU_OPT_BOOL,
218e99
+            .help = "Check for unintended writes into an inactive L2 table",
218e99
+        },
218e99
         { /* end of list */ }
218e99
     },
218e99
 };
218e99
diff --git a/block/qcow2.h b/block/qcow2.h
218e99
index d1fd91b..1bba3ed 100644
218e99
--- a/block/qcow2.h
218e99
+++ b/block/qcow2.h
218e99
@@ -63,6 +63,15 @@
218e99
 #define QCOW2_OPT_DISCARD_REQUEST "pass-discard-request"
218e99
 #define QCOW2_OPT_DISCARD_SNAPSHOT "pass-discard-snapshot"
218e99
 #define QCOW2_OPT_DISCARD_OTHER "pass-discard-other"
218e99
+#define QCOW2_OPT_OVERLAP "overlap-check"
218e99
+#define QCOW2_OPT_OVERLAP_MAIN_HEADER "overlap-check.main-header"
218e99
+#define QCOW2_OPT_OVERLAP_ACTIVE_L1 "overlap-check.active-l1"
218e99
+#define QCOW2_OPT_OVERLAP_ACTIVE_L2 "overlap-check.active-l2"
218e99
+#define QCOW2_OPT_OVERLAP_REFCOUNT_TABLE "overlap-check.refcount-table"
218e99
+#define QCOW2_OPT_OVERLAP_REFCOUNT_BLOCK "overlap-check.refcount-block"
218e99
+#define QCOW2_OPT_OVERLAP_SNAPSHOT_TABLE "overlap-check.snapshot-table"
218e99
+#define QCOW2_OPT_OVERLAP_INACTIVE_L1 "overlap-check.inactive-l1"
218e99
+#define QCOW2_OPT_OVERLAP_INACTIVE_L2 "overlap-check.inactive-l2"
218e99
 
218e99
 typedef struct QCowHeader {
218e99
     uint32_t magic;
218e99
-- 
218e99
1.7.1
218e99