|
 |
586cba |
From d3335a98a7b6e084aadf4907968536a67cf8e64c Mon Sep 17 00:00:00 2001
|
|
|
586cba |
From: Thomas Huth <thuth@redhat.com>
|
|
|
586cba |
Date: Fri, 8 Jul 2022 20:49:01 +0200
|
|
|
586cba |
Subject: [PATCH 09/17] pc-bios/s390-ccw/virtio-blkdev: Remove
|
|
|
586cba |
virtio_assume_scsi()
|
|
|
586cba |
|
|
|
586cba |
RH-Author: Thomas Huth <thuth@redhat.com>
|
|
|
586cba |
RH-MergeRequest: 106: pc-bios/s390-ccw: Fix boot from disks with 4k sectors that do not have the typical DASD geometry
|
|
|
586cba |
RH-Commit: [4/10] bf27f75344f220a03475a2918ed49ec9cd5ba317 (thuth/qemu-kvm-cs9)
|
|
|
586cba |
RH-Bugzilla: 2098077
|
|
|
586cba |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
586cba |
RH-Acked-by: David Hildenbrand <david@redhat.com>
|
|
|
586cba |
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
586cba |
|
|
|
586cba |
Bugzilla: http://bugzilla.redhat.com/2098077
|
|
|
586cba |
|
|
|
586cba |
commit 5447de2619050a0a4dd480b97f88a9b58da360d1
|
|
|
586cba |
Author: Thomas Huth <thuth@redhat.com>
|
|
|
586cba |
Date: Mon Jul 4 13:18:56 2022 +0200
|
|
|
586cba |
|
|
|
586cba |
pc-bios/s390-ccw/virtio-blkdev: Remove virtio_assume_scsi()
|
|
|
586cba |
|
|
|
586cba |
The virtio_assume_scsi() function is very questionable: First, it
|
|
|
586cba |
is only called for virtio-blk, and not for virtio-scsi, so the naming
|
|
|
586cba |
is already quite confusing. Second, it is called if we detected a
|
|
|
586cba |
"invalid" IPL disk, trying to fix it by blindly setting a sector
|
|
|
586cba |
size of 512. This of course won't work in most cases since disks
|
|
|
586cba |
might have a different sector size for a reason.
|
|
|
586cba |
|
|
|
586cba |
Thus let's remove this strange function now. The calling code can
|
|
|
586cba |
also be removed completely, since there is another spot in main.c
|
|
|
586cba |
that does "IPL_assert(virtio_ipl_disk_is_valid(), ...)" to make
|
|
|
586cba |
sure that we do not try to IPL from an invalid device.
|
|
|
586cba |
|
|
|
586cba |
Message-Id: <20220704111903.62400-6-thuth@redhat.com>
|
|
|
586cba |
Reviewed-by: Eric Farman <farman@linux.ibm.com>
|
|
|
586cba |
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
|
586cba |
|
|
|
586cba |
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
|
586cba |
---
|
|
|
586cba |
pc-bios/s390-ccw/virtio-blkdev.c | 24 ------------------------
|
|
|
586cba |
pc-bios/s390-ccw/virtio.h | 1 -
|
|
|
586cba |
2 files changed, 25 deletions(-)
|
|
|
586cba |
|
|
|
586cba |
diff --git a/pc-bios/s390-ccw/virtio-blkdev.c b/pc-bios/s390-ccw/virtio-blkdev.c
|
|
|
586cba |
index 7e13155589..db1f7f44aa 100644
|
|
|
586cba |
--- a/pc-bios/s390-ccw/virtio-blkdev.c
|
|
|
586cba |
+++ b/pc-bios/s390-ccw/virtio-blkdev.c
|
|
|
586cba |
@@ -112,23 +112,6 @@ VirtioGDN virtio_guessed_disk_nature(void)
|
|
|
586cba |
return virtio_get_device()->guessed_disk_nature;
|
|
|
586cba |
}
|
|
|
586cba |
|
|
|
586cba |
-void virtio_assume_scsi(void)
|
|
|
586cba |
-{
|
|
|
586cba |
- VDev *vdev = virtio_get_device();
|
|
|
586cba |
-
|
|
|
586cba |
- switch (vdev->senseid.cu_model) {
|
|
|
586cba |
- case VIRTIO_ID_BLOCK:
|
|
|
586cba |
- vdev->guessed_disk_nature = VIRTIO_GDN_SCSI;
|
|
|
586cba |
- vdev->config.blk.blk_size = VIRTIO_SCSI_BLOCK_SIZE;
|
|
|
586cba |
- vdev->config.blk.physical_block_exp = 0;
|
|
|
586cba |
- vdev->blk_factor = 1;
|
|
|
586cba |
- break;
|
|
|
586cba |
- case VIRTIO_ID_SCSI:
|
|
|
586cba |
- vdev->scsi_block_size = VIRTIO_SCSI_BLOCK_SIZE;
|
|
|
586cba |
- break;
|
|
|
586cba |
- }
|
|
|
586cba |
-}
|
|
|
586cba |
-
|
|
|
586cba |
void virtio_assume_iso9660(void)
|
|
|
586cba |
{
|
|
|
586cba |
VDev *vdev = virtio_get_device();
|
|
|
586cba |
@@ -247,13 +230,6 @@ int virtio_blk_setup_device(SubChannelId schid)
|
|
|
586cba |
switch (vdev->senseid.cu_model) {
|
|
|
586cba |
case VIRTIO_ID_BLOCK:
|
|
|
586cba |
sclp_print("Using virtio-blk.\n");
|
|
|
586cba |
- if (!virtio_ipl_disk_is_valid()) {
|
|
|
586cba |
- /* make sure all getters but blocksize return 0 for
|
|
|
586cba |
- * invalid IPL disk
|
|
|
586cba |
- */
|
|
|
586cba |
- memset(&vdev->config.blk, 0, sizeof(vdev->config.blk));
|
|
|
586cba |
- virtio_assume_scsi();
|
|
|
586cba |
- }
|
|
|
586cba |
break;
|
|
|
586cba |
case VIRTIO_ID_SCSI:
|
|
|
586cba |
IPL_assert(vdev->config.scsi.sense_size == VIRTIO_SCSI_SENSE_SIZE,
|
|
|
586cba |
diff --git a/pc-bios/s390-ccw/virtio.h b/pc-bios/s390-ccw/virtio.h
|
|
|
586cba |
index 241730effe..600ba5052b 100644
|
|
|
586cba |
--- a/pc-bios/s390-ccw/virtio.h
|
|
|
586cba |
+++ b/pc-bios/s390-ccw/virtio.h
|
|
|
586cba |
@@ -182,7 +182,6 @@ enum guessed_disk_nature_type {
|
|
|
586cba |
typedef enum guessed_disk_nature_type VirtioGDN;
|
|
|
586cba |
|
|
|
586cba |
VirtioGDN virtio_guessed_disk_nature(void);
|
|
|
586cba |
-void virtio_assume_scsi(void);
|
|
|
586cba |
void virtio_assume_eckd(void);
|
|
|
586cba |
void virtio_assume_iso9660(void);
|
|
|
586cba |
|
|
|
586cba |
--
|
|
|
586cba |
2.31.1
|
|
|
586cba |
|