|
 |
586cba |
From 64fa56e0520215e3909e442f09d8073c1870648a Mon Sep 17 00:00:00 2001
|
|
|
586cba |
From: Thomas Huth <thuth@redhat.com>
|
|
|
586cba |
Date: Fri, 8 Jul 2022 20:49:01 +0200
|
|
|
586cba |
Subject: [PATCH 07/17] pc-bios/s390-ccw/bootmap: Improve the guessing logic in
|
|
|
586cba |
zipl_load_vblk()
|
|
|
586cba |
|
|
|
586cba |
RH-Author: Thomas Huth <thuth@redhat.com>
|
|
|
586cba |
RH-MergeRequest: 106: pc-bios/s390-ccw: Fix boot from disks with 4k sectors that do not have the typical DASD geometry
|
|
|
586cba |
RH-Commit: [2/10] ca8f5e847617cf4ac2fd6c38edb2982f32fa3eba (thuth/qemu-kvm-cs9)
|
|
|
586cba |
RH-Bugzilla: 2098077
|
|
|
586cba |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
586cba |
RH-Acked-by: David Hildenbrand <david@redhat.com>
|
|
|
586cba |
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
586cba |
|
|
|
586cba |
Bugzilla: http://bugzilla.redhat.com/2098077
|
|
|
586cba |
|
|
|
586cba |
commit 422865f6672ee1482b98d18321b55c1ecfb06c82
|
|
|
586cba |
Author: Thomas Huth <thuth@redhat.com>
|
|
|
586cba |
Date: Mon Jul 4 13:18:54 2022 +0200
|
|
|
586cba |
|
|
|
586cba |
pc-bios/s390-ccw/bootmap: Improve the guessing logic in zipl_load_vblk()
|
|
|
586cba |
|
|
|
586cba |
The logic of trying an final ISO or ECKD boot on virtio-block devices is
|
|
|
586cba |
very weird: Since the geometry hardly ever matches in virtio_disk_is_scsi(),
|
|
|
586cba |
virtio_blk_setup_device() always sets a "guessed" disk geometry via
|
|
|
586cba |
virtio_assume_scsi() (which is certainly also wrong in a lot of cases).
|
|
|
586cba |
|
|
|
586cba |
zipl_load_vblk() then sees that there's been a "virtio_guessed_disk_nature"
|
|
|
586cba |
and tries to fix up the geometry again via virtio_assume_iso9660() before
|
|
|
586cba |
always trying to do ipl_iso_el_torito(). That's a very brain-twisting
|
|
|
586cba |
way of attempting to boot from ISO images, which won't work anymore after
|
|
|
586cba |
the following patches that will clean up the virtio_assume_scsi() mess
|
|
|
586cba |
(and thus get rid of the "virtio_guessed_disk_nature" here).
|
|
|
586cba |
|
|
|
586cba |
Let's try a better approach instead: ISO files always have a magic
|
|
|
586cba |
string "CD001" at offset 0x8001 (see e.g. the ECMA-119 specification)
|
|
|
586cba |
which we can use to decide whether we should try to boot in ISO 9660
|
|
|
586cba |
mode (which we should also try if we see a sector size of 2048).
|
|
|
586cba |
|
|
|
586cba |
And if we were not able to boot in ISO mode here, the final boot attempt
|
|
|
586cba |
before panicking is to boot in ECKD mode. Since this is our last boot
|
|
|
586cba |
attempt anyway, simply always assume the ECKD geometry here (if the sector
|
|
|
586cba |
size was not 4096 yet), so that we also do not depend on the guessed disk
|
|
|
586cba |
geometry from virtio_blk_setup_device() here anymore.
|
|
|
586cba |
|
|
|
586cba |
Message-Id: <20220704111903.62400-4-thuth@redhat.com>
|
|
|
586cba |
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
|
586cba |
|
|
|
586cba |
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
|
586cba |
---
|
|
|
586cba |
pc-bios/s390-ccw/bootmap.c | 27 +++++++++++++++++++++++----
|
|
|
586cba |
1 file changed, 23 insertions(+), 4 deletions(-)
|
|
|
586cba |
|
|
|
586cba |
diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c
|
|
|
586cba |
index 56411ab3b6..994e59c0b0 100644
|
|
|
586cba |
--- a/pc-bios/s390-ccw/bootmap.c
|
|
|
586cba |
+++ b/pc-bios/s390-ccw/bootmap.c
|
|
|
586cba |
@@ -780,18 +780,37 @@ static void ipl_iso_el_torito(void)
|
|
|
586cba |
}
|
|
|
586cba |
}
|
|
|
586cba |
|
|
|
586cba |
+/**
|
|
|
586cba |
+ * Detect whether we're trying to boot from an .ISO image.
|
|
|
586cba |
+ * These always have a signature string "CD001" at offset 0x8001.
|
|
|
586cba |
+ */
|
|
|
586cba |
+static bool has_iso_signature(void)
|
|
|
586cba |
+{
|
|
|
586cba |
+ int blksize = virtio_get_block_size();
|
|
|
586cba |
+
|
|
|
586cba |
+ if (!blksize || virtio_read(0x8000 / blksize, sec)) {
|
|
|
586cba |
+ return false;
|
|
|
586cba |
+ }
|
|
|
586cba |
+
|
|
|
586cba |
+ return !memcmp("CD001", &sec[1], 5);
|
|
|
586cba |
+}
|
|
|
586cba |
+
|
|
|
586cba |
/***********************************************************************
|
|
|
586cba |
* Bus specific IPL sequences
|
|
|
586cba |
*/
|
|
|
586cba |
|
|
|
586cba |
static void zipl_load_vblk(void)
|
|
|
586cba |
{
|
|
|
586cba |
- if (virtio_guessed_disk_nature()) {
|
|
|
586cba |
- virtio_assume_iso9660();
|
|
|
586cba |
+ int blksize = virtio_get_block_size();
|
|
|
586cba |
+
|
|
|
586cba |
+ if (blksize == VIRTIO_ISO_BLOCK_SIZE || has_iso_signature()) {
|
|
|
586cba |
+ if (blksize != VIRTIO_ISO_BLOCK_SIZE) {
|
|
|
586cba |
+ virtio_assume_iso9660();
|
|
|
586cba |
+ }
|
|
|
586cba |
+ ipl_iso_el_torito();
|
|
|
586cba |
}
|
|
|
586cba |
- ipl_iso_el_torito();
|
|
|
586cba |
|
|
|
586cba |
- if (virtio_guessed_disk_nature()) {
|
|
|
586cba |
+ if (blksize != VIRTIO_DASD_DEFAULT_BLOCK_SIZE) {
|
|
|
586cba |
sclp_print("Using guessed DASD geometry.\n");
|
|
|
586cba |
virtio_assume_eckd();
|
|
|
586cba |
}
|
|
|
586cba |
--
|
|
|
586cba |
2.31.1
|
|
|
586cba |
|