Blame SOURCES/kvm-pc-bios-s390-ccw-Fix-the-cc-option-macro-in-the-Make.patch

a83cc2
From f2d40216872a40bc5f5089de760c7ba0e3a710bc Mon Sep 17 00:00:00 2001
a83cc2
From: Thomas Huth <thuth@redhat.com>
a83cc2
Date: Sun, 2 May 2021 13:07:46 +0200
a83cc2
Subject: [PATCH 32/39] pc-bios/s390-ccw: Fix the cc-option macro in the
a83cc2
 Makefile
a83cc2
a83cc2
RH-Author: Jon Maloy <jmaloy@redhat.com>
a83cc2
RH-MergeRequest: 24: v7:  Add support for building qemu-kvm with clang and safe-stack
a83cc2
RH-Commit: [5/11] 75379671567451e12ca32a3ea35d1ad2aa04bf5f (jmaloy/qemu-kvm-centos-jon)
a83cc2
RH-Bugzilla: 1939509 1940132
a83cc2
RH-Acked-by: Danilo Cesar Lemes de Paula <ddepaula@redhat.com>
a83cc2
RH-Acked-by: Thomas Huth <thuth@redhat.com>
a83cc2
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
a83cc2
a83cc2
The cc-option macro is not doing what it should - compared with the
a83cc2
original from the rules.mak file that got removed with commit
a83cc2
660f793093 ("Makefile: inline the relevant parts of rules.mak"),
a83cc2
the arguments got changed and thus the macro is rather doubling
a83cc2
the QEMU_CFLAGS than adding the flag that should be tested.
a83cc2
a83cc2
Message-Id: <20210502174836.838816-3-thuth@redhat.com>
a83cc2
Fixes: 22fb2ab096 ("pc-bios/s390-ccw: do not use rules.mak")
a83cc2
Signed-off-by: Thomas Huth <thuth@redhat.com>
a83cc2
(cherry picked from commit 3462ff35512e925df5ee8c079ed46d4c93b633a7)
a83cc2
Signed-off-by: Jon Maloy <jmaloy@redhat.com>
a83cc2
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
a83cc2
---
a83cc2
 pc-bios/s390-ccw/Makefile | 4 ++--
a83cc2
 1 file changed, 2 insertions(+), 2 deletions(-)
a83cc2
a83cc2
diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
a83cc2
index 29fd9019b8..f0fe84c9eb 100644
a83cc2
--- a/pc-bios/s390-ccw/Makefile
a83cc2
+++ b/pc-bios/s390-ccw/Makefile
a83cc2
@@ -6,8 +6,8 @@ include ../../config-host.mak
a83cc2
 CFLAGS = -O2 -g
a83cc2
 
a83cc2
 quiet-command = $(if $(V),$1,$(if $(2),@printf "  %-7s %s\n" $2 $3 && $1, @$1))
a83cc2
-cc-option = $(if $(shell $(CC) $1 -S -o /dev/null -xc /dev/null > /dev/null \
a83cc2
-	      2>&1 && echo OK), $1, $2)
a83cc2
+cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc /dev/null \
a83cc2
+			 >/dev/null 2>&1 && echo OK),$2,$3)
a83cc2
 
a83cc2
 VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.sh %.rc Kconfig% %.json.in
a83cc2
 set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES),$(eval vpath $(PATTERN) $1)))
a83cc2
-- 
a83cc2
2.27.0
a83cc2