1be5c7
From 8aecb49fdd771c5819fccc9e750b2e9cd4e94b58 Mon Sep 17 00:00:00 2001
1be5c7
From: Leonardo Bras <leobras@redhat.com>
1be5c7
Date: Mon, 25 Jul 2022 22:02:35 -0300
1be5c7
Subject: [PATCH 7/9] migration: add remaining params->has_* = true in
1be5c7
 migration_instance_init()
1be5c7
MIME-Version: 1.0
1be5c7
Content-Type: text/plain; charset=UTF-8
1be5c7
Content-Transfer-Encoding: 8bit
1be5c7
1be5c7
RH-Author: Leonardo BrĂ¡s <leobras@redhat.com>
1be5c7
RH-MergeRequest: 201: Zero-copy-send fixes + improvements
1be5c7
RH-Commit: [7/8] fb622e5b88e14eb859d4903d9c088ba6ca63fc81
1be5c7
RH-Bugzilla: 2110203
1be5c7
RH-Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
1be5c7
RH-Acked-by: Peter Xu <peterx@redhat.com>
1be5c7
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
1be5c7
1be5c7
Some of params->has_* = true are missing in migration_instance_init, this
1be5c7
causes migrate_params_check() to skip some tests, allowing some
1be5c7
unsupported scenarios.
1be5c7
1be5c7
Fix this by adding all missing params->has_* = true in
1be5c7
migration_instance_init().
1be5c7
1be5c7
Fixes: 69ef1f36b0 ("migration: define 'tls-creds' and 'tls-hostname' migration parameters")
1be5c7
Fixes: 1d58872a91 ("migration: do not wait for free thread")
1be5c7
Fixes: d2f1d29b95 ("migration: add support for a "tls-authz" migration parameter")
1be5c7
Signed-off-by: Leonardo Bras <leobras@redhat.com>
1be5c7
Message-Id: <20220726010235.342927-1-leobras@redhat.com>
1be5c7
Reviewed-by: Peter Xu <peterx@redhat.com>
1be5c7
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
1be5c7
(cherry picked from commit df67aa3e61e2c83459da7d815962d9706f1528fc)
1be5c7
Signed-off-by: Leonardo Bras <leobras@redhat.com>
1be5c7
---
1be5c7
 migration/migration.c | 4 ++++
1be5c7
 1 file changed, 4 insertions(+)
1be5c7
1be5c7
diff --git a/migration/migration.c b/migration/migration.c
1be5c7
index 35b3197eff..51e6726dac 100644
1be5c7
--- a/migration/migration.c
1be5c7
+++ b/migration/migration.c
1be5c7
@@ -4334,6 +4334,7 @@ static void migration_instance_init(Object *obj)
1be5c7
     /* Set has_* up only for parameter checks */
1be5c7
     params->has_compress_level = true;
1be5c7
     params->has_compress_threads = true;
1be5c7
+    params->has_compress_wait_thread = true;
1be5c7
     params->has_decompress_threads = true;
1be5c7
     params->has_throttle_trigger_threshold = true;
1be5c7
     params->has_cpu_throttle_initial = true;
1be5c7
@@ -4354,6 +4355,9 @@ static void migration_instance_init(Object *obj)
1be5c7
     params->has_announce_max = true;
1be5c7
     params->has_announce_rounds = true;
1be5c7
     params->has_announce_step = true;
1be5c7
+    params->has_tls_creds = true;
1be5c7
+    params->has_tls_hostname = true;
1be5c7
+    params->has_tls_authz = true;
1be5c7
 
1be5c7
     qemu_sem_init(&ms->postcopy_pause_sem, 0);
1be5c7
     qemu_sem_init(&ms->postcopy_pause_rp_sem, 0);
1be5c7
-- 
1be5c7
2.31.1
1be5c7