|
 |
0727d3 |
From 6a9a5a2809cbbe2982df156722b88efeec998e3d Mon Sep 17 00:00:00 2001
|
|
|
0727d3 |
From: Juan Quintela <quintela@redhat.com>
|
|
|
0727d3 |
Date: Wed, 18 May 2022 02:52:22 -0300
|
|
|
0727d3 |
Subject: [PATCH 01/37] migration: Never call twice qemu_target_page_size()
|
|
|
0727d3 |
MIME-Version: 1.0
|
|
|
0727d3 |
Content-Type: text/plain; charset=UTF-8
|
|
|
0727d3 |
Content-Transfer-Encoding: 8bit
|
|
|
0727d3 |
|
|
|
0727d3 |
RH-Author: Leonardo Brás <leobras@redhat.com>
|
|
|
0727d3 |
RH-MergeRequest: 191: MSG_ZEROCOPY + Multifd @ rhel8.7
|
|
|
0727d3 |
RH-Commit: [1/26] 809ca84dec80bafc1959df8c9e57f482ee752a97
|
|
|
0727d3 |
RH-Bugzilla: 2072049
|
|
|
0727d3 |
RH-Acked-by: Peter Xu <peterx@redhat.com>
|
|
|
0727d3 |
RH-Acked-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
|
0727d3 |
RH-Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
0727d3 |
|
|
|
0727d3 |
Signed-off-by: Juan Quintela <quintela@redhat.com>
|
|
|
0727d3 |
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
0727d3 |
(cherry picked from commit 144fa06b3431e806057ce1438338395b35a3e544)
|
|
|
0727d3 |
Signed-off-by: Leonardo Bras <leobras@redhat.com>
|
|
|
0727d3 |
---
|
|
|
0727d3 |
migration/migration.c | 7 ++++---
|
|
|
0727d3 |
migration/multifd.c | 7 ++++---
|
|
|
0727d3 |
migration/savevm.c | 5 +++--
|
|
|
0727d3 |
3 files changed, 11 insertions(+), 8 deletions(-)
|
|
|
0727d3 |
|
|
|
0727d3 |
diff --git a/migration/migration.c b/migration/migration.c
|
|
|
0727d3 |
index a87ff01b81..8a13294da6 100644
|
|
|
0727d3 |
--- a/migration/migration.c
|
|
|
0727d3 |
+++ b/migration/migration.c
|
|
|
0727d3 |
@@ -992,6 +992,8 @@ static void populate_time_info(MigrationInfo *info, MigrationState *s)
|
|
|
0727d3 |
|
|
|
0727d3 |
static void populate_ram_info(MigrationInfo *info, MigrationState *s)
|
|
|
0727d3 |
{
|
|
|
0727d3 |
+ size_t page_size = qemu_target_page_size();
|
|
|
0727d3 |
+
|
|
|
0727d3 |
info->has_ram = true;
|
|
|
0727d3 |
info->ram = g_malloc0(sizeof(*info->ram));
|
|
|
0727d3 |
info->ram->transferred = ram_counters.transferred;
|
|
|
0727d3 |
@@ -1000,12 +1002,11 @@ static void populate_ram_info(MigrationInfo *info, MigrationState *s)
|
|
|
0727d3 |
/* legacy value. It is not used anymore */
|
|
|
0727d3 |
info->ram->skipped = 0;
|
|
|
0727d3 |
info->ram->normal = ram_counters.normal;
|
|
|
0727d3 |
- info->ram->normal_bytes = ram_counters.normal *
|
|
|
0727d3 |
- qemu_target_page_size();
|
|
|
0727d3 |
+ info->ram->normal_bytes = ram_counters.normal * page_size;
|
|
|
0727d3 |
info->ram->mbps = s->mbps;
|
|
|
0727d3 |
info->ram->dirty_sync_count = ram_counters.dirty_sync_count;
|
|
|
0727d3 |
info->ram->postcopy_requests = ram_counters.postcopy_requests;
|
|
|
0727d3 |
- info->ram->page_size = qemu_target_page_size();
|
|
|
0727d3 |
+ info->ram->page_size = page_size;
|
|
|
0727d3 |
info->ram->multifd_bytes = ram_counters.multifd_bytes;
|
|
|
0727d3 |
info->ram->pages_per_second = s->pages_per_second;
|
|
|
0727d3 |
|
|
|
0727d3 |
diff --git a/migration/multifd.c b/migration/multifd.c
|
|
|
0727d3 |
index 7c9deb1921..8125d0015c 100644
|
|
|
0727d3 |
--- a/migration/multifd.c
|
|
|
0727d3 |
+++ b/migration/multifd.c
|
|
|
0727d3 |
@@ -289,7 +289,8 @@ static void multifd_send_fill_packet(MultiFDSendParams *p)
|
|
|
0727d3 |
static int multifd_recv_unfill_packet(MultiFDRecvParams *p, Error **errp)
|
|
|
0727d3 |
{
|
|
|
0727d3 |
MultiFDPacket_t *packet = p->packet;
|
|
|
0727d3 |
- uint32_t pages_max = MULTIFD_PACKET_SIZE / qemu_target_page_size();
|
|
|
0727d3 |
+ size_t page_size = qemu_target_page_size();
|
|
|
0727d3 |
+ uint32_t pages_max = MULTIFD_PACKET_SIZE / page_size;
|
|
|
0727d3 |
RAMBlock *block;
|
|
|
0727d3 |
int i;
|
|
|
0727d3 |
|
|
|
0727d3 |
@@ -358,14 +359,14 @@ static int multifd_recv_unfill_packet(MultiFDRecvParams *p, Error **errp)
|
|
|
0727d3 |
for (i = 0; i < p->pages->used; i++) {
|
|
|
0727d3 |
uint64_t offset = be64_to_cpu(packet->offset[i]);
|
|
|
0727d3 |
|
|
|
0727d3 |
- if (offset > (block->used_length - qemu_target_page_size())) {
|
|
|
0727d3 |
+ if (offset > (block->used_length - page_size)) {
|
|
|
0727d3 |
error_setg(errp, "multifd: offset too long %" PRIu64
|
|
|
0727d3 |
" (max " RAM_ADDR_FMT ")",
|
|
|
0727d3 |
offset, block->used_length);
|
|
|
0727d3 |
return -1;
|
|
|
0727d3 |
}
|
|
|
0727d3 |
p->pages->iov[i].iov_base = block->host + offset;
|
|
|
0727d3 |
- p->pages->iov[i].iov_len = qemu_target_page_size();
|
|
|
0727d3 |
+ p->pages->iov[i].iov_len = page_size;
|
|
|
0727d3 |
}
|
|
|
0727d3 |
|
|
|
0727d3 |
return 0;
|
|
|
0727d3 |
diff --git a/migration/savevm.c b/migration/savevm.c
|
|
|
0727d3 |
index d59e976d50..0bef031acb 100644
|
|
|
0727d3 |
--- a/migration/savevm.c
|
|
|
0727d3 |
+++ b/migration/savevm.c
|
|
|
0727d3 |
@@ -1685,6 +1685,7 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
|
|
|
0727d3 |
{
|
|
|
0727d3 |
PostcopyState ps = postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
|
|
|
0727d3 |
uint64_t remote_pagesize_summary, local_pagesize_summary, remote_tps;
|
|
|
0727d3 |
+ size_t page_size = qemu_target_page_size();
|
|
|
0727d3 |
Error *local_err = NULL;
|
|
|
0727d3 |
|
|
|
0727d3 |
trace_loadvm_postcopy_handle_advise();
|
|
|
0727d3 |
@@ -1741,13 +1742,13 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
|
|
|
0727d3 |
}
|
|
|
0727d3 |
|
|
|
0727d3 |
remote_tps = qemu_get_be64(mis->from_src_file);
|
|
|
0727d3 |
- if (remote_tps != qemu_target_page_size()) {
|
|
|
0727d3 |
+ if (remote_tps != page_size) {
|
|
|
0727d3 |
/*
|
|
|
0727d3 |
* Again, some differences could be dealt with, but for now keep it
|
|
|
0727d3 |
* simple.
|
|
|
0727d3 |
*/
|
|
|
0727d3 |
error_report("Postcopy needs matching target page sizes (s=%d d=%zd)",
|
|
|
0727d3 |
- (int)remote_tps, qemu_target_page_size());
|
|
|
0727d3 |
+ (int)remote_tps, page_size);
|
|
|
0727d3 |
return -1;
|
|
|
0727d3 |
}
|
|
|
0727d3 |
|
|
|
0727d3 |
--
|
|
|
0727d3 |
2.35.3
|
|
|
0727d3 |
|