9ae3a8
From 11ef790c7cca491bba62d8cb94018c1cf78e033c Mon Sep 17 00:00:00 2001
9ae3a8
From: Juan Quintela <quintela@redhat.com>
9ae3a8
Date: Tue, 14 Jan 2014 15:07:36 +0100
9ae3a8
Subject: [PATCH 25/40] memory: use find_next_bit() to find dirty bits
9ae3a8
9ae3a8
RH-Author: Juan Quintela <quintela@redhat.com>
9ae3a8
Message-id: <1389712071-23303-26-git-send-email-quintela@redhat.com>
9ae3a8
Patchwork-id: 56680
9ae3a8
O-Subject: [RHEL7 qemu-kvm PATCH 25/40] memory: use find_next_bit() to find dirty bits
9ae3a8
Bugzilla: 997559
9ae3a8
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
9ae3a8
RH-Acked-by: Orit Wasserman <owasserm@redhat.com>
9ae3a8
RH-Acked-by: Dr. David Alan Gilbert (git) <dgilbert@redhat.com>
9ae3a8
9ae3a8
This operation is way faster than doing it bit by bit.
9ae3a8
9ae3a8
Signed-off-by: Juan Quintela <quintela@redhat.com>
9ae3a8
Reviewed-by: Eric Blake <eblake@redhat.com>
9ae3a8
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
9ae3a8
(cherry picked from commit 1bafff0c7cb99972fd243464632eca0780c6a8f1)
9ae3a8
Signed-off-by: Juan Quintela <quintela@trasno.org>
9ae3a8
---
9ae3a8
 include/exec/memory-internal.h | 16 ++++++----------
9ae3a8
 1 file changed, 6 insertions(+), 10 deletions(-)
9ae3a8
9ae3a8
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
9ae3a8
---
9ae3a8
 include/exec/memory-internal.h |   16 ++++++----------
9ae3a8
 1 files changed, 6 insertions(+), 10 deletions(-)
9ae3a8
9ae3a8
diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
9ae3a8
index caff5b4..1eda526 100644
9ae3a8
--- a/include/exec/memory-internal.h
9ae3a8
+++ b/include/exec/memory-internal.h
9ae3a8
@@ -53,19 +53,15 @@ static inline bool cpu_physical_memory_get_dirty(ram_addr_t start,
9ae3a8
                                                  ram_addr_t length,
9ae3a8
                                                  unsigned client)
9ae3a8
 {
9ae3a8
-    ram_addr_t addr, end;
9ae3a8
+    unsigned long end, page, next;
9ae3a8
 
9ae3a8
     assert(client < DIRTY_MEMORY_NUM);
9ae3a8
 
9ae3a8
-    end = TARGET_PAGE_ALIGN(start + length);
9ae3a8
-    start &= TARGET_PAGE_MASK;
9ae3a8
-    for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
9ae3a8
-        if (test_bit(addr >> TARGET_PAGE_BITS,
9ae3a8
-                     ram_list.dirty_memory[client])) {
9ae3a8
-            return true;
9ae3a8
-        }
9ae3a8
-    }
9ae3a8
-    return false;
9ae3a8
+    end = TARGET_PAGE_ALIGN(start + length) >> TARGET_PAGE_BITS;
9ae3a8
+    page = start >> TARGET_PAGE_BITS;
9ae3a8
+    next = find_next_bit(ram_list.dirty_memory[client], end, page);
9ae3a8
+
9ae3a8
+    return next < end;
9ae3a8
 }
9ae3a8
 
9ae3a8
 static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr,
9ae3a8
-- 
9ae3a8
1.7.1
9ae3a8