|
 |
9ae3a8 |
From 67f736a89722dcaa425c70510c080e95216a165f Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Fam Zheng <famz@redhat.com>
|
|
|
9ae3a8 |
Date: Thu, 19 Jun 2014 10:21:56 +0200
|
|
|
9ae3a8 |
Subject: [PATCH 11/13] memory: Don't call memory_region_update_coalesced_range if nothing changed
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Fam Zheng <famz@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1403173316-12035-1-git-send-email-famz@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 59289
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.1/7.0.z qemu-kvm PATCH] memory: Don't call memory_region_update_coalesced_range if nothing changed
|
|
|
9ae3a8 |
Bugzilla: 1096645
|
|
|
9ae3a8 |
RH-Acked-by: Amos Kong <akong@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Brew: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=7596269
|
|
|
9ae3a8 |
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1096645
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
With huge number of PCI devices in the system (for example, 200
|
|
|
9ae3a8 |
virtio-blk-pci), this unconditional call can slow down emulation of
|
|
|
9ae3a8 |
irrelevant PCI operations drastically, such as a BAR update on a device
|
|
|
9ae3a8 |
that has no coalescing region. So avoid it.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Fam Zheng <famz@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
(cherry picked from commit ab5b3db5d711b290d63e954dc64647dd51cef962)
|
|
|
9ae3a8 |
Signed-off-by: Fam Zheng <famz@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
memory.c | 7 ++++++-
|
|
|
9ae3a8 |
1 file changed, 6 insertions(+), 1 deletion(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
memory.c | 7 ++++++-
|
|
|
9ae3a8 |
1 files changed, 6 insertions(+), 1 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/memory.c b/memory.c
|
|
|
9ae3a8 |
index edaf6fd..a71d096 100644
|
|
|
9ae3a8 |
--- a/memory.c
|
|
|
9ae3a8 |
+++ b/memory.c
|
|
|
9ae3a8 |
@@ -1210,6 +1210,7 @@ void memory_region_add_coalescing(MemoryRegion *mr,
|
|
|
9ae3a8 |
void memory_region_clear_coalescing(MemoryRegion *mr)
|
|
|
9ae3a8 |
{
|
|
|
9ae3a8 |
CoalescedMemoryRange *cmr;
|
|
|
9ae3a8 |
+ bool updated = false;
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
qemu_flush_coalesced_mmio_buffer();
|
|
|
9ae3a8 |
mr->flush_coalesced_mmio = false;
|
|
|
9ae3a8 |
@@ -1218,8 +1219,12 @@ void memory_region_clear_coalescing(MemoryRegion *mr)
|
|
|
9ae3a8 |
cmr = QTAILQ_FIRST(&mr->coalesced);
|
|
|
9ae3a8 |
QTAILQ_REMOVE(&mr->coalesced, cmr, link);
|
|
|
9ae3a8 |
g_free(cmr);
|
|
|
9ae3a8 |
+ updated = true;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
+
|
|
|
9ae3a8 |
+ if (updated) {
|
|
|
9ae3a8 |
+ memory_region_update_coalesced_range(mr);
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
- memory_region_update_coalesced_range(mr);
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
void memory_region_set_flush_coalesced(MemoryRegion *mr)
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.7.1
|
|
|
9ae3a8 |
|