ae23c9
From c0c27707f886ddbf8bc853bf8f798278b1bb713d Mon Sep 17 00:00:00 2001
ae23c9
From: Kevin Wolf <kwolf@redhat.com>
ae23c9
Date: Tue, 26 Jun 2018 09:48:53 +0200
ae23c9
Subject: [PATCH 145/268] jobs: fix stale wording
ae23c9
ae23c9
RH-Author: Kevin Wolf <kwolf@redhat.com>
ae23c9
Message-id: <20180626094856.6924-71-kwolf@redhat.com>
ae23c9
Patchwork-id: 81107
ae23c9
O-Subject: [RHV-7.6 qemu-kvm-rhev PATCH v2 70/73] jobs: fix stale wording
ae23c9
Bugzilla: 1513543
ae23c9
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
ae23c9
RH-Acked-by: Max Reitz <mreitz@redhat.com>
ae23c9
RH-Acked-by: Fam Zheng <famz@redhat.com>
ae23c9
ae23c9
From: John Snow <jsnow@redhat.com>
ae23c9
ae23c9
During the design for manual completion, we decided not to use the
ae23c9
"manual" property as a shorthand for both auto-dismiss and auto-finalize.
ae23c9
ae23c9
Fix the wording.
ae23c9
ae23c9
Signed-off-by: John Snow <jsnow@redhat.com>
ae23c9
Reviewed-by: Jeff Cody <jcody@redhat.com>
ae23c9
Reviewed-by: Markus Armbruster <armbru@redhat.com>
ae23c9
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
ae23c9
(cherry picked from commit c5b09f3f2c4db32f39ecbde2cf2f78e7a657a85d)
ae23c9
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
ae23c9
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
ae23c9
---
ae23c9
 qapi/job.json | 11 ++++++-----
ae23c9
 1 file changed, 6 insertions(+), 5 deletions(-)
ae23c9
ae23c9
diff --git a/qapi/job.json b/qapi/job.json
ae23c9
index 17d1003..2264435 100644
ae23c9
--- a/qapi/job.json
ae23c9
+++ b/qapi/job.json
ae23c9
@@ -50,16 +50,17 @@
ae23c9
 #           the last job in a transaction.
ae23c9
 #
ae23c9
 # @pending: The job has finished its work, but has finalization steps that it
ae23c9
-#           needs to make prior to completing. These changes may require
ae23c9
-#           manual intervention by the management process if manual was set
ae23c9
-#           to true. These changes may still fail.
ae23c9
+#           needs to make prior to completing. These changes will require
ae23c9
+#           manual intervention via @job-finalize if auto-finalize was set to
ae23c9
+#           false. These pending changes may still fail.
ae23c9
 #
ae23c9
 # @aborting: The job is in the process of being aborted, and will finish with
ae23c9
 #            an error. The job will afterwards report that it is @concluded.
ae23c9
 #            This status may not be visible to the management process.
ae23c9
 #
ae23c9
-# @concluded: The job has finished all work. If manual was set to true, the job
ae23c9
-#             will remain in the query list until it is dismissed.
ae23c9
+# @concluded: The job has finished all work. If auto-dismiss was set to false,
ae23c9
+#             the job will remain in the query list until it is dismissed via
ae23c9
+#             @job-dismiss.
ae23c9
 #
ae23c9
 # @null: The job is in the process of being dismantled. This state should not
ae23c9
 #        ever be visible externally.
ae23c9
-- 
ae23c9
1.8.3.1
ae23c9