From 5bb1365ea92b83615937e3082a9c250728384989 Mon Sep 17 00:00:00 2001

From: Markus Armbruster <armbru@redhat.com>

Date: Mon, 7 Oct 2019 07:35:09 +0100

Subject: [PATCH 16/22] hw/nvram/fw_cfg: Store 'reboot-timeout' as little

 endian

MIME-Version: 1.0

Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

RH-Author: Markus Armbruster <armbru@redhat.com>

Message-id: <20191007073509.5887-5-armbru@redhat.com>

Patchwork-id: 90976

O-Subject: [RHEL-8.2.0 qemu-kvm PATCH v2 4/4] hw/nvram/fw_cfg: Store 'reboot-timeout' as little endian

Bugzilla: 1607367

RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>

RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>

RH-Acked-by: Laszlo Ersek <lersek@redhat.com>

From: Li Qiang <liq3ea@163.com>

The current codebase is not specific about the endianess of the

fw_cfg 'file' entry 'reboot-timeout'.

Per docs/specs/fw_cfg.txt:

  === All Other Data Items ===

  Please consult the QEMU source for the most up-to-date

  and authoritative list of selector keys and their respective

  items' purpose, format and writeability.

Checking the git history, this code was introduced in commit

ac05f3492421, very similar to commit 3d3b8303c6f8 for the

'boot-menu-wait' entry, which explicitely use little-endian.

OVMF consumes 'boot-menu-wait' as little-endian, however it does

not consume 'reboot-timeout'.

Regarding the git history and OVMF use, we choose to explicit

'reboot-timeout' endianess as little-endian.

Signed-off-by: Li Qiang <liq3ea@163.com>

Tested-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Message-Id: <20190424140643.62457-4-liq3ea@163.com>

[PMD: Reword commit description based on review comments]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

(cherry picked from commit 04da973501b591525ce68c2925c61c8886badd4d)

Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>

---

 hw/nvram/fw_cfg.c | 4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c

index 02ab458..954de33 100644

--- a/hw/nvram/fw_cfg.c

+++ b/hw/nvram/fw_cfg.c

@@ -178,6 +178,7 @@ static void fw_cfg_reboot(FWCfgState *s)

 {

     const char *reboot_timeout = NULL;

     int64_t rt_val = -1;

+    uint32_t rt_le32;

     /* get user configuration */

     QemuOptsList *plist = qemu_find_opts("boot-opts");

@@ -194,7 +195,8 @@ static void fw_cfg_reboot(FWCfgState *s)

         }

     }

-    fw_cfg_add_file(s, "etc/boot-fail-wait", g_memdup(&rt_val, 4), 4);

+    rt_le32 = cpu_to_le32(rt_val);

+    fw_cfg_add_file(s, "etc/boot-fail-wait", g_memdup(&rt_le32, 4), 4);

 }

 static void fw_cfg_write(FWCfgState *s, uint8_t value)

-- 

1.8.3.1