|
 |
7f1c5b |
From bd5b7edbf8f4425f4b4e0d49a00cbdd48d9c6f48 Mon Sep 17 00:00:00 2001
|
|
|
7f1c5b |
From: Gavin Shan <gshan@redhat.com>
|
|
|
7f1c5b |
Date: Wed, 21 Dec 2022 08:48:45 +0800
|
|
|
7f1c5b |
Subject: [PATCH 2/8] hw/arm/virt: Rename variable size to region_size in
|
|
|
7f1c5b |
virt_set_high_memmap()
|
|
|
7f1c5b |
|
|
|
7f1c5b |
RH-Author: Gavin Shan <gshan@redhat.com>
|
|
|
7f1c5b |
RH-MergeRequest: 126: hw/arm/virt: Optimize high memory region address assignment
|
|
|
7f1c5b |
RH-Bugzilla: 2113840
|
|
|
7f1c5b |
RH-Acked-by: Eric Auger <eric.auger@redhat.com>
|
|
|
7f1c5b |
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
7f1c5b |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
7f1c5b |
RH-Commit: [2/8] 1cadf1b00686cceb45821a58fdcb509bc5da335d
|
|
|
7f1c5b |
|
|
|
7f1c5b |
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2113840
|
|
|
7f1c5b |
|
|
|
7f1c5b |
This renames variable 'size' to 'region_size' in virt_set_high_memmap().
|
|
|
7f1c5b |
Its counterpart ('region_base') will be introduced in next patch.
|
|
|
7f1c5b |
|
|
|
7f1c5b |
No functional change intended.
|
|
|
7f1c5b |
|
|
|
7f1c5b |
Signed-off-by: Gavin Shan <gshan@redhat.com>
|
|
|
7f1c5b |
Reviewed-by: Eric Auger <eric.auger@redhat.com>
|
|
|
7f1c5b |
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
7f1c5b |
Reviewed-by: Marc Zyngier <maz@kernel.org>
|
|
|
7f1c5b |
Tested-by: Zhenyu Zhang <zhenyzha@redhat.com>
|
|
|
7f1c5b |
Message-id: 20221029224307.138822-3-gshan@redhat.com
|
|
|
7f1c5b |
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
|
|
7f1c5b |
(cherry picked from commit 370bea9d1c78796eec235ed6cb4310f489931a62)
|
|
|
7f1c5b |
Signed-off-by: Gavin Shan <gshan@redhat.com>
|
|
|
7f1c5b |
---
|
|
|
7f1c5b |
hw/arm/virt.c | 15 ++++++++-------
|
|
|
7f1c5b |
1 file changed, 8 insertions(+), 7 deletions(-)
|
|
|
7f1c5b |
|
|
|
7f1c5b |
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
|
|
|
7f1c5b |
index bea5f54720..ca098d40b8 100644
|
|
|
7f1c5b |
--- a/hw/arm/virt.c
|
|
|
7f1c5b |
+++ b/hw/arm/virt.c
|
|
|
7f1c5b |
@@ -1739,15 +1739,16 @@ static uint64_t virt_cpu_mp_affinity(VirtMachineState *vms, int idx)
|
|
|
7f1c5b |
static void virt_set_high_memmap(VirtMachineState *vms,
|
|
|
7f1c5b |
hwaddr base, int pa_bits)
|
|
|
7f1c5b |
{
|
|
|
7f1c5b |
+ hwaddr region_size;
|
|
|
7f1c5b |
+ bool fits;
|
|
|
7f1c5b |
int i;
|
|
|
7f1c5b |
|
|
|
7f1c5b |
for (i = VIRT_LOWMEMMAP_LAST; i < ARRAY_SIZE(extended_memmap); i++) {
|
|
|
7f1c5b |
- hwaddr size = extended_memmap[i].size;
|
|
|
7f1c5b |
- bool fits;
|
|
|
7f1c5b |
+ region_size = extended_memmap[i].size;
|
|
|
7f1c5b |
|
|
|
7f1c5b |
- base = ROUND_UP(base, size);
|
|
|
7f1c5b |
+ base = ROUND_UP(base, region_size);
|
|
|
7f1c5b |
vms->memmap[i].base = base;
|
|
|
7f1c5b |
- vms->memmap[i].size = size;
|
|
|
7f1c5b |
+ vms->memmap[i].size = region_size;
|
|
|
7f1c5b |
|
|
|
7f1c5b |
/*
|
|
|
7f1c5b |
* Check each device to see if they fit in the PA space,
|
|
|
7f1c5b |
@@ -1755,9 +1756,9 @@ static void virt_set_high_memmap(VirtMachineState *vms,
|
|
|
7f1c5b |
*
|
|
|
7f1c5b |
* For each device that doesn't fit, disable it.
|
|
|
7f1c5b |
*/
|
|
|
7f1c5b |
- fits = (base + size) <= BIT_ULL(pa_bits);
|
|
|
7f1c5b |
+ fits = (base + region_size) <= BIT_ULL(pa_bits);
|
|
|
7f1c5b |
if (fits) {
|
|
|
7f1c5b |
- vms->highest_gpa = base + size - 1;
|
|
|
7f1c5b |
+ vms->highest_gpa = base + region_size - 1;
|
|
|
7f1c5b |
}
|
|
|
7f1c5b |
|
|
|
7f1c5b |
switch (i) {
|
|
|
7f1c5b |
@@ -1772,7 +1773,7 @@ static void virt_set_high_memmap(VirtMachineState *vms,
|
|
|
7f1c5b |
break;
|
|
|
7f1c5b |
}
|
|
|
7f1c5b |
|
|
|
7f1c5b |
- base += size;
|
|
|
7f1c5b |
+ base += region_size;
|
|
|
7f1c5b |
}
|
|
|
7f1c5b |
}
|
|
|
7f1c5b |
|
|
|
7f1c5b |
--
|
|
|
7f1c5b |
2.31.1
|
|
|
7f1c5b |
|