|
 |
9ae3a8 |
From 9c1134e8923157059587541b4f318e63ad8c39fe Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Laszlo Ersek <lersek@redhat.com>
|
|
|
9ae3a8 |
Date: Fri, 7 Nov 2014 17:17:49 +0100
|
|
|
9ae3a8 |
Subject: [PATCH 02/41] dump-guest-memory: Check for the correct return value
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Message-id: <1415380693-16593-3-git-send-email-lersek@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 62188
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.1 qemu-kvm PATCH 02/26] dump-guest-memory: Check for the correct return value
|
|
|
9ae3a8 |
Bugzilla: 1157798
|
|
|
9ae3a8 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: dgibson <dgibson@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
We should check for error with s->note_size
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
|
|
|
9ae3a8 |
Signed-off-by: Alexander Graf <agraf@suse.de>
|
|
|
9ae3a8 |
(cherry picked from commit bb6b684363e83586c90d20127b0d0a79793ab1e2)
|
|
|
9ae3a8 |
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
dump.c | 4 ++--
|
|
|
9ae3a8 |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/dump.c b/dump.c
|
|
|
9ae3a8 |
index a2b6e45..8c31386 100644
|
|
|
9ae3a8 |
--- a/dump.c
|
|
|
9ae3a8 |
+++ b/dump.c
|
|
|
9ae3a8 |
@@ -66,7 +66,7 @@ typedef struct DumpState {
|
|
|
9ae3a8 |
uint32_t sh_info;
|
|
|
9ae3a8 |
bool have_section;
|
|
|
9ae3a8 |
bool resume;
|
|
|
9ae3a8 |
- size_t note_size;
|
|
|
9ae3a8 |
+ ssize_t note_size;
|
|
|
9ae3a8 |
hwaddr memory_offset;
|
|
|
9ae3a8 |
int fd;
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
@@ -771,7 +771,7 @@ static int dump_init(DumpState *s, int fd, bool paging, bool has_filter,
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
s->note_size = cpu_get_note_size(s->dump_info.d_class,
|
|
|
9ae3a8 |
s->dump_info.d_machine, nr_cpus);
|
|
|
9ae3a8 |
- if (ret < 0) {
|
|
|
9ae3a8 |
+ if (s->note_size < 0) {
|
|
|
9ae3a8 |
error_set(errp, QERR_UNSUPPORTED);
|
|
|
9ae3a8 |
goto cleanup;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.8.3.1
|
|
|
9ae3a8 |
|