|
 |
4ec855 |
From d8de6fc3530b5cfa05485f24e14af4ce44a8b72d Mon Sep 17 00:00:00 2001
|
|
|
4ec855 |
From: Max Reitz <mreitz@redhat.com>
|
|
|
4ec855 |
Date: Tue, 19 Nov 2019 15:30:00 +0000
|
|
|
4ec855 |
Subject: [PATCH 8/8] curl: Check curl_multi_add_handle()'s return code
|
|
|
4ec855 |
MIME-Version: 1.0
|
|
|
4ec855 |
Content-Type: text/plain; charset=UTF-8
|
|
|
4ec855 |
Content-Transfer-Encoding: 8bit
|
|
|
4ec855 |
|
|
|
4ec855 |
RH-Author: Max Reitz <mreitz@redhat.com>
|
|
|
4ec855 |
Message-id: <20191119153000.101646-8-mreitz@redhat.com>
|
|
|
4ec855 |
Patchwork-id: 92521
|
|
|
4ec855 |
O-Subject: [RHEL-8.2.0 qemu-kvm PATCH 7/7] curl: Check curl_multi_add_handle()'s return code
|
|
|
4ec855 |
Bugzilla: 1744602
|
|
|
4ec855 |
RH-Acked-by: Maxim Levitsky <mlevitsk@redhat.com>
|
|
|
4ec855 |
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
|
|
4ec855 |
RH-Acked-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
|
4ec855 |
|
|
|
4ec855 |
If we had done that all along, debugging would have been much simpler.
|
|
|
4ec855 |
(Also, I/O errors are better than hangs.)
|
|
|
4ec855 |
|
|
|
4ec855 |
Signed-off-by: Max Reitz <mreitz@redhat.com>
|
|
|
4ec855 |
Message-id: 20190910124136.10565-8-mreitz@redhat.com
|
|
|
4ec855 |
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
|
|
|
4ec855 |
Reviewed-by: John Snow <jsnow@redhat.com>
|
|
|
4ec855 |
Signed-off-by: Max Reitz <mreitz@redhat.com>
|
|
|
4ec855 |
(cherry picked from commit c34dc07f9f01cf686e512f939aece744723072cd)
|
|
|
4ec855 |
Signed-off-by: Max Reitz <mreitz@redhat.com>
|
|
|
4ec855 |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
4ec855 |
---
|
|
|
4ec855 |
block/curl.c | 8 +++++++-
|
|
|
4ec855 |
1 file changed, 7 insertions(+), 1 deletion(-)
|
|
|
4ec855 |
|
|
|
4ec855 |
diff --git a/block/curl.c b/block/curl.c
|
|
|
4ec855 |
index b5899e1..5d05d30 100644
|
|
|
4ec855 |
--- a/block/curl.c
|
|
|
4ec855 |
+++ b/block/curl.c
|
|
|
4ec855 |
@@ -891,7 +891,13 @@ static void curl_setup_preadv(BlockDriverState *bs, CURLAIOCB *acb)
|
|
|
4ec855 |
acb->bytes, start, state->range);
|
|
|
4ec855 |
curl_easy_setopt(state->curl, CURLOPT_RANGE, state->range);
|
|
|
4ec855 |
|
|
|
4ec855 |
- curl_multi_add_handle(s->multi, state->curl);
|
|
|
4ec855 |
+ if (curl_multi_add_handle(s->multi, state->curl) != CURLM_OK) {
|
|
|
4ec855 |
+ state->acb[0] = NULL;
|
|
|
4ec855 |
+ acb->ret = -EIO;
|
|
|
4ec855 |
+
|
|
|
4ec855 |
+ curl_clean_state(state);
|
|
|
4ec855 |
+ goto out;
|
|
|
4ec855 |
+ }
|
|
|
4ec855 |
|
|
|
4ec855 |
/* Tell curl it needs to kick things off */
|
|
|
4ec855 |
curl_multi_socket_action(s->multi, CURL_SOCKET_TIMEOUT, 0, &running);
|
|
|
4ec855 |
--
|
|
|
4ec855 |
1.8.3.1
|
|
|
4ec855 |
|