Blame SOURCES/kvm-cpu-Document-why-cannot_instantiate_with_device_add_.patch

218e99
From d7eb9186c64094d6413bf98220e04b5350d2292d Mon Sep 17 00:00:00 2001
218e99
From: Kevin Wolf <kwolf@redhat.com>
218e99
Date: Wed, 6 Nov 2013 14:41:14 +0100
218e99
Subject: [PATCH 38/81] cpu: Document why cannot_instantiate_with_device_add_yet
218e99
218e99
RH-Author: Kevin Wolf <kwolf@redhat.com>
218e99
Message-id: <1383748882-22831-10-git-send-email-kwolf@redhat.com>
218e99
Patchwork-id: 55535
218e99
O-Subject: [RHEL-7.0 qemu-kvm PATCH v2 09/17] cpu: Document why cannot_instantiate_with_device_add_yet
218e99
Bugzilla: 1001216
218e99
RH-Acked-by: Marcel Apfelbaum <marcel.a@redhat.com>
218e99
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
218e99
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
218e99
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
218e99
218e99
From: Markus Armbruster <armbru@redhat.com>
218e99
218e99
Signed-off-by: Markus Armbruster <armbru@redhat.com>
218e99
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
218e99
(cherry picked from pending upstream submission)
218e99
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
218e99
---
218e99
 qom/cpu.c | 6 +++++-
218e99
 1 file changed, 5 insertions(+), 1 deletion(-)
218e99
218e99
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
218e99
---
218e99
 qom/cpu.c |    6 +++++-
218e99
 1 files changed, 5 insertions(+), 1 deletions(-)
218e99
218e99
diff --git a/qom/cpu.c b/qom/cpu.c
218e99
index f97e1b8..859dae5 100644
218e99
--- a/qom/cpu.c
218e99
+++ b/qom/cpu.c
218e99
@@ -210,7 +210,11 @@ static void cpu_class_init(ObjectClass *klass, void *data)
218e99
     k->write_elf64_qemunote = cpu_common_write_elf64_qemunote;
218e99
     k->write_elf64_note = cpu_common_write_elf64_note;
218e99
     dc->realize = cpu_common_realizefn;
218e99
-    dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
218e99
+    /*
218e99
+     * Reason: CPUs still need special care by board code: wiring up
218e99
+     * IRQs, adding reset handlers, halting non-first CPUS, ...
218e99
+     */
218e99
+    dc->cannot_instantiate_with_device_add_yet = true;
218e99
 }
218e99
 
218e99
 static const TypeInfo cpu_type_info = {
218e99
-- 
218e99
1.7.1
218e99