|
 |
9ae3a8 |
From d7eb9186c64094d6413bf98220e04b5350d2292d Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
Date: Wed, 6 Nov 2013 14:41:14 +0100
|
|
|
9ae3a8 |
Subject: [PATCH 38/81] cpu: Document why cannot_instantiate_with_device_add_yet
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1383748882-22831-10-git-send-email-kwolf@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 55535
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.0 qemu-kvm PATCH v2 09/17] cpu: Document why cannot_instantiate_with_device_add_yet
|
|
|
9ae3a8 |
Bugzilla: 1001216
|
|
|
9ae3a8 |
RH-Acked-by: Marcel Apfelbaum <marcel.a@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
|
|
|
9ae3a8 |
(cherry picked from pending upstream submission)
|
|
|
9ae3a8 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
qom/cpu.c | 6 +++++-
|
|
|
9ae3a8 |
1 file changed, 5 insertions(+), 1 deletion(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
qom/cpu.c | 6 +++++-
|
|
|
9ae3a8 |
1 files changed, 5 insertions(+), 1 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/qom/cpu.c b/qom/cpu.c
|
|
|
9ae3a8 |
index f97e1b8..859dae5 100644
|
|
|
9ae3a8 |
--- a/qom/cpu.c
|
|
|
9ae3a8 |
+++ b/qom/cpu.c
|
|
|
9ae3a8 |
@@ -210,7 +210,11 @@ static void cpu_class_init(ObjectClass *klass, void *data)
|
|
|
9ae3a8 |
k->write_elf64_qemunote = cpu_common_write_elf64_qemunote;
|
|
|
9ae3a8 |
k->write_elf64_note = cpu_common_write_elf64_note;
|
|
|
9ae3a8 |
dc->realize = cpu_common_realizefn;
|
|
|
9ae3a8 |
- dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
|
|
|
9ae3a8 |
+ /*
|
|
|
9ae3a8 |
+ * Reason: CPUs still need special care by board code: wiring up
|
|
|
9ae3a8 |
+ * IRQs, adding reset handlers, halting non-first CPUS, ...
|
|
|
9ae3a8 |
+ */
|
|
|
9ae3a8 |
+ dc->cannot_instantiate_with_device_add_yet = true;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
static const TypeInfo cpu_type_info = {
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.7.1
|
|
|
9ae3a8 |
|