0a122b
From 69e802baf506bd21a2f444cfebe4ac7f5b5d07a8 Mon Sep 17 00:00:00 2001
0a122b
Message-Id: <69e802baf506bd21a2f444cfebe4ac7f5b5d07a8.1389014116.git.minovotn@redhat.com>
0a122b
In-Reply-To: <c8cc35838d42aa286242772d97e3a9be7bb786ba.1389014116.git.minovotn@redhat.com>
0a122b
References: <c8cc35838d42aa286242772d97e3a9be7bb786ba.1389014116.git.minovotn@redhat.com>
0a122b
From: Paolo Bonzini <pbonzini@redhat.com>
0a122b
Date: Mon, 9 Dec 2013 14:09:02 +0100
0a122b
Subject: [PATCH 14/50] block: honour BlockLimits in bdrv_co_do_write_zeroes
0a122b
0a122b
RH-Author: Paolo Bonzini <pbonzini@redhat.com>
0a122b
Message-id: <1386598178-11845-17-git-send-email-pbonzini@redhat.com>
0a122b
Patchwork-id: 56052
0a122b
O-Subject: [RHEL 7.0 qemu-kvm PATCH 16/52] block: honour BlockLimits in bdrv_co_do_write_zeroes
0a122b
Bugzilla: 1007815
0a122b
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
0a122b
RH-Acked-by: Fam Zheng <famz@redhat.com>
0a122b
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
0a122b
0a122b
From: Peter Lieven <pl@kamp.de>
0a122b
0a122b
Reviewed-by: Eric Blake <eblake@redhat.com>
0a122b
Signed-off-by: Peter Lieven <pl@kamp.de>
0a122b
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
0a122b
(cherry picked from commit c31cb70728d2c0c8900b35a66784baa446fd5147)
0a122b
---
0a122b
 block.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++----------------
0a122b
 1 file changed, 49 insertions(+), 16 deletions(-)
0a122b
0a122b
Signed-off-by: Michal Novotny <minovotn@redhat.com>
0a122b
---
0a122b
 block.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++----------------
0a122b
 1 file changed, 49 insertions(+), 16 deletions(-)
0a122b
0a122b
diff --git a/block.c b/block.c
0a122b
index 2fae459..2ed9aa9 100644
0a122b
--- a/block.c
0a122b
+++ b/block.c
0a122b
@@ -2724,32 +2724,65 @@ int coroutine_fn bdrv_co_copy_on_readv(BlockDriverState *bs,
0a122b
                             BDRV_REQ_COPY_ON_READ);
0a122b
 }
0a122b
 
0a122b
+/* if no limit is specified in the BlockLimits use a default
0a122b
+ * of 32768 512-byte sectors (16 MiB) per request.
0a122b
+ */
0a122b
+#define MAX_WRITE_ZEROES_DEFAULT 32768
0a122b
+
0a122b
 static int coroutine_fn bdrv_co_do_write_zeroes(BlockDriverState *bs,
0a122b
     int64_t sector_num, int nb_sectors, BdrvRequestFlags flags)
0a122b
 {
0a122b
     BlockDriver *drv = bs->drv;
0a122b
     QEMUIOVector qiov;
0a122b
-    struct iovec iov;
0a122b
-    int ret;
0a122b
+    struct iovec iov = {0};
0a122b
+    int ret = 0;
0a122b
 
0a122b
-    /* TODO Emulate only part of misaligned requests instead of letting block
0a122b
-     * drivers return -ENOTSUP and emulate everything */
0a122b
+    int max_write_zeroes = bs->bl.max_write_zeroes ?
0a122b
+                           bs->bl.max_write_zeroes : MAX_WRITE_ZEROES_DEFAULT;
0a122b
 
0a122b
-    /* First try the efficient write zeroes operation */
0a122b
-    if (drv->bdrv_co_write_zeroes) {
0a122b
-        ret = drv->bdrv_co_write_zeroes(bs, sector_num, nb_sectors, flags);
0a122b
-        if (ret != -ENOTSUP) {
0a122b
-            return ret;
0a122b
+    while (nb_sectors > 0 && !ret) {
0a122b
+        int num = nb_sectors;
0a122b
+
0a122b
+        /* align request */
0a122b
+        if (bs->bl.write_zeroes_alignment &&
0a122b
+            num >= bs->bl.write_zeroes_alignment &&
0a122b
+            sector_num % bs->bl.write_zeroes_alignment) {
0a122b
+            if (num > bs->bl.write_zeroes_alignment) {
0a122b
+                num = bs->bl.write_zeroes_alignment;
0a122b
+            }
0a122b
+            num -= sector_num % bs->bl.write_zeroes_alignment;
0a122b
         }
0a122b
-    }
0a122b
 
0a122b
-    /* Fall back to bounce buffer if write zeroes is unsupported */
0a122b
-    iov.iov_len  = nb_sectors * BDRV_SECTOR_SIZE;
0a122b
-    iov.iov_base = qemu_blockalign(bs, iov.iov_len);
0a122b
-    memset(iov.iov_base, 0, iov.iov_len);
0a122b
-    qemu_iovec_init_external(&qiov, &iov, 1);
0a122b
+        /* limit request size */
0a122b
+        if (num > max_write_zeroes) {
0a122b
+            num = max_write_zeroes;
0a122b
+        }
0a122b
+
0a122b
+        ret = -ENOTSUP;
0a122b
+        /* First try the efficient write zeroes operation */
0a122b
+        if (drv->bdrv_co_write_zeroes) {
0a122b
+            ret = drv->bdrv_co_write_zeroes(bs, sector_num, num, flags);
0a122b
+        }
0a122b
+
0a122b
+        if (ret == -ENOTSUP) {
0a122b
+            /* Fall back to bounce buffer if write zeroes is unsupported */
0a122b
+            iov.iov_len = num * BDRV_SECTOR_SIZE;
0a122b
+            if (iov.iov_base == NULL) {
0a122b
+                /* allocate bounce buffer only once and ensure that it
0a122b
+                 * is big enough for this and all future requests.
0a122b
+                 */
0a122b
+                size_t bufsize = num <= nb_sectors ? num : max_write_zeroes;
0a122b
+                iov.iov_base = qemu_blockalign(bs, bufsize * BDRV_SECTOR_SIZE);
0a122b
+                memset(iov.iov_base, 0, bufsize * BDRV_SECTOR_SIZE);
0a122b
+            }
0a122b
+            qemu_iovec_init_external(&qiov, &iov, 1);
0a122b
 
0a122b
-    ret = drv->bdrv_co_writev(bs, sector_num, nb_sectors, &qiov);
0a122b
+            ret = drv->bdrv_co_writev(bs, sector_num, num, &qiov);
0a122b
+        }
0a122b
+
0a122b
+        sector_num += num;
0a122b
+        nb_sectors -= num;
0a122b
+    }
0a122b
 
0a122b
     qemu_vfree(iov.iov_base);
0a122b
     return ret;
0a122b
-- 
0a122b
1.7.11.7
0a122b