|
 |
ae23c9 |
From 088ddadf21938cfa527bb47ce5452ad502ff2c8d Mon Sep 17 00:00:00 2001
|
|
|
ae23c9 |
From: John Snow <jsnow@redhat.com>
|
|
|
ae23c9 |
Date: Wed, 18 Jul 2018 22:54:51 +0200
|
|
|
ae23c9 |
Subject: [PATCH 233/268] block: Honour BDRV_REQ_NO_SERIALISING in copy range
|
|
|
ae23c9 |
|
|
|
ae23c9 |
RH-Author: John Snow <jsnow@redhat.com>
|
|
|
ae23c9 |
Message-id: <20180718225511.14878-16-jsnow@redhat.com>
|
|
|
ae23c9 |
Patchwork-id: 81402
|
|
|
ae23c9 |
O-Subject: [RHEL-7.6 qemu-kvm-rhev PATCH 15/35] block: Honour BDRV_REQ_NO_SERIALISING in copy range
|
|
|
ae23c9 |
Bugzilla: 1207657
|
|
|
ae23c9 |
RH-Acked-by: Eric Blake <eblake@redhat.com>
|
|
|
ae23c9 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
ae23c9 |
RH-Acked-by: Fam Zheng <famz@redhat.com>
|
|
|
ae23c9 |
|
|
|
ae23c9 |
From: Fam Zheng <famz@redhat.com>
|
|
|
ae23c9 |
|
|
|
ae23c9 |
This semantics is needed by drive-backup so implement it before using
|
|
|
ae23c9 |
this API there.
|
|
|
ae23c9 |
|
|
|
ae23c9 |
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
ae23c9 |
Signed-off-by: Fam Zheng <famz@redhat.com>
|
|
|
ae23c9 |
Message-id: 20180703023758.14422-3-famz@redhat.com
|
|
|
ae23c9 |
Signed-off-by: Jeff Cody <jcody@redhat.com>
|
|
|
ae23c9 |
(cherry picked from commit dee12de89380483656072f775f5ef99f4426f966)
|
|
|
ae23c9 |
Signed-off-by: John Snow <jsnow@redhat.com>
|
|
|
ae23c9 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
ae23c9 |
---
|
|
|
ae23c9 |
block/io.c | 6 ++++--
|
|
|
ae23c9 |
include/block/block.h | 5 +++--
|
|
|
ae23c9 |
2 files changed, 7 insertions(+), 4 deletions(-)
|
|
|
ae23c9 |
|
|
|
ae23c9 |
diff --git a/block/io.c b/block/io.c
|
|
|
ae23c9 |
index 7981239..b6754f3 100644
|
|
|
ae23c9 |
--- a/block/io.c
|
|
|
ae23c9 |
+++ b/block/io.c
|
|
|
ae23c9 |
@@ -2883,8 +2883,10 @@ static int coroutine_fn bdrv_co_copy_range_internal(BdrvChild *src,
|
|
|
ae23c9 |
tracked_request_begin(&dst_req, dst->bs, dst_offset,
|
|
|
ae23c9 |
bytes, BDRV_TRACKED_WRITE);
|
|
|
ae23c9 |
|
|
|
ae23c9 |
- wait_serialising_requests(&src_req);
|
|
|
ae23c9 |
- wait_serialising_requests(&dst_req);
|
|
|
ae23c9 |
+ if (!(flags & BDRV_REQ_NO_SERIALISING)) {
|
|
|
ae23c9 |
+ wait_serialising_requests(&src_req);
|
|
|
ae23c9 |
+ wait_serialising_requests(&dst_req);
|
|
|
ae23c9 |
+ }
|
|
|
ae23c9 |
if (recurse_src) {
|
|
|
ae23c9 |
ret = src->bs->drv->bdrv_co_copy_range_from(src->bs,
|
|
|
ae23c9 |
src, src_offset,
|
|
|
ae23c9 |
diff --git a/include/block/block.h b/include/block/block.h
|
|
|
ae23c9 |
index c3cfb40..e1d5e47 100644
|
|
|
ae23c9 |
--- a/include/block/block.h
|
|
|
ae23c9 |
+++ b/include/block/block.h
|
|
|
ae23c9 |
@@ -636,13 +636,14 @@ void bdrv_unregister_buf(BlockDriverState *bs, void *host);
|
|
|
ae23c9 |
* @dst: Destination child to copy data to
|
|
|
ae23c9 |
* @dst_offset: offset in @dst image to write data
|
|
|
ae23c9 |
* @bytes: number of bytes to copy
|
|
|
ae23c9 |
- * @flags: request flags. Must be one of:
|
|
|
ae23c9 |
- * 0 - actually read data from src;
|
|
|
ae23c9 |
+ * @flags: request flags. Supported flags:
|
|
|
ae23c9 |
* BDRV_REQ_ZERO_WRITE - treat the @src range as zero data and do zero
|
|
|
ae23c9 |
* write on @dst as if bdrv_co_pwrite_zeroes is
|
|
|
ae23c9 |
* called. Used to simplify caller code, or
|
|
|
ae23c9 |
* during BlockDriver.bdrv_co_copy_range_from()
|
|
|
ae23c9 |
* recursion.
|
|
|
ae23c9 |
+ * BDRV_REQ_NO_SERIALISING - do not serialize with other overlapping
|
|
|
ae23c9 |
+ * requests currently in flight.
|
|
|
ae23c9 |
*
|
|
|
ae23c9 |
* Returns: 0 if succeeded; negative error code if failed.
|
|
|
ae23c9 |
**/
|
|
|
ae23c9 |
--
|
|
|
ae23c9 |
1.8.3.1
|
|
|
ae23c9 |
|