26ba25
From 9997a461dc882720fff3990aeca0725a91f20ac3 Mon Sep 17 00:00:00 2001
26ba25
From: Miroslav Rezanina <mrezanin@redhat.com>
26ba25
Date: Wed, 12 Sep 2018 09:43:39 +0100
26ba25
Subject: [PATCH 2/4] Fix annocheck issues
26ba25
26ba25
RH-Author: Miroslav Rezanina <mrezanin@redhat.com>
26ba25
Message-id: <1536745419-16795-1-git-send-email-mrezanin@redhat.com>
26ba25
Patchwork-id: 82139
26ba25
O-Subject: [RHEL8/rhel qemu-kvm PATCH] Fix annocheck issues
26ba25
Bugzilla: 1624164
26ba25
RH-Acked-by: Thomas Huth <thuth@redhat.com>
26ba25
RH-Acked-by: Danilo de Paula <ddepaula@redhat.com>
26ba25
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
26ba25
26ba25
From: Miroslav Rezanina <mrezanin@redhat.com>
26ba25
26ba25
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1624164
26ba25
Brew: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=18283300
26ba25
BRANCH: rhel8/master-2.12.0
26ba25
Upstream: Do we want have this upstream?
26ba25
26ba25
annocheck reports several issues with qemu-kvm packages.
26ba25
26ba25
Most of them is "Compiled without -D_GLIBCXX_ASSERTIONS.". These issues
26ba25
comes from capstone submodule as we strip all -W compile flags. We can
26ba25
add missing flag downstream but I'm not sure this change should be done
26ba25
upstream too.
26ba25
26ba25
In addition, there's "Not linked with -Wl,-z,now." error for s390-ccw.img
26ba25
and s390-netboot.img. However, this flag is used for building these files
26ba25
as build log shows.
26ba25
26ba25
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
26ba25
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
26ba25
---
26ba25
 Makefile | 1 +
26ba25
 1 file changed, 1 insertion(+)
26ba25
26ba25
diff --git a/Makefile b/Makefile
26ba25
index 9803f27..da3eedb 100644
26ba25
--- a/Makefile
26ba25
+++ b/Makefile
26ba25
@@ -502,6 +502,7 @@ CAP_CFLAGS += -DCAPSTONE_HAS_ARM
26ba25
 CAP_CFLAGS += -DCAPSTONE_HAS_ARM64
26ba25
 CAP_CFLAGS += -DCAPSTONE_HAS_POWERPC
26ba25
 CAP_CFLAGS += -DCAPSTONE_HAS_X86
26ba25
+CAP_CFLAGS += -Wp,-D_GLIBCXX_ASSERTIONS
26ba25
 
26ba25
 subdir-capstone: .git-submodule-status
26ba25
 	$(call quiet-command,$(MAKE) -C $(SRC_PATH)/capstone CAPSTONE_SHARED=no BUILDDIR="$(BUILD_DIR)/capstone" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(CAP_CFLAGS)" $(SUBDIR_MAKEFLAGS) $(BUILD_DIR)/capstone/$(LIBCAPSTONE))
26ba25
-- 
26ba25
1.8.3.1
26ba25