From 31ed4da2c4cecaeff9ebdf7bfe8c911b8411b624 Mon Sep 17 00:00:00 2001 From: John Snow Date: Wed, 20 Mar 2019 16:16:13 +0100 Subject: [PATCH 015/163] qapi: bitmap-merge: document name change RH-Author: John Snow Message-id: <20190320161631.14841-2-jsnow@redhat.com> Patchwork-id: 84947 O-Subject: [RHEL-7.7 qemu-kvm-rhev PATCH 01/19] qapi: bitmap-merge: document name change Bugzilla: 1668956 RH-Acked-by: Max Reitz RH-Acked-by: Stefan Hajnoczi RH-Acked-by: Miroslav Rezanina We named these using underscores instead of the preferred dash, document this nearby so we cannot possibly forget to rectify this when we remove the 'x-' prefixes when the feature becomes stable. We do not implement the change ahead of time to avoid more work for libvirt to do in order to figure out how to use the beta version of the API needlessly. Reported-by: Eric Blake Signed-off-by: John Snow Message-Id: <20180919190934.16284-1-jsnow@redhat.com> Reviewed-by: Eric Blake [eblake: typo fix] Signed-off-by: Eric Blake (cherry picked from commit cb9f871e80fe630422e0962751a6f9fb1795fe02) Signed-off-by: John Snow Signed-off-by: Miroslav Rezanina --- qapi/block-core.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index 9c8c9ff..0960449 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1923,6 +1923,8 @@ ## # @x-block-dirty-bitmap-merge: # +# FIXME: Rename @src_name and @dst_name to src-name and dst-name. +# # Merge @src_name dirty bitmap to @dst_name dirty bitmap. @src_name dirty # bitmap is unchanged. On error, @dst_name is unchanged. # -- 1.8.3.1