From a4a396ff1f6bf512d8a1e65f692242d4332c615c Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Mon, 19 Mar 2018 14:34:59 +0100 Subject: [PATCH 4/4] vga: fix region calculation RH-Author: Gerd Hoffmann Message-id: <20180319143459.15364-3-kraxel@redhat.com> Patchwork-id: 79360 O-Subject: [RHV7.5 qemu-kvm-rhev PATCH 2/2] vga: fix region calculation Bugzilla: 1566878 RH-Acked-by: Dr. David Alan Gilbert RH-Acked-by: Stefan Hajnoczi RH-Acked-by: Laszlo Ersek Typically the scanline length and the line offset are identical. But in case they are not our calculation for region_end is incorrect. Using line_offset is fine for all scanlines, except the last one where we have to use the actual scanline length. Fixes: CVE-2018-7550 Reported-by: Ross Lagerwall Signed-off-by: Gerd Hoffmann Reviewed-by: Prasad J Pandit Tested-by: Ross Lagerwall Message-id: 20180309143704.13420-1-kraxel@redhat.com (cherry picked from commit 7cdc61becd095b64a786b2625f321624e7111f3d) Signed-off-by: Miroslav Rezanina --- hw/display/vga.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/vga.c b/hw/display/vga.c index b6a3b95..f060f26 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1489,6 +1489,8 @@ static void vga_draw_graphic(VGACommonState *s, int full_update) region_start = (s->start_addr * 4); region_end = region_start + (ram_addr_t)s->line_offset * height; + region_end += width * s->get_bpp(s) / 8; /* scanline length */ + region_end -= s->line_offset; if (region_end > s->vbe_size) { /* wraps around (can happen with cirrus vbe modes) */ region_start = 0; -- 1.8.3.1