From c45e31fa19147b42c2e7c6a3ded711c24701f7a2 Mon Sep 17 00:00:00 2001

From: jmaloy <jmaloy@redhat.com>

Date: Thu, 28 May 2020 12:22:25 +0200

Subject: [PATCH 1/2] vnc: add magic cookie to VncState

RH-Author: jmaloy <jmaloy@redhat.com>

Message-id: <20200508213316.1251860-2-jmaloy@redhat.com>

Patchwork-id: 96349

O-Subject: [RHEL-7.9 qemu-kvm-rhev PATCH 1/2] vnc: add magic cookie to VncState

Bugzilla: 1810409

RH-Acked-by: Gerd Hoffmann <kraxel@redhat.com>

RH-Acked-by: John Snow <jsnow@redhat.com>

RH-Acked-by: Daniel P. Berrange <berrange@redhat.com>

From: Gerd Hoffmann <kraxel@redhat.com>

Set magic cookie on initialization.  Clear on cleanup.  Sprinkle a bunch

of assert()s checking the cookie, to verify the pointer is valid.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Message-id: 20180507102254.12107-1-kraxel@redhat.com

(cherry picked from commit f31f9c1080d8907c95f1501c6abab038eceb5490)

Signed-off-by: Jon Maloy <jmaloy@redhat.com>

Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>

---

 ui/vnc-jobs.c |  4 ++++

 ui/vnc.c      | 10 +++++++++-

 ui/vnc.h      |  3 +++

 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c

index 868ddde..b0b15d4 100644

--- a/ui/vnc-jobs.c

+++ b/ui/vnc-jobs.c

@@ -82,6 +82,7 @@ VncJob *vnc_job_new(VncState *vs)

 {

     VncJob *job = g_new0(VncJob, 1);

+    assert(vs->magic == VNC_MAGIC);

     job->vs = vs;

     vnc_lock_queue(queue);

     QLIST_INIT(&job->rectangles);

@@ -214,6 +215,7 @@ static int vnc_worker_thread_loop(VncJobQueue *queue)

     /* Here job can only be NULL if queue->exit is true */

     job = QTAILQ_FIRST(&queue->jobs);

     vnc_unlock_queue(queue);

+    assert(job->vs->magic == VNC_MAGIC);

     if (queue->exit) {

         return -1;

@@ -236,6 +238,7 @@ static int vnc_worker_thread_loop(VncJobQueue *queue)

     /* Make a local copy of vs and switch output buffers */

     vnc_async_encoding_start(job->vs, &vs);

+    vs.magic = VNC_MAGIC;

     /* Start sending rectangles */

     n_rectangles = 0;

@@ -289,6 +292,7 @@ disconnected:

     vnc_unlock_queue(queue);

     qemu_cond_broadcast(&queue->cond);

     g_free(job);

+    vs.magic = 0;

     return 0;

 }

diff --git a/ui/vnc.c b/ui/vnc.c

index 86c6762..fbd0da1 100644

--- a/ui/vnc.c

+++ b/ui/vnc.c

@@ -1138,6 +1138,7 @@ static void audio_capture_notify(void *opaque, audcnotification_e cmd)

 {

     VncState *vs = opaque;

+    assert(vs->magic == VNC_MAGIC);

     switch (cmd) {

     case AUD_CNOTIFY_DISABLE:

         vnc_lock_output(vs);

@@ -1167,6 +1168,7 @@ static void audio_capture(void *opaque, void *buf, int size)

 {

     VncState *vs = opaque;

+    assert(vs->magic == VNC_MAGIC);

     vnc_lock_output(vs);

     if (vs->output.offset < vs->throttle_output_offset) {

         vnc_write_u8(vs, VNC_MSG_SERVER_QEMU);

@@ -1275,6 +1277,7 @@ void vnc_disconnect_finish(VncState *vs)

     vs->ioc = NULL;

     object_unref(OBJECT(vs->sioc));

     vs->sioc = NULL;

+    vs->magic = 0;

     g_free(vs);

 }

@@ -1414,7 +1417,7 @@ static void vnc_client_write_locked(VncState *vs)

 static void vnc_client_write(VncState *vs)

 {

-

+    assert(vs->magic == VNC_MAGIC);

     vnc_lock_output(vs);

     if (vs->output.offset) {

         vnc_client_write_locked(vs);

@@ -1487,6 +1490,7 @@ static void vnc_jobs_bh(void *opaque)

 {

     VncState *vs = opaque;

+    assert(vs->magic == VNC_MAGIC);

     vnc_jobs_consume_buffer(vs);

 }

@@ -1537,6 +1541,8 @@ gboolean vnc_client_io(QIOChannel *ioc G_GNUC_UNUSED,

                        GIOCondition condition, void *opaque)

 {

     VncState *vs = opaque;

+

+    assert(vs->magic == VNC_MAGIC);

     if (condition & G_IO_IN) {

         if (vnc_client_read(vs) < 0) {

             goto end;

@@ -1567,6 +1573,7 @@ end:

 void vnc_write(VncState *vs, const void *data, size_t len)

 {

+    assert(vs->magic == VNC_MAGIC);

     if (vs->disconnecting) {

         return;

     }

@@ -3063,6 +3070,7 @@ static void vnc_connect(VncDisplay *vd, QIOChannelSocket *sioc,

     int i;

     trace_vnc_client_connect(vs, sioc);

+    vs->magic = VNC_MAGIC;

     vs->sioc = sioc;

     object_ref(OBJECT(vs->sioc));

     vs->ioc = QIO_CHANNEL(sioc);

diff --git a/ui/vnc.h b/ui/vnc.h

index 7b29def..7626329 100644

--- a/ui/vnc.h

+++ b/ui/vnc.h

@@ -255,8 +255,11 @@ typedef enum {

     VNC_STATE_UPDATE_FORCE,

 } VncStateUpdate;

+#define VNC_MAGIC ((uint64_t)0x05b3f069b3d204bb)

+

 struct VncState

 {

+    uint64_t magic;

     QIOChannelSocket *sioc; /* The underlying socket */

     QIOChannel *ioc; /* The channel currently used for I/O */

     guint ioc_tag;

-- 

1.8.3.1