|
 |
8b1478 |
From f55e32a7892964908252bb5fe3719bb22c2de2dd Mon Sep 17 00:00:00 2001
|
|
|
8b1478 |
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
|
|
|
8b1478 |
Date: Tue, 26 Nov 2019 13:27:55 +0100
|
|
|
8b1478 |
Subject: [PATCH] vhost: fix vhost_log size overflow during migration
|
|
|
8b1478 |
|
|
|
8b1478 |
RH-Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
8b1478 |
Message-id: <20191126132755.42248-2-dgilbert@redhat.com>
|
|
|
8b1478 |
Patchwork-id: 92686
|
|
|
8b1478 |
O-Subject: [RHEL-7.8 qemu-kvm-rhev PATCH 1/1] vhost: fix vhost_log size overflow during migration
|
|
|
8b1478 |
Bugzilla: 1775251
|
|
|
8b1478 |
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
8b1478 |
RH-Acked-by: Peter Xu <peterx@redhat.com>
|
|
|
8b1478 |
RH-Acked-by: Juan Quintela <quintela@redhat.com>
|
|
|
8b1478 |
|
|
|
8b1478 |
From: Li Hangjing <lihangjing@baidu.com>
|
|
|
8b1478 |
|
|
|
8b1478 |
When a guest which doesn't support multiqueue is migrated with a multi queues
|
|
|
8b1478 |
vhost-user-blk deivce, a crash will occur like:
|
|
|
8b1478 |
|
|
|
8b1478 |
0 qemu_memfd_alloc (name=<value optimized out>, size=562949953421312, seals=<value optimized out>, fd=0x7f87171fe8b4, errp=0x7f87171fe8a8) at util/memfd.c:153
|
|
|
8b1478 |
1 0x00007f883559d7cf in vhost_log_alloc (size=70368744177664, share=true) at hw/virtio/vhost.c:186
|
|
|
8b1478 |
2 0x00007f88355a0758 in vhost_log_get (listener=0x7f8838bd7940, enable=1) at qemu-2-12/hw/virtio/vhost.c:211
|
|
|
8b1478 |
3 vhost_dev_log_resize (listener=0x7f8838bd7940, enable=1) at hw/virtio/vhost.c:263
|
|
|
8b1478 |
4 vhost_migration_log (listener=0x7f8838bd7940, enable=1) at hw/virtio/vhost.c:787
|
|
|
8b1478 |
5 0x00007f88355463d6 in memory_global_dirty_log_start () at memory.c:2503
|
|
|
8b1478 |
6 0x00007f8835550577 in ram_init_bitmaps (f=0x7f88384ce600, opaque=0x7f8836024098) at migration/ram.c:2173
|
|
|
8b1478 |
7 ram_init_all (f=0x7f88384ce600, opaque=0x7f8836024098) at migration/ram.c:2192
|
|
|
8b1478 |
8 ram_save_setup (f=0x7f88384ce600, opaque=0x7f8836024098) at migration/ram.c:2219
|
|
|
8b1478 |
9 0x00007f88357a419d in qemu_savevm_state_setup (f=0x7f88384ce600) at migration/savevm.c:1002
|
|
|
8b1478 |
10 0x00007f883579fc3e in migration_thread (opaque=0x7f8837530400) at migration/migration.c:2382
|
|
|
8b1478 |
11 0x00007f8832447893 in start_thread () from /lib64/libpthread.so.0
|
|
|
8b1478 |
12 0x00007f8832178bfd in clone () from /lib64/libc.so.6
|
|
|
8b1478 |
|
|
|
8b1478 |
This is because vhost_get_log_size() returns a overflowed vhost-log size.
|
|
|
8b1478 |
In this function, it uses the uninitialized variable vqs->used_phys and
|
|
|
8b1478 |
vqs->used_size to get the vhost-log size.
|
|
|
8b1478 |
|
|
|
8b1478 |
Signed-off-by: Li Hangjing <lihangjing@baidu.com>
|
|
|
8b1478 |
Reviewed-by: Xie Yongji <xieyongji@baidu.com>
|
|
|
8b1478 |
Reviewed-by: Chai Wen <chaiwen@baidu.com>
|
|
|
8b1478 |
Message-Id: <20190603061524.24076-1-lihangjing@baidu.com>
|
|
|
8b1478 |
Cc: qemu-stable@nongnu.org
|
|
|
8b1478 |
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
|
8b1478 |
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
|
8b1478 |
(cherry picked from commit 240e647a14df9677b3a501f7b8b870e40aac3fd5)
|
|
|
8b1478 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
8b1478 |
---
|
|
|
8b1478 |
hw/virtio/vhost.c | 10 ++++++++++
|
|
|
8b1478 |
1 file changed, 10 insertions(+)
|
|
|
8b1478 |
|
|
|
8b1478 |
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
|
|
|
8b1478 |
index 1ae68ff..7bdc9c4 100644
|
|
|
8b1478 |
--- a/hw/virtio/vhost.c
|
|
|
8b1478 |
+++ b/hw/virtio/vhost.c
|
|
|
8b1478 |
@@ -131,6 +131,11 @@ static int vhost_sync_dirty_bitmap(struct vhost_dev *dev,
|
|
|
8b1478 |
}
|
|
|
8b1478 |
for (i = 0; i < dev->nvqs; ++i) {
|
|
|
8b1478 |
struct vhost_virtqueue *vq = dev->vqs + i;
|
|
|
8b1478 |
+
|
|
|
8b1478 |
+ if (!vq->used_phys && !vq->used_size) {
|
|
|
8b1478 |
+ continue;
|
|
|
8b1478 |
+ }
|
|
|
8b1478 |
+
|
|
|
8b1478 |
vhost_dev_sync_region(dev, section, start_addr, end_addr, vq->used_phys,
|
|
|
8b1478 |
range_get_last(vq->used_phys, vq->used_size));
|
|
|
8b1478 |
}
|
|
|
8b1478 |
@@ -168,6 +173,11 @@ static uint64_t vhost_get_log_size(struct vhost_dev *dev)
|
|
|
8b1478 |
}
|
|
|
8b1478 |
for (i = 0; i < dev->nvqs; ++i) {
|
|
|
8b1478 |
struct vhost_virtqueue *vq = dev->vqs + i;
|
|
|
8b1478 |
+
|
|
|
8b1478 |
+ if (!vq->used_phys && !vq->used_size) {
|
|
|
8b1478 |
+ continue;
|
|
|
8b1478 |
+ }
|
|
|
8b1478 |
+
|
|
|
8b1478 |
uint64_t last = vq->used_phys + vq->used_size - 1;
|
|
|
8b1478 |
log_size = MAX(log_size, last / VHOST_LOG_CHUNK + 1);
|
|
|
8b1478 |
}
|
|
|
8b1478 |
--
|
|
|
8b1478 |
1.8.3.1
|
|
|
8b1478 |
|