|
 |
4a2fec |
From 9e1beaad709ba68a82a54738ad7b50cac69861cc Mon Sep 17 00:00:00 2001
|
|
|
4a2fec |
From: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
Date: Fri, 17 Nov 2017 11:19:04 +0100
|
|
|
4a2fec |
Subject: [PATCH 05/15] throttle-groups: drain before detaching ThrottleState
|
|
|
4a2fec |
|
|
|
4a2fec |
RH-Author: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
Message-id: <20171117111908.8815-6-stefanha@redhat.com>
|
|
|
4a2fec |
Patchwork-id: 77740
|
|
|
4a2fec |
O-Subject: [RHV7.5 qemu-kvm-rhev PATCH 5/9] throttle-groups: drain before detaching ThrottleState
|
|
|
4a2fec |
Bugzilla: 1492295
|
|
|
4a2fec |
RH-Acked-by: John Snow <jsnow@redhat.com>
|
|
|
4a2fec |
RH-Acked-by: Laurent Vivier <lvivier@redhat.com>
|
|
|
4a2fec |
RH-Acked-by: Thomas Huth <thuth@redhat.com>
|
|
|
4a2fec |
|
|
|
4a2fec |
I/O requests hang after stop/cont commands at least since QEMU 2.10.0
|
|
|
4a2fec |
with -drive iops=100:
|
|
|
4a2fec |
|
|
|
4a2fec |
(guest)$ dd if=/dev/zero of=/dev/vdb oflag=direct count=1000
|
|
|
4a2fec |
(qemu) stop
|
|
|
4a2fec |
(qemu) cont
|
|
|
4a2fec |
...I/O is stuck...
|
|
|
4a2fec |
|
|
|
4a2fec |
This happens because blk_set_aio_context() detaches the ThrottleState
|
|
|
4a2fec |
while requests may still be in flight:
|
|
|
4a2fec |
|
|
|
4a2fec |
if (tgm->throttle_state) {
|
|
|
4a2fec |
throttle_group_detach_aio_context(tgm);
|
|
|
4a2fec |
throttle_group_attach_aio_context(tgm, new_context);
|
|
|
4a2fec |
}
|
|
|
4a2fec |
|
|
|
4a2fec |
This patch encloses the detach/attach calls in a drained region so no
|
|
|
4a2fec |
I/O request is left hanging. Also add assertions so we don't make the
|
|
|
4a2fec |
same mistake again in the future.
|
|
|
4a2fec |
|
|
|
4a2fec |
Reported-by: Yongxue Hong <yhong@redhat.com>
|
|
|
4a2fec |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
Reviewed-by: Alberto Garcia <berto@igalia.com>
|
|
|
4a2fec |
Message-id: 20171110151934.16883-1-stefanha@redhat.com
|
|
|
4a2fec |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
(cherry picked from commit dc868fb03b9b829ed9d2ecdae0fcc12f3fe19b4f)
|
|
|
4a2fec |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
4a2fec |
---
|
|
|
4a2fec |
block/block-backend.c | 2 ++
|
|
|
4a2fec |
block/throttle-groups.c | 6 ++++++
|
|
|
4a2fec |
2 files changed, 8 insertions(+)
|
|
|
4a2fec |
|
|
|
4a2fec |
diff --git a/block/block-backend.c b/block/block-backend.c
|
|
|
4a2fec |
index bfb3e84..520f2b2 100644
|
|
|
4a2fec |
--- a/block/block-backend.c
|
|
|
4a2fec |
+++ b/block/block-backend.c
|
|
|
4a2fec |
@@ -1771,8 +1771,10 @@ void blk_set_aio_context(BlockBackend *blk, AioContext *new_context)
|
|
|
4a2fec |
|
|
|
4a2fec |
if (bs) {
|
|
|
4a2fec |
if (tgm->throttle_state) {
|
|
|
4a2fec |
+ bdrv_drained_begin(bs);
|
|
|
4a2fec |
throttle_group_detach_aio_context(tgm);
|
|
|
4a2fec |
throttle_group_attach_aio_context(tgm, new_context);
|
|
|
4a2fec |
+ bdrv_drained_end(bs);
|
|
|
4a2fec |
}
|
|
|
4a2fec |
bdrv_set_aio_context(bs, new_context);
|
|
|
4a2fec |
}
|
|
|
4a2fec |
diff --git a/block/throttle-groups.c b/block/throttle-groups.c
|
|
|
4a2fec |
index 7749cf0..44cc1e6 100644
|
|
|
4a2fec |
--- a/block/throttle-groups.c
|
|
|
4a2fec |
+++ b/block/throttle-groups.c
|
|
|
4a2fec |
@@ -568,6 +568,12 @@ void throttle_group_attach_aio_context(ThrottleGroupMember *tgm,
|
|
|
4a2fec |
void throttle_group_detach_aio_context(ThrottleGroupMember *tgm)
|
|
|
4a2fec |
{
|
|
|
4a2fec |
ThrottleTimers *tt = &tgm->throttle_timers;
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+ /* Requests must have been drained */
|
|
|
4a2fec |
+ assert(tgm->pending_reqs[0] == 0 && tgm->pending_reqs[1] == 0);
|
|
|
4a2fec |
+ assert(qemu_co_queue_empty(&tgm->throttled_reqs[0]));
|
|
|
4a2fec |
+ assert(qemu_co_queue_empty(&tgm->throttled_reqs[1]));
|
|
|
4a2fec |
+
|
|
|
4a2fec |
throttle_timers_detach_aio_context(tt);
|
|
|
4a2fec |
tgm->aio_context = NULL;
|
|
|
4a2fec |
}
|
|
|
4a2fec |
--
|
|
|
4a2fec |
1.8.3.1
|
|
|
4a2fec |
|