|
 |
1bdc94 |
From afdf8a5ba72ac761081edba383699bd45968349e Mon Sep 17 00:00:00 2001
|
|
|
1bdc94 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
1bdc94 |
Date: Fri, 21 Sep 2018 12:46:28 +0200
|
|
|
1bdc94 |
Subject: [PATCH 1/3] test-bdrv-drain: Fix outdated comments
|
|
|
1bdc94 |
|
|
|
1bdc94 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
1bdc94 |
Message-id: <20180921124630.29036-2-kwolf@redhat.com>
|
|
|
1bdc94 |
Patchwork-id: 82232
|
|
|
1bdc94 |
O-Subject: [RHV-7.6 qemu-kvm-rhev PATCH 1/3] test-bdrv-drain: Fix outdated comments
|
|
|
1bdc94 |
Bugzilla: 1618584
|
|
|
1bdc94 |
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: Eric Blake <eblake@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: John Snow <jsnow@redhat.com>
|
|
|
1bdc94 |
|
|
|
1bdc94 |
Commit 89bd030533e changed the test case from using job_sleep_ns() to
|
|
|
1bdc94 |
using qemu_co_sleep_ns() instead. Also, block_job_sleep_ns() became
|
|
|
1bdc94 |
job_sleep_ns() in commit 5d43e86e11f.
|
|
|
1bdc94 |
|
|
|
1bdc94 |
In both cases, some comments in the test case were not updated. Do that
|
|
|
1bdc94 |
now.
|
|
|
1bdc94 |
|
|
|
1bdc94 |
Reported-by: Max Reitz <mreitz@redhat.com>
|
|
|
1bdc94 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
1bdc94 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
1bdc94 |
---
|
|
|
1bdc94 |
tests/test-bdrv-drain.c | 10 +++++-----
|
|
|
1bdc94 |
1 file changed, 5 insertions(+), 5 deletions(-)
|
|
|
1bdc94 |
|
|
|
1bdc94 |
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
|
|
|
1bdc94 |
index d6202b2..7e7ba9b 100644
|
|
|
1bdc94 |
--- a/tests/test-bdrv-drain.c
|
|
|
1bdc94 |
+++ b/tests/test-bdrv-drain.c
|
|
|
1bdc94 |
@@ -820,9 +820,9 @@ static int coroutine_fn test_job_run(Job *job, Error **errp)
|
|
|
1bdc94 |
|
|
|
1bdc94 |
job_transition_to_ready(&s->common.job);
|
|
|
1bdc94 |
while (!s->should_complete) {
|
|
|
1bdc94 |
- /* Avoid block_job_sleep_ns() because it marks the job as !busy. We
|
|
|
1bdc94 |
- * want to emulate some actual activity (probably some I/O) here so
|
|
|
1bdc94 |
- * that drain has to wait for this acitivity to stop. */
|
|
|
1bdc94 |
+ /* Avoid job_sleep_ns() because it marks the job as !busy. We want to
|
|
|
1bdc94 |
+ * emulate some actual activity (probably some I/O) here so that drain
|
|
|
1bdc94 |
+ * has to wait for this activity to stop. */
|
|
|
1bdc94 |
qemu_co_sleep_ns(QEMU_CLOCK_REALTIME, 100000);
|
|
|
1bdc94 |
job_pause_point(&s->common.job);
|
|
|
1bdc94 |
}
|
|
|
1bdc94 |
@@ -908,7 +908,7 @@ static void test_blockjob_common(enum drain_type drain_type, bool use_iothread,
|
|
|
1bdc94 |
|
|
|
1bdc94 |
g_assert_cmpint(job->job.pause_count, ==, 0);
|
|
|
1bdc94 |
g_assert_false(job->job.paused);
|
|
|
1bdc94 |
- g_assert_true(job->job.busy); /* We're in job_sleep_ns() */
|
|
|
1bdc94 |
+ g_assert_true(job->job.busy); /* We're in qemu_co_sleep_ns() */
|
|
|
1bdc94 |
|
|
|
1bdc94 |
do_drain_begin_unlocked(drain_type, src);
|
|
|
1bdc94 |
|
|
|
1bdc94 |
@@ -956,7 +956,7 @@ static void test_blockjob_common(enum drain_type drain_type, bool use_iothread,
|
|
|
1bdc94 |
|
|
|
1bdc94 |
g_assert_cmpint(job->job.pause_count, ==, 0);
|
|
|
1bdc94 |
g_assert_false(job->job.paused);
|
|
|
1bdc94 |
- g_assert_true(job->job.busy); /* We're in job_sleep_ns() */
|
|
|
1bdc94 |
+ g_assert_true(job->job.busy); /* We're in qemu_co_sleep_ns() */
|
|
|
1bdc94 |
|
|
|
1bdc94 |
aio_context_acquire(ctx);
|
|
|
1bdc94 |
ret = job_complete_sync(&job->job, &error_abort);
|
|
|
1bdc94 |
--
|
|
|
1bdc94 |
1.8.3.1
|
|
|
1bdc94 |
|