|
 |
1bdc94 |
From 95f87089d1bdd881775a5d09c59363f5460f7ce2 Mon Sep 17 00:00:00 2001
|
|
|
1bdc94 |
From: David Gibson <dgibson@redhat.com>
|
|
|
1bdc94 |
Date: Thu, 14 Jun 2018 01:31:36 +0200
|
|
|
1bdc94 |
Subject: [PATCH 5/9] spapr_pci: Remove unhelpful pagesize warning
|
|
|
1bdc94 |
|
|
|
1bdc94 |
RH-Author: David Gibson <dgibson@redhat.com>
|
|
|
1bdc94 |
Message-id: <20180614013136.3504-1-dgibson@redhat.com>
|
|
|
1bdc94 |
Patchwork-id: 80681
|
|
|
1bdc94 |
O-Subject: [RHEL-7.6 qemu-kvm-rhev PATCH] spapr_pci: Remove unhelpful pagesize warning
|
|
|
1bdc94 |
Bugzilla: 1505664
|
|
|
1bdc94 |
RH-Acked-by: Laurent Vivier <lvivier@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: Thomas Huth <thuth@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: Serhii Popovych <spopovyc@redhat.com>
|
|
|
1bdc94 |
|
|
|
1bdc94 |
From: David Gibson <david@gibson.dropbear.id.au>
|
|
|
1bdc94 |
|
|
|
1bdc94 |
By default, the IOMMU model built into the spapr virtual PCI host bridge
|
|
|
1bdc94 |
supports 4kiB and 64kiB IOMMU page sizes. However this can be overridden
|
|
|
1bdc94 |
which may be desirable to allow larger IOMMU page sizes when running a
|
|
|
1bdc94 |
guest with hugepage backing and passthrough devices. For that reason a
|
|
|
1bdc94 |
warning was printed when the device wasn't configured to allow the pagesize
|
|
|
1bdc94 |
with which guest RAM is backed.
|
|
|
1bdc94 |
|
|
|
1bdc94 |
Experience has proven, however, that this message is more confusing than
|
|
|
1bdc94 |
useful. Worse it sometimes makes little sense when the host-available page
|
|
|
1bdc94 |
sizes don't match those available on the guest, which can happen with
|
|
|
1bdc94 |
a POWER8 guest running on a POWER9 KVM host.
|
|
|
1bdc94 |
|
|
|
1bdc94 |
Long term we do want better handling to allow large IOMMU page sizes to be
|
|
|
1bdc94 |
used, but for now this parameter and warning don't really accomplish it.
|
|
|
1bdc94 |
So, remove the message, pending a better solution.
|
|
|
1bdc94 |
|
|
|
1bdc94 |
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
|
|
|
1bdc94 |
|
|
|
1bdc94 |
Signed-off-by: David Gibson <dgibson@redhat.com>
|
|
|
1bdc94 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
1bdc94 |
---
|
|
|
1bdc94 |
hw/ppc/spapr_pci.c | 7 -------
|
|
|
1bdc94 |
1 file changed, 7 deletions(-)
|
|
|
1bdc94 |
|
|
|
1bdc94 |
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
|
|
|
1bdc94 |
index 39a1498..f936ce6 100644
|
|
|
1bdc94 |
--- a/hw/ppc/spapr_pci.c
|
|
|
1bdc94 |
+++ b/hw/ppc/spapr_pci.c
|
|
|
1bdc94 |
@@ -1717,13 +1717,6 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp)
|
|
|
1bdc94 |
}
|
|
|
1bdc94 |
|
|
|
1bdc94 |
/* DMA setup */
|
|
|
1bdc94 |
- if (((sphb->page_size_mask & qemu_getrampagesize()) == 0)
|
|
|
1bdc94 |
- && kvm_enabled()) {
|
|
|
1bdc94 |
- warn_report("System page size 0x%lx is not enabled in page_size_mask "
|
|
|
1bdc94 |
- "(0x%"PRIx64"). Performance may be slow",
|
|
|
1bdc94 |
- qemu_getrampagesize(), sphb->page_size_mask);
|
|
|
1bdc94 |
- }
|
|
|
1bdc94 |
-
|
|
|
1bdc94 |
for (i = 0; i < windows_supported; ++i) {
|
|
|
1bdc94 |
tcet = spapr_tce_new_table(DEVICE(sphb), sphb->dma_liobn[i]);
|
|
|
1bdc94 |
if (!tcet) {
|
|
|
1bdc94 |
--
|
|
|
1bdc94 |
1.8.3.1
|
|
|
1bdc94 |
|