|
 |
4a2fec |
From c5ff50d391e5a1afa55d6f2394f404ce27c6ceb5 Mon Sep 17 00:00:00 2001
|
|
|
4a2fec |
From: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
Date: Fri, 22 Dec 2017 11:08:56 +0100
|
|
|
4a2fec |
Subject: [PATCH 38/42] qemu-iotests: add 202 external snapshots IOThread test
|
|
|
4a2fec |
|
|
|
4a2fec |
RH-Author: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
Message-id: <20171222110900.24813-17-stefanha@redhat.com>
|
|
|
4a2fec |
Patchwork-id: 78496
|
|
|
4a2fec |
O-Subject: [RHV7.5 qemu-kvm-rhev PATCH 16/20] qemu-iotests: add 202 external snapshots IOThread test
|
|
|
4a2fec |
Bugzilla: 1519721
|
|
|
4a2fec |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
4a2fec |
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
|
|
|
4a2fec |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
4a2fec |
|
|
|
4a2fec |
QMP 'transaction' blockdev-snapshot-sync with multiple disks in an
|
|
|
4a2fec |
IOThread is an untested code path. Several bugs have been found in
|
|
|
4a2fec |
connection with this command. This patch adds a test case to prevent
|
|
|
4a2fec |
future regressions.
|
|
|
4a2fec |
|
|
|
4a2fec |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
4a2fec |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
4a2fec |
Message-id: 20171206144550.22295-10-stefanha@redhat.com
|
|
|
4a2fec |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
(cherry picked from commit 6dd64919ea36db9fd7e754ed394c25ced45ea39a)
|
|
|
4a2fec |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
4a2fec |
---
|
|
|
4a2fec |
tests/qemu-iotests/202 | 95 ++++++++++++++++++++++++++++++++++++++++++++++
|
|
|
4a2fec |
tests/qemu-iotests/202.out | 11 ++++++
|
|
|
4a2fec |
tests/qemu-iotests/group | 1 +
|
|
|
4a2fec |
3 files changed, 107 insertions(+)
|
|
|
4a2fec |
create mode 100755 tests/qemu-iotests/202
|
|
|
4a2fec |
create mode 100644 tests/qemu-iotests/202.out
|
|
|
4a2fec |
|
|
|
4a2fec |
diff --git a/tests/qemu-iotests/202 b/tests/qemu-iotests/202
|
|
|
4a2fec |
new file mode 100755
|
|
|
4a2fec |
index 0000000..581ca34
|
|
|
4a2fec |
--- /dev/null
|
|
|
4a2fec |
+++ b/tests/qemu-iotests/202
|
|
|
4a2fec |
@@ -0,0 +1,95 @@
|
|
|
4a2fec |
+#!/usr/bin/env python
|
|
|
4a2fec |
+#
|
|
|
4a2fec |
+# Copyright (C) 2017 Red Hat, Inc.
|
|
|
4a2fec |
+#
|
|
|
4a2fec |
+# This program is free software; you can redistribute it and/or modify
|
|
|
4a2fec |
+# it under the terms of the GNU General Public License as published by
|
|
|
4a2fec |
+# the Free Software Foundation; either version 2 of the License, or
|
|
|
4a2fec |
+# (at your option) any later version.
|
|
|
4a2fec |
+#
|
|
|
4a2fec |
+# This program is distributed in the hope that it will be useful,
|
|
|
4a2fec |
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
4a2fec |
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
4a2fec |
+# GNU General Public License for more details.
|
|
|
4a2fec |
+#
|
|
|
4a2fec |
+# You should have received a copy of the GNU General Public License
|
|
|
4a2fec |
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
4a2fec |
+#
|
|
|
4a2fec |
+# Creator/Owner: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
+#
|
|
|
4a2fec |
+# Check that QMP 'transaction' blockdev-snapshot-sync with multiple drives on a
|
|
|
4a2fec |
+# single IOThread completes successfully. This particular command triggered a
|
|
|
4a2fec |
+# hang due to recursive AioContext locking and BDRV_POLL_WHILE(). Protect
|
|
|
4a2fec |
+# against regressions.
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+import iotests
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+iotests.verify_image_format(supported_fmts=['qcow2'])
|
|
|
4a2fec |
+iotests.verify_platform(['linux'])
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+with iotests.FilePath('disk0.img') as disk0_img_path, \
|
|
|
4a2fec |
+ iotests.FilePath('disk1.img') as disk1_img_path, \
|
|
|
4a2fec |
+ iotests.FilePath('disk0-snap.img') as disk0_snap_img_path, \
|
|
|
4a2fec |
+ iotests.FilePath('disk1-snap.img') as disk1_snap_img_path, \
|
|
|
4a2fec |
+ iotests.VM() as vm:
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+ img_size = '10M'
|
|
|
4a2fec |
+ iotests.qemu_img_pipe('create', '-f', iotests.imgfmt, disk0_img_path, img_size)
|
|
|
4a2fec |
+ iotests.qemu_img_pipe('create', '-f', iotests.imgfmt, disk1_img_path, img_size)
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+ iotests.log('Launching VM...')
|
|
|
4a2fec |
+ vm.launch()
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+ iotests.log('Adding IOThread...')
|
|
|
4a2fec |
+ iotests.log(vm.qmp('object-add',
|
|
|
4a2fec |
+ qom_type='iothread',
|
|
|
4a2fec |
+ id='iothread0'))
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+ iotests.log('Adding blockdevs...')
|
|
|
4a2fec |
+ iotests.log(vm.qmp('blockdev-add',
|
|
|
4a2fec |
+ driver=iotests.imgfmt,
|
|
|
4a2fec |
+ node_name='disk0',
|
|
|
4a2fec |
+ file={
|
|
|
4a2fec |
+ 'driver': 'file',
|
|
|
4a2fec |
+ 'filename': disk0_img_path,
|
|
|
4a2fec |
+ }))
|
|
|
4a2fec |
+ iotests.log(vm.qmp('blockdev-add',
|
|
|
4a2fec |
+ driver=iotests.imgfmt,
|
|
|
4a2fec |
+ node_name='disk1',
|
|
|
4a2fec |
+ file={
|
|
|
4a2fec |
+ 'driver': 'file',
|
|
|
4a2fec |
+ 'filename': disk1_img_path,
|
|
|
4a2fec |
+ }))
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+ iotests.log('Setting iothread...')
|
|
|
4a2fec |
+ iotests.log(vm.qmp('x-blockdev-set-iothread',
|
|
|
4a2fec |
+ node_name='disk0',
|
|
|
4a2fec |
+ iothread='iothread0'))
|
|
|
4a2fec |
+ iotests.log(vm.qmp('x-blockdev-set-iothread',
|
|
|
4a2fec |
+ node_name='disk1',
|
|
|
4a2fec |
+ iothread='iothread0'))
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+ iotests.log('Creating external snapshots...')
|
|
|
4a2fec |
+ iotests.log(vm.qmp(
|
|
|
4a2fec |
+ 'transaction',
|
|
|
4a2fec |
+ actions=[
|
|
|
4a2fec |
+ {
|
|
|
4a2fec |
+ 'data': {
|
|
|
4a2fec |
+ 'node-name': 'disk0',
|
|
|
4a2fec |
+ 'snapshot-file': disk0_snap_img_path,
|
|
|
4a2fec |
+ 'snapshot-node-name': 'disk0-snap',
|
|
|
4a2fec |
+ 'mode': 'absolute-paths',
|
|
|
4a2fec |
+ 'format': iotests.imgfmt,
|
|
|
4a2fec |
+ },
|
|
|
4a2fec |
+ 'type': 'blockdev-snapshot-sync'
|
|
|
4a2fec |
+ }, {
|
|
|
4a2fec |
+ 'data': {
|
|
|
4a2fec |
+ 'node-name': 'disk1',
|
|
|
4a2fec |
+ 'snapshot-file': disk1_snap_img_path,
|
|
|
4a2fec |
+ 'snapshot-node-name': 'disk1-snap',
|
|
|
4a2fec |
+ 'mode': 'absolute-paths',
|
|
|
4a2fec |
+ 'format': iotests.imgfmt
|
|
|
4a2fec |
+ },
|
|
|
4a2fec |
+ 'type': 'blockdev-snapshot-sync'
|
|
|
4a2fec |
+ }
|
|
|
4a2fec |
+ ]))
|
|
|
4a2fec |
diff --git a/tests/qemu-iotests/202.out b/tests/qemu-iotests/202.out
|
|
|
4a2fec |
new file mode 100644
|
|
|
4a2fec |
index 0000000..d5ea374
|
|
|
4a2fec |
--- /dev/null
|
|
|
4a2fec |
+++ b/tests/qemu-iotests/202.out
|
|
|
4a2fec |
@@ -0,0 +1,11 @@
|
|
|
4a2fec |
+Launching VM...
|
|
|
4a2fec |
+Adding IOThread...
|
|
|
4a2fec |
+{u'return': {}}
|
|
|
4a2fec |
+Adding blockdevs...
|
|
|
4a2fec |
+{u'return': {}}
|
|
|
4a2fec |
+{u'return': {}}
|
|
|
4a2fec |
+Setting iothread...
|
|
|
4a2fec |
+{u'return': {}}
|
|
|
4a2fec |
+{u'return': {}}
|
|
|
4a2fec |
+Creating external snapshots...
|
|
|
4a2fec |
+{u'return': {}}
|
|
|
4a2fec |
diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
|
|
|
4a2fec |
index 39b61ce..8d3752c 100644
|
|
|
4a2fec |
--- a/tests/qemu-iotests/group
|
|
|
4a2fec |
+++ b/tests/qemu-iotests/group
|
|
|
4a2fec |
@@ -191,3 +191,4 @@
|
|
|
4a2fec |
195 rw auto quick
|
|
|
4a2fec |
198 rw auto
|
|
|
4a2fec |
200 rw auto
|
|
|
4a2fec |
+202 rw auto quick
|
|
|
4a2fec |
--
|
|
|
4a2fec |
1.8.3.1
|
|
|
4a2fec |
|