|
 |
357786 |
From 52970228a0ba4956ed98cb1ae370b16dd740c9e4 Mon Sep 17 00:00:00 2001
|
|
|
357786 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
357786 |
Date: Mon, 2 Jul 2018 15:40:08 +0200
|
|
|
357786 |
Subject: [PATCH 55/57] qemu-iotests: Test qcow2 not leaking clusters on write
|
|
|
357786 |
error
|
|
|
357786 |
|
|
|
357786 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
357786 |
Message-id: <20180702154008.15533-4-kwolf@redhat.com>
|
|
|
357786 |
Patchwork-id: 81187
|
|
|
357786 |
O-Subject: [RHV-7.6 qemu-kvm-rhev PATCH 3/3] qemu-iotests: Test qcow2 not leaking clusters on write error
|
|
|
357786 |
Bugzilla: 1528541
|
|
|
357786 |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
357786 |
RH-Acked-by: Fam Zheng <famz@redhat.com>
|
|
|
357786 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
357786 |
|
|
|
357786 |
This adds a test for a temporary write failure, which simulates the
|
|
|
357786 |
situation after werror=stop/enospc has stopped the VM. We shouldn't
|
|
|
357786 |
leave leaked clusters behind in such cases.
|
|
|
357786 |
|
|
|
357786 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
357786 |
Reviewed-by: Max Reitz <mreitz@redhat.com>
|
|
|
357786 |
(cherry picked from commit ae376c6255d0eee4b3c4d60acc4679aa99c0d2c8)
|
|
|
357786 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
357786 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
357786 |
---
|
|
|
357786 |
tests/qemu-iotests/026 | 17 +++++++++++++++++
|
|
|
357786 |
tests/qemu-iotests/026.out | 8 ++++++++
|
|
|
357786 |
tests/qemu-iotests/026.out.nocache | 8 ++++++++
|
|
|
357786 |
3 files changed, 33 insertions(+)
|
|
|
357786 |
|
|
|
357786 |
diff --git a/tests/qemu-iotests/026 b/tests/qemu-iotests/026
|
|
|
357786 |
index 7fadfba..582d254 100755
|
|
|
357786 |
--- a/tests/qemu-iotests/026
|
|
|
357786 |
+++ b/tests/qemu-iotests/026
|
|
|
357786 |
@@ -200,6 +200,23 @@ done
|
|
|
357786 |
done
|
|
|
357786 |
done
|
|
|
357786 |
|
|
|
357786 |
+echo
|
|
|
357786 |
+echo === Avoid cluster leaks after temporary failure ===
|
|
|
357786 |
+echo
|
|
|
357786 |
+
|
|
|
357786 |
+cat > "$TEST_DIR/blkdebug.conf" <
|
|
|
357786 |
+[inject-error]
|
|
|
357786 |
+event = "write_aio"
|
|
|
357786 |
+errno = "5"
|
|
|
357786 |
+once = "on"
|
|
|
357786 |
+EOF
|
|
|
357786 |
+
|
|
|
357786 |
+# After the failed first write, do a second write so that the updated refcount
|
|
|
357786 |
+# block is actually written back
|
|
|
357786 |
+_make_test_img 64M
|
|
|
357786 |
+$QEMU_IO -c "write 0 1M" -c "write 0 1M" "$BLKDBG_TEST_IMG" | _filter_qemu_io
|
|
|
357786 |
+_check_test_img
|
|
|
357786 |
+
|
|
|
357786 |
# success, all done
|
|
|
357786 |
echo "*** done"
|
|
|
357786 |
rm -f $seq.full
|
|
|
357786 |
diff --git a/tests/qemu-iotests/026.out b/tests/qemu-iotests/026.out
|
|
|
357786 |
index 8e89416..dd10a82 100644
|
|
|
357786 |
--- a/tests/qemu-iotests/026.out
|
|
|
357786 |
+++ b/tests/qemu-iotests/026.out
|
|
|
357786 |
@@ -675,4 +675,12 @@ write failed: No space left on device
|
|
|
357786 |
|
|
|
357786 |
96 leaked clusters were found on the image.
|
|
|
357786 |
This means waste of disk space, but no harm to data.
|
|
|
357786 |
+
|
|
|
357786 |
+=== Avoid cluster leaks after temporary failure ===
|
|
|
357786 |
+
|
|
|
357786 |
+Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
|
|
|
357786 |
+write failed: Input/output error
|
|
|
357786 |
+wrote 1048576/1048576 bytes at offset 0
|
|
|
357786 |
+1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
357786 |
+No errors were found on the image.
|
|
|
357786 |
*** done
|
|
|
357786 |
diff --git a/tests/qemu-iotests/026.out.nocache b/tests/qemu-iotests/026.out.nocache
|
|
|
357786 |
index 650ccd8..1ca6cda 100644
|
|
|
357786 |
--- a/tests/qemu-iotests/026.out.nocache
|
|
|
357786 |
+++ b/tests/qemu-iotests/026.out.nocache
|
|
|
357786 |
@@ -683,4 +683,12 @@ write failed: No space left on device
|
|
|
357786 |
|
|
|
357786 |
96 leaked clusters were found on the image.
|
|
|
357786 |
This means waste of disk space, but no harm to data.
|
|
|
357786 |
+
|
|
|
357786 |
+=== Avoid cluster leaks after temporary failure ===
|
|
|
357786 |
+
|
|
|
357786 |
+Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
|
|
|
357786 |
+write failed: Input/output error
|
|
|
357786 |
+wrote 1048576/1048576 bytes at offset 0
|
|
|
357786 |
+1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
357786 |
+No errors were found on the image.
|
|
|
357786 |
*** done
|
|
|
357786 |
--
|
|
|
357786 |
1.8.3.1
|
|
|
357786 |
|