|
 |
9bac43 |
From f2c23150bc8b51e7b6c78f98cc38880ff1e5e811 Mon Sep 17 00:00:00 2001
|
|
|
9bac43 |
From: Max Reitz <mreitz@redhat.com>
|
|
|
9bac43 |
Date: Mon, 27 Nov 2017 16:19:57 +0100
|
|
|
9bac43 |
Subject: [PATCH 02/21] qcow2: Fix unaligned preallocated truncation
|
|
|
9bac43 |
|
|
|
9bac43 |
RH-Author: Max Reitz <mreitz@redhat.com>
|
|
|
9bac43 |
Message-id: <20171127161959.13234-3-mreitz@redhat.com>
|
|
|
9bac43 |
Patchwork-id: 77911
|
|
|
9bac43 |
O-Subject: [RHV-7.5 qemu-kvm-rhev PATCH 2/4] qcow2: Fix unaligned preallocated truncation
|
|
|
9bac43 |
Bugzilla: 1414049
|
|
|
9bac43 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
9bac43 |
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
|
|
|
9bac43 |
RH-Acked-by: Fam Zheng <famz@redhat.com>
|
|
|
9bac43 |
RH-Acked-by: John Snow <jsnow@redhat.com>
|
|
|
9bac43 |
|
|
|
9bac43 |
A qcow2 image file's length is not required to have a length that is a
|
|
|
9bac43 |
multiple of the cluster size. However, qcow2_refcount_area() expects an
|
|
|
9bac43 |
aligned value for its @start_offset parameter, so we need to round
|
|
|
9bac43 |
@old_file_size up to the next cluster boundary.
|
|
|
9bac43 |
|
|
|
9bac43 |
Reported-by: Ping Li <pingl@redhat.com>
|
|
|
9bac43 |
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1414049
|
|
|
9bac43 |
Signed-off-by: Max Reitz <mreitz@redhat.com>
|
|
|
9bac43 |
Message-id: 20171009215533.12530-2-mreitz@redhat.com
|
|
|
9bac43 |
Cc: qemu-stable@nongnu.org
|
|
|
9bac43 |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
9bac43 |
Reviewed-by: Jeff Cody <jcody@redhat.com>
|
|
|
9bac43 |
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
9bac43 |
Signed-off-by: Max Reitz <mreitz@redhat.com>
|
|
|
9bac43 |
(cherry picked from commit e400ad1e1f0127b4fdabcb1c8de1e99be91788df)
|
|
|
9bac43 |
Signed-off-by: Max Reitz <mreitz@redhat.com>
|
|
|
9bac43 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9bac43 |
---
|
|
|
9bac43 |
block/qcow2.c | 1 +
|
|
|
9bac43 |
1 file changed, 1 insertion(+)
|
|
|
9bac43 |
|
|
|
9bac43 |
diff --git a/block/qcow2.c b/block/qcow2.c
|
|
|
9bac43 |
index af7b1e7..2cfe706 100644
|
|
|
9bac43 |
--- a/block/qcow2.c
|
|
|
9bac43 |
+++ b/block/qcow2.c
|
|
|
9bac43 |
@@ -3161,6 +3161,7 @@ static int qcow2_truncate(BlockDriverState *bs, int64_t offset,
|
|
|
9bac43 |
"Failed to inquire current file length");
|
|
|
9bac43 |
return old_file_size;
|
|
|
9bac43 |
}
|
|
|
9bac43 |
+ old_file_size = ROUND_UP(old_file_size, s->cluster_size);
|
|
|
9bac43 |
|
|
|
9bac43 |
nb_new_data_clusters = DIV_ROUND_UP(offset - old_length,
|
|
|
9bac43 |
s->cluster_size);
|
|
|
9bac43 |
--
|
|
|
9bac43 |
1.8.3.1
|
|
|
9bac43 |
|