|
 |
1bdc94 |
From e25487ca5ac49460e5a0dcb802866f156485f188 Mon Sep 17 00:00:00 2001
|
|
|
1bdc94 |
From: Thomas Huth <thuth@redhat.com>
|
|
|
1bdc94 |
Date: Mon, 7 May 2018 07:58:04 +0200
|
|
|
1bdc94 |
Subject: [PATCH 08/13] pc-bios/s390-ccw: size_t should be unsigned
|
|
|
1bdc94 |
|
|
|
1bdc94 |
RH-Author: Thomas Huth <thuth@redhat.com>
|
|
|
1bdc94 |
Message-id: <1525679888-9234-3-git-send-email-thuth@redhat.com>
|
|
|
1bdc94 |
Patchwork-id: 80050
|
|
|
1bdc94 |
O-Subject: [RHEL-7.6 qemu-kvm-ma PATCH 2/6] pc-bios/s390-ccw: size_t should be unsigned
|
|
|
1bdc94 |
Bugzilla: 1523857
|
|
|
1bdc94 |
RH-Acked-by: David Hildenbrand <david@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
1bdc94 |
|
|
|
1bdc94 |
"size_t" should be an unsigned type according to the C standard.
|
|
|
1bdc94 |
Thus we should also use this convention in the s390-ccw firmware to avoid
|
|
|
1bdc94 |
confusion. I checked the sources, and apart from one spot in libc.c, the
|
|
|
1bdc94 |
code should all be fine with this change.
|
|
|
1bdc94 |
|
|
|
1bdc94 |
Buglink: https://bugs.launchpad.net/qemu/+bug/1753437
|
|
|
1bdc94 |
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
|
|
|
1bdc94 |
Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
|
|
|
1bdc94 |
Reviewed-by: Collin Walling <walling@linux.ibm.com>
|
|
|
1bdc94 |
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
|
1bdc94 |
(cherry picked from commit e4f869621203955761cf274c87d5595e9facd319)
|
|
|
1bdc94 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
1bdc94 |
---
|
|
|
1bdc94 |
pc-bios/s390-ccw/libc.c | 2 +-
|
|
|
1bdc94 |
pc-bios/s390-ccw/libc.h | 2 +-
|
|
|
1bdc94 |
2 files changed, 2 insertions(+), 2 deletions(-)
|
|
|
1bdc94 |
|
|
|
1bdc94 |
diff --git a/pc-bios/s390-ccw/libc.c b/pc-bios/s390-ccw/libc.c
|
|
|
1bdc94 |
index 38ea77d..a786566 100644
|
|
|
1bdc94 |
--- a/pc-bios/s390-ccw/libc.c
|
|
|
1bdc94 |
+++ b/pc-bios/s390-ccw/libc.c
|
|
|
1bdc94 |
@@ -63,7 +63,7 @@ uint64_t atoui(const char *str)
|
|
|
1bdc94 |
*/
|
|
|
1bdc94 |
char *uitoa(uint64_t num, char *str, size_t len)
|
|
|
1bdc94 |
{
|
|
|
1bdc94 |
- size_t num_idx = 1; /* account for NUL */
|
|
|
1bdc94 |
+ long num_idx = 1; /* account for NUL */
|
|
|
1bdc94 |
uint64_t tmp = num;
|
|
|
1bdc94 |
|
|
|
1bdc94 |
IPL_assert(str != NULL, "uitoa: no space allocated to store string");
|
|
|
1bdc94 |
diff --git a/pc-bios/s390-ccw/libc.h b/pc-bios/s390-ccw/libc.h
|
|
|
1bdc94 |
index 63ece70..818517f 100644
|
|
|
1bdc94 |
--- a/pc-bios/s390-ccw/libc.h
|
|
|
1bdc94 |
+++ b/pc-bios/s390-ccw/libc.h
|
|
|
1bdc94 |
@@ -12,7 +12,7 @@
|
|
|
1bdc94 |
#ifndef S390_CCW_LIBC_H
|
|
|
1bdc94 |
#define S390_CCW_LIBC_H
|
|
|
1bdc94 |
|
|
|
1bdc94 |
-typedef long size_t;
|
|
|
1bdc94 |
+typedef unsigned long size_t;
|
|
|
1bdc94 |
typedef int bool;
|
|
|
1bdc94 |
typedef unsigned char uint8_t;
|
|
|
1bdc94 |
typedef unsigned short uint16_t;
|
|
|
1bdc94 |
--
|
|
|
1bdc94 |
1.8.3.1
|
|
|
1bdc94 |
|