From 29dceceeaac867e78dcf4b8ef121f361b14e06b4 Mon Sep 17 00:00:00 2001

From: Kevin Wolf <kwolf@redhat.com>

Date: Tue, 26 Jun 2018 09:48:20 +0200

Subject: [PATCH 51/89] job: Move job_finish_sync() to Job

RH-Author: Kevin Wolf <kwolf@redhat.com>

Message-id: <20180626094856.6924-38-kwolf@redhat.com>

Patchwork-id: 81076

O-Subject: [RHV-7.6 qemu-kvm-rhev PATCH v2 37/73] job: Move job_finish_sync() to Job

Bugzilla: 1513543

RH-Acked-by: Jeffrey Cody <jcody@redhat.com>

RH-Acked-by: Max Reitz <mreitz@redhat.com>

RH-Acked-by: Fam Zheng <famz@redhat.com>

block_job_finish_sync() doesn't contain anything block job specific any

more, so it can be moved to Job.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Max Reitz <mreitz@redhat.com>

(cherry picked from commit 6a74c075aca731e7e945201a4ae2336b8e328433)

Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>

---

 block/commit.c     |  6 +++---

 blockjob.c         | 55 +++++++++---------------------------------------------

 include/qemu/job.h |  9 +++++++++

 job.c              | 28 +++++++++++++++++++++++++++

 4 files changed, 49 insertions(+), 49 deletions(-)

diff --git a/block/commit.c b/block/commit.c

index 02a8af9..40d97a3 100644

--- a/block/commit.c

+++ b/block/commit.c

@@ -112,9 +112,9 @@ static void commit_complete(Job *job, void *opaque)

     blk_unref(s->top);

     /* If there is more than one reference to the job (e.g. if called from

-     * block_job_finish_sync()), block_job_completed() won't free it and

-     * therefore the blockers on the intermediate nodes remain. This would

-     * cause bdrv_set_backing_hd() to fail. */

+     * job_finish_sync()), block_job_completed() won't free it and therefore

+     * the blockers on the intermediate nodes remain. This would cause

+     * bdrv_set_backing_hd() to fail. */

     block_job_remove_all_bdrv(bjob);

     block_job_completed(&s->common, ret);

diff --git a/blockjob.c b/blockjob.c

index 0ca7672..1ed3e9c 100644

--- a/blockjob.c

+++ b/blockjob.c

@@ -307,40 +307,6 @@ static int block_job_txn_apply(BlockJobTxn *txn, int fn(BlockJob *), bool lock)

     return rc;

 }

-static int block_job_finish_sync(BlockJob *job,

-                                 void (*finish)(BlockJob *, Error **errp),

-                                 Error **errp)

-{

-    Error *local_err = NULL;

-    int ret;

-

-    assert(blk_bs(job->blk)->job == job);

-

-    job_ref(&job->job);

-

-    if (finish) {

-        finish(job, &local_err);

-    }

-    if (local_err) {

-        error_propagate(errp, local_err);

-        job_unref(&job->job);

-        return -EBUSY;

-    }

-    /* job_drain calls job_enter, and it should be enough to induce progress

-     * until the job completes or moves to the main thread.

-    */

-    while (!job->job.deferred_to_main_loop && !job_is_completed(&job->job)) {

-        job_drain(&job->job);

-    }

-    while (!job_is_completed(&job->job)) {

-        aio_poll(qemu_get_aio_context(), true);

-    }

-    ret = (job_is_cancelled(&job->job) && job->job.ret == 0)

-          ? -ECANCELED : job->job.ret;

-    job_unref(&job->job);

-    return ret;

-}

-

 static void block_job_completed_txn_abort(BlockJob *job)

 {

     AioContext *ctx;

@@ -375,7 +341,7 @@ static void block_job_completed_txn_abort(BlockJob *job)

         ctx = blk_get_aio_context(other_job->blk);

         if (!job_is_completed(&other_job->job)) {

             assert(job_is_cancelled(&other_job->job));

-            block_job_finish_sync(other_job, NULL, NULL);

+            job_finish_sync(&other_job->job, NULL, NULL);

         }

         job_finalize_single(&other_job->job);

         aio_context_release(ctx);

@@ -528,16 +494,18 @@ void block_job_user_cancel(BlockJob *job, bool force, Error **errp)

 }

 /* A wrapper around block_job_cancel() taking an Error ** parameter so it may be

- * used with block_job_finish_sync() without the need for (rather nasty)

- * function pointer casts there. */

-static void block_job_cancel_err(BlockJob *job, Error **errp)

+ * used with job_finish_sync() without the need for (rather nasty) function

+ * pointer casts there. */

+static void block_job_cancel_err(Job *job, Error **errp)

 {

-    block_job_cancel(job, false);

+    BlockJob *bjob = container_of(job, BlockJob, job);

+    assert(is_block_job(job));

+    block_job_cancel(bjob, false);

 }

 int block_job_cancel_sync(BlockJob *job)

 {

-    return block_job_finish_sync(job, &block_job_cancel_err, NULL);

+    return job_finish_sync(&job->job, &block_job_cancel_err, NULL);

 }

 void block_job_cancel_sync_all(void)

@@ -553,14 +521,9 @@ void block_job_cancel_sync_all(void)

     }

 }

-static void block_job_complete(BlockJob *job, Error **errp)

-{

-    job_complete(&job->job, errp);

-}

-

 int block_job_complete_sync(BlockJob *job, Error **errp)

 {

-    return block_job_finish_sync(job, &block_job_complete, errp);

+    return job_finish_sync(&job->job, job_complete, errp);

 }

 void block_job_progress_update(BlockJob *job, uint64_t done)

diff --git a/include/qemu/job.h b/include/qemu/job.h

index 8f7f71a..17e2cec 100644

--- a/include/qemu/job.h

+++ b/include/qemu/job.h

@@ -389,6 +389,15 @@ typedef void JobDeferToMainLoopFn(Job *job, void *opaque);

  */

 void job_defer_to_main_loop(Job *job, JobDeferToMainLoopFn *fn, void *opaque);

+/**

+ * Synchronously finishes the given @job. If @finish is given, it is called to

+ * trigger completion or cancellation of the job.

+ *

+ * Returns 0 if the job is successfully completed, -ECANCELED if the job was

+ * cancelled before completing, and -errno in other error cases.

+ */

+int job_finish_sync(Job *job, void (*finish)(Job *, Error **errp), Error **errp);

+

 /* TODO To be removed from the public interface */

 void job_state_transition(Job *job, JobStatus s1);

 void coroutine_fn job_do_yield(Job *job, uint64_t ns);

diff --git a/job.c b/job.c

index 8ceac0b..aa74b4c 100644

--- a/job.c

+++ b/job.c

@@ -603,3 +603,31 @@ void job_defer_to_main_loop(Job *job, JobDeferToMainLoopFn *fn, void *opaque)

     aio_bh_schedule_oneshot(qemu_get_aio_context(),

                             job_defer_to_main_loop_bh, data);

 }

+

+int job_finish_sync(Job *job, void (*finish)(Job *, Error **errp), Error **errp)

+{

+    Error *local_err = NULL;

+    int ret;

+

+    job_ref(job);

+

+    if (finish) {

+        finish(job, &local_err);

+    }

+    if (local_err) {

+        error_propagate(errp, local_err);

+        job_unref(job);

+        return -EBUSY;

+    }

+    /* job_drain calls job_enter, and it should be enough to induce progress

+     * until the job completes or moves to the main thread. */

+    while (!job->deferred_to_main_loop && !job_is_completed(job)) {

+        job_drain(job);

+    }

+    while (!job_is_completed(job)) {

+        aio_poll(qemu_get_aio_context(), true);

+    }

+    ret = (job_is_cancelled(job) && job->ret == 0) ? -ECANCELED : job->ret;

+    job_unref(job);

+    return ret;

+}

-- 

1.8.3.1