|
 |
4a2fec |
From d13b20d0650519722da79a9cb9e4e0a1f2bee26c Mon Sep 17 00:00:00 2001
|
|
|
4a2fec |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
4a2fec |
Date: Mon, 4 Dec 2017 12:10:07 +0100
|
|
|
4a2fec |
Subject: [PATCH 36/36] iotests: Fix 195 if IMGFMT is part of TEST_DIR
|
|
|
4a2fec |
|
|
|
4a2fec |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
4a2fec |
Message-id: <20171204121007.12964-9-kwolf@redhat.com>
|
|
|
4a2fec |
Patchwork-id: 78108
|
|
|
4a2fec |
O-Subject: [RHV-7.5 qemu-kvm-rhev PATCH v2 8/8] iotests: Fix 195 if IMGFMT is part of TEST_DIR
|
|
|
4a2fec |
Bugzilla: 1492178
|
|
|
4a2fec |
RH-Acked-by: Fam Zheng <famz@redhat.com>
|
|
|
4a2fec |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
4a2fec |
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
|
|
|
4a2fec |
|
|
|
4a2fec |
From: Max Reitz <mreitz@redhat.com>
|
|
|
4a2fec |
|
|
|
4a2fec |
do_run_qemu() in iotest 195 first applies _filter_imgfmt when printing
|
|
|
4a2fec |
qemu's command line and _filter_testdir only afterwards. Therefore, if
|
|
|
4a2fec |
the image format is part of the test directory path, _filter_testdir
|
|
|
4a2fec |
will no longer apply and the actual output will differ from the
|
|
|
4a2fec |
reference output even in case of success.
|
|
|
4a2fec |
|
|
|
4a2fec |
For example, TEST_DIR might be "/tmp/test-qcow2", in which case
|
|
|
4a2fec |
_filter_imgfmt first transforms this to "/tmp/test-IMGFMT" which is no
|
|
|
4a2fec |
longer recognized as the TEST_DIR by _filter_testdir.
|
|
|
4a2fec |
|
|
|
4a2fec |
Fix this by not applying _filter_imgfmt in do_run_qemu() but in
|
|
|
4a2fec |
run_qemu() instead, and only after _filter_testdir.
|
|
|
4a2fec |
|
|
|
4a2fec |
Signed-off-by: Max Reitz <mreitz@redhat.com>
|
|
|
4a2fec |
Message-id: 20170927211334.3988-1-mreitz@redhat.com
|
|
|
4a2fec |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
4a2fec |
Signed-off-by: Max Reitz <mreitz@redhat.com>
|
|
|
4a2fec |
(cherry picked from commit 47500c6775813c8f2b5a5de04d84222f3cecc62d)
|
|
|
4a2fec |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
4a2fec |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
4a2fec |
---
|
|
|
4a2fec |
tests/qemu-iotests/195 | 7 ++++---
|
|
|
4a2fec |
1 file changed, 4 insertions(+), 3 deletions(-)
|
|
|
4a2fec |
|
|
|
4a2fec |
diff --git a/tests/qemu-iotests/195 b/tests/qemu-iotests/195
|
|
|
4a2fec |
index 05a239c..e7a403d 100644
|
|
|
4a2fec |
--- a/tests/qemu-iotests/195
|
|
|
4a2fec |
+++ b/tests/qemu-iotests/195
|
|
|
4a2fec |
@@ -44,15 +44,16 @@ _supported_os Linux
|
|
|
4a2fec |
|
|
|
4a2fec |
function do_run_qemu()
|
|
|
4a2fec |
{
|
|
|
4a2fec |
- echo Testing: "$@" | _filter_imgfmt
|
|
|
4a2fec |
+ echo Testing: "$@"
|
|
|
4a2fec |
$QEMU -nographic -qmp-pretty stdio -serial none "$@"
|
|
|
4a2fec |
echo
|
|
|
4a2fec |
}
|
|
|
4a2fec |
|
|
|
4a2fec |
function run_qemu()
|
|
|
4a2fec |
{
|
|
|
4a2fec |
- do_run_qemu "$@" 2>&1 | _filter_testdir | _filter_qemu | _filter_qmp \
|
|
|
4a2fec |
- | _filter_qemu_io | _filter_generated_node_ids
|
|
|
4a2fec |
+ do_run_qemu "$@" 2>&1 | _filter_testdir | _filter_imgfmt | _filter_qemu \
|
|
|
4a2fec |
+ | _filter_qmp | _filter_qemu_io \
|
|
|
4a2fec |
+ | _filter_generated_node_ids
|
|
|
4a2fec |
}
|
|
|
4a2fec |
|
|
|
4a2fec |
size=64M
|
|
|
4a2fec |
--
|
|
|
4a2fec |
1.8.3.1
|
|
|
4a2fec |
|