From 6acc674a6d77b4d1b36545c7f00251b264f99d78 Mon Sep 17 00:00:00 2001

From: Max Reitz <mreitz@redhat.com>

Date: Mon, 18 Jun 2018 16:12:11 +0200

Subject: [PATCH 35/54] iotests: Copy 197 for COR filter driver

RH-Author: Max Reitz <mreitz@redhat.com>

Message-id: <20180618161212.14444-10-mreitz@redhat.com>

Patchwork-id: 80769

O-Subject: [RHV-7.6 qemu-kvm-rhev PATCH 09/10] iotests: Copy 197 for COR filter driver

Bugzilla: 1518738

RH-Acked-by: John Snow <jsnow@redhat.com>

RH-Acked-by: Kevin Wolf <kwolf@redhat.com>

RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>

iotest 197 tests copy-on-read using the (now old) copy-on-read flag.

Copy it to 215 and modify it to use the COR filter driver instead.

Signed-off-by: Max Reitz <mreitz@redhat.com>

Message-id: 20180421132929.21610-9-mreitz@redhat.com

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

Signed-off-by: Max Reitz <mreitz@redhat.com>

(cherry picked from commit a62cbac4ce2db79c14ff299e98ee556b57467c19)

Signed-off-by: Max Reitz <mreitz@redhat.com>

Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>

---

 tests/qemu-iotests/215     | 120 +++++++++++++++++++++++++++++++++++++++++++++

 tests/qemu-iotests/215.out |  26 ++++++++++

 tests/qemu-iotests/group   |   1 +

 3 files changed, 147 insertions(+)

 create mode 100755 tests/qemu-iotests/215

 create mode 100644 tests/qemu-iotests/215.out

diff --git a/tests/qemu-iotests/215 b/tests/qemu-iotests/215

new file mode 100755

index 0000000..2e616ed

--- /dev/null

+++ b/tests/qemu-iotests/215

@@ -0,0 +1,120 @@

+#!/bin/bash

+#

+# Test case for copy-on-read into qcow2, using the COR filter driver

+#

+# Copyright (C) 2018 Red Hat, Inc.

+#

+# This program is free software; you can redistribute it and/or modify

+# it under the terms of the GNU General Public License as published by

+# the Free Software Foundation; either version 2 of the License, or

+# (at your option) any later version.

+#

+# This program is distributed in the hope that it will be useful,

+# but WITHOUT ANY WARRANTY; without even the implied warranty of

+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

+# GNU General Public License for more details.

+#

+# You should have received a copy of the GNU General Public License

+# along with this program.  If not, see <http://www.gnu.org/licenses/>.

+#

+

+seq="$(basename $0)"

+echo "QA output created by $seq"

+

+here="$PWD"

+status=1 # failure is the default!

+

+# get standard environment, filters and checks

+. ./common.rc

+. ./common.filter

+

+TEST_WRAP="$TEST_DIR/t.wrap.qcow2"

+BLKDBG_CONF="$TEST_DIR/blkdebug.conf"

+

+# Sanity check: our use of blkdebug fails if $TEST_DIR contains spaces

+# or other problems

+case "$TEST_DIR" in

+    *[^-_a-zA-Z0-9/]*)

+        _notrun "Suspicious TEST_DIR='$TEST_DIR', cowardly refusing to run" ;;

+esac

+

+_cleanup()

+{

+    _cleanup_test_img

+    rm -f "$TEST_WRAP"

+    rm -f "$BLKDBG_CONF"

+}

+trap "_cleanup; exit \$status" 0 1 2 3 15

+

+# Test is supported for any backing file; but we force qcow2 for our wrapper.

+_supported_fmt generic

+_supported_proto generic

+_supported_os Linux

+# LUKS support may be possible, but it complicates things.

+_unsupported_fmt luks

+

+echo

+echo '=== Copy-on-read ==='

+echo

+

+# Prep the images

+# VPC rounds image sizes to a specific geometry, force a specific size.

+if [ "$IMGFMT" = "vpc" ]; then

+    IMGOPTS=$(_optstr_add "$IMGOPTS" "force_size")

+fi

+_make_test_img 4G

+$QEMU_IO -c "write -P 55 3G 1k" "$TEST_IMG" | _filter_qemu_io

+IMGPROTO=file IMGFMT=qcow2 IMGOPTS= TEST_IMG_FILE="$TEST_WRAP" \

+    _make_test_img -F "$IMGFMT" -b "$TEST_IMG" | _filter_img_create

+$QEMU_IO -f qcow2 -c "write -z -u 1M 64k" "$TEST_WRAP" | _filter_qemu_io

+

+# Ensure that a read of two clusters, but where one is already allocated,

+# does not re-write the allocated cluster

+cat > "$BLKDBG_CONF" <

+[inject-error]

+event = "cor_write"

+sector = "2048"

+EOF

+$QEMU_IO -c "open \

+ -o driver=copy-on-read,file.driver=blkdebug,file.config=$BLKDBG_CONF,file.image.driver=qcow2 $TEST_WRAP" \

+ -c "read -P 0 1M 128k" | _filter_qemu_io

+

+# Read the areas we want copied. A zero-length read should still be a

+# no-op.  The next read is under 2G, but aligned so that rounding to

+# clusters copies more than 2G of zeroes. The final read will pick up

+# the non-zero data in the same cluster.  Since a 2G read may exhaust

+# memory on some machines (particularly 32-bit), we skip the test if

+# that fails due to memory pressure.

+$QEMU_IO \

+    -c "open -o driver=copy-on-read,file.driver=qcow2 $TEST_WRAP" \

+    -c "read 0 0" \

+    | _filter_qemu_io

+output=$($QEMU_IO \

+         -c "open -o driver=copy-on-read,file.driver=qcow2 $TEST_WRAP" \

+         -c "read -P 0 1k $((2*1024*1024*1024 - 512))" \

+         2>&1 | _filter_qemu_io)

+case $output in

+    *allocate*)

+        _notrun "Insufficent memory to run test" ;;

+    *) printf '%s\n' "$output" ;;

+esac

+$QEMU_IO \

+    -c "open -o driver=copy-on-read,file.driver=qcow2 $TEST_WRAP" \

+    -c "read -P 0 $((3*1024*1024*1024 + 1024)) 1k" \

+    | _filter_qemu_io

+

+# Copy-on-read is incompatible with read-only

+$QEMU_IO \

+    -c "open -r -o driver=copy-on-read,file.driver=qcow2 $TEST_WRAP" \

+    2>&1 | _filter_testdir

+

+# Break the backing chain, and show that images are identical, and that

+# we properly copied over explicit zeros.

+$QEMU_IMG rebase -u -b "" -f qcow2 "$TEST_WRAP"

+$QEMU_IO -f qcow2 -c map "$TEST_WRAP"

+_check_test_img

+$QEMU_IMG compare -f $IMGFMT -F qcow2 "$TEST_IMG" "$TEST_WRAP"

+

+# success, all done

+echo '*** done'

+status=0

diff --git a/tests/qemu-iotests/215.out b/tests/qemu-iotests/215.out

new file mode 100644

index 0000000..70b0f5f

--- /dev/null

+++ b/tests/qemu-iotests/215.out

@@ -0,0 +1,26 @@

+QA output created by 215

+

+=== Copy-on-read ===

+

+Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=4294967296

+wrote 1024/1024 bytes at offset 3221225472

+1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

+Formatting 'TEST_DIR/t.wrap.IMGFMT', fmt=IMGFMT size=4294967296 backing_file=TEST_DIR/t.IMGFMT backing_fmt=IMGFMT

+wrote 65536/65536 bytes at offset 1048576

+64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

+read 131072/131072 bytes at offset 1048576

+128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

+read 0/0 bytes at offset 0

+0 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

+read 2147483136/2147483136 bytes at offset 1024

+2 GiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

+read 1024/1024 bytes at offset 3221226496

+1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

+can't open device TEST_DIR/t.wrap.qcow2: Block node is read-only

+2 GiB (0x80010000) bytes     allocated at offset 0 bytes (0x0)

+1023.938 MiB (0x3fff0000) bytes not allocated at offset 2 GiB (0x80010000)

+64 KiB (0x10000) bytes     allocated at offset 3 GiB (0xc0000000)

+1023.938 MiB (0x3fff0000) bytes not allocated at offset 3 GiB (0xc0010000)

+No errors were found on the image.

+Images are identical.

+*** done

diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group

index ba7a2d1..cd5d26c 100644

--- a/tests/qemu-iotests/group

+++ b/tests/qemu-iotests/group

@@ -213,4 +213,5 @@

 212 rw auto quick

 213 rw auto quick

 214 rw auto

+215 rw auto quick

 218 rw auto quick

-- 

1.8.3.1