|
 |
1bdc94 |
From d357e5f3a56416c6f5a7a9308b8c30f825d89cfa Mon Sep 17 00:00:00 2001
|
|
|
1bdc94 |
From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>
|
|
|
1bdc94 |
Date: Fri, 20 Jul 2018 12:18:00 +0200
|
|
|
1bdc94 |
Subject: [PATCH 88/89] hw/char/serial: retry write if EAGAIN
|
|
|
1bdc94 |
MIME-Version: 1.0
|
|
|
1bdc94 |
Content-Type: text/plain; charset=UTF-8
|
|
|
1bdc94 |
Content-Transfer-Encoding: 8bit
|
|
|
1bdc94 |
|
|
|
1bdc94 |
RH-Author: Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
|
1bdc94 |
Message-id: <20180720121800.18952-3-marcandre.lureau@redhat.com>
|
|
|
1bdc94 |
Patchwork-id: 81455
|
|
|
1bdc94 |
O-Subject: [RHEL-7.6 qemu-kvm-rhev PATCH v2 2/2] hw/char/serial: retry write if EAGAIN
|
|
|
1bdc94 |
Bugzilla: 1592817
|
|
|
1bdc94 |
RH-Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: Markus Armbruster <armbru@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: John Snow <jsnow@redhat.com>
|
|
|
1bdc94 |
|
|
|
1bdc94 |
If the chardev returns -1 with EAGAIN errno on write(), it should try
|
|
|
1bdc94 |
to send it again (EINTR is handled by the chardev itself).
|
|
|
1bdc94 |
|
|
|
1bdc94 |
This fixes commit 019288bf137183bf3407c9824655b753bfafc99f
|
|
|
1bdc94 |
"hw/char/serial: Only retry if qemu_chr_fe_write returns 0"
|
|
|
1bdc94 |
|
|
|
1bdc94 |
Tested-by: Igor Mammedov <imammedo@redhat.com>
|
|
|
1bdc94 |
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
|
1bdc94 |
Message-Id: <20180716110755.12499-1-marcandre.lureau@redhat.com>
|
|
|
1bdc94 |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
1bdc94 |
|
|
|
1bdc94 |
(cherry picked from commit f3575af130c700cea060b51a89008a76dae22259)
|
|
|
1bdc94 |
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
|
1bdc94 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
1bdc94 |
---
|
|
|
1bdc94 |
hw/char/serial.c | 23 ++++++++++++++---------
|
|
|
1bdc94 |
1 file changed, 14 insertions(+), 9 deletions(-)
|
|
|
1bdc94 |
|
|
|
1bdc94 |
diff --git a/hw/char/serial.c b/hw/char/serial.c
|
|
|
1bdc94 |
index d4057bf..478f9a8 100644
|
|
|
1bdc94 |
--- a/hw/char/serial.c
|
|
|
1bdc94 |
+++ b/hw/char/serial.c
|
|
|
1bdc94 |
@@ -262,15 +262,20 @@ static void serial_xmit(SerialState *s)
|
|
|
1bdc94 |
if (s->mcr & UART_MCR_LOOP) {
|
|
|
1bdc94 |
/* in loopback mode, say that we just received a char */
|
|
|
1bdc94 |
serial_receive1(s, &s->tsr, 1);
|
|
|
1bdc94 |
- } else if (qemu_chr_fe_write(&s->chr, &s->tsr, 1) == 0 &&
|
|
|
1bdc94 |
- s->tsr_retry < MAX_XMIT_RETRY) {
|
|
|
1bdc94 |
- assert(s->watch_tag == 0);
|
|
|
1bdc94 |
- s->watch_tag =
|
|
|
1bdc94 |
- qemu_chr_fe_add_watch(&s->chr, G_IO_OUT | G_IO_HUP,
|
|
|
1bdc94 |
- serial_watch_cb, s);
|
|
|
1bdc94 |
- if (s->watch_tag > 0) {
|
|
|
1bdc94 |
- s->tsr_retry++;
|
|
|
1bdc94 |
- return;
|
|
|
1bdc94 |
+ } else {
|
|
|
1bdc94 |
+ int rc = qemu_chr_fe_write(&s->chr, &s->tsr, 1);
|
|
|
1bdc94 |
+
|
|
|
1bdc94 |
+ if ((rc == 0 ||
|
|
|
1bdc94 |
+ (rc == -1 && errno == EAGAIN)) &&
|
|
|
1bdc94 |
+ s->tsr_retry < MAX_XMIT_RETRY) {
|
|
|
1bdc94 |
+ assert(s->watch_tag == 0);
|
|
|
1bdc94 |
+ s->watch_tag =
|
|
|
1bdc94 |
+ qemu_chr_fe_add_watch(&s->chr, G_IO_OUT | G_IO_HUP,
|
|
|
1bdc94 |
+ serial_watch_cb, s);
|
|
|
1bdc94 |
+ if (s->watch_tag > 0) {
|
|
|
1bdc94 |
+ s->tsr_retry++;
|
|
|
1bdc94 |
+ return;
|
|
|
1bdc94 |
+ }
|
|
|
1bdc94 |
}
|
|
|
1bdc94 |
}
|
|
|
1bdc94 |
s->tsr_retry = 0;
|
|
|
1bdc94 |
--
|
|
|
1bdc94 |
1.8.3.1
|
|
|
1bdc94 |
|