|
 |
7711c0 |
From 0b5f477725d2652d671b42238ea58dbbdd4763a9 Mon Sep 17 00:00:00 2001
|
|
|
7711c0 |
From: John Snow <jsnow@redhat.com>
|
|
|
7711c0 |
Date: Wed, 3 Apr 2019 22:42:49 +0200
|
|
|
7711c0 |
Subject: [PATCH 154/163] docs/interop/qcow2: Improve bitmap flag in_use
|
|
|
7711c0 |
specification
|
|
|
7711c0 |
|
|
|
7711c0 |
RH-Author: John Snow <jsnow@redhat.com>
|
|
|
7711c0 |
Message-id: <20190403224253.5251-2-jsnow@redhat.com>
|
|
|
7711c0 |
Patchwork-id: 85437
|
|
|
7711c0 |
O-Subject: [RHEL-7.7 qemu-kvm-rhev PATCH 1/5] docs/interop/qcow2: Improve bitmap flag in_use specification
|
|
|
7711c0 |
Bugzilla: 1666884
|
|
|
7711c0 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
7711c0 |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
7711c0 |
RH-Acked-by: Sergio Lopez Pascual <slp@redhat.com>
|
|
|
7711c0 |
|
|
|
7711c0 |
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
|
|
7711c0 |
|
|
|
7711c0 |
We already use (we didn't notice it) IN_USE flag for marking bitmap
|
|
|
7711c0 |
metadata outdated, such as AUTO flag, which mirrors enabled/disabled
|
|
|
7711c0 |
bitmaps. Now we are going to support bitmap resize, so it's good to
|
|
|
7711c0 |
write IN_USE meaning with more details.
|
|
|
7711c0 |
|
|
|
7711c0 |
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
|
|
7711c0 |
Message-id: 20190311185147.52309-2-vsementsov@virtuozzo.com
|
|
|
7711c0 |
Signed-off-by: John Snow <jsnow@redhat.com>
|
|
|
7711c0 |
(cherry picked from commit 2fd490c614500fc669386eaf8710cd2d015f548e)
|
|
|
7711c0 |
Signed-off-by: John Snow <jsnow@redhat.com>
|
|
|
7711c0 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
7711c0 |
---
|
|
|
7711c0 |
docs/interop/qcow2.txt | 9 ++++++---
|
|
|
7711c0 |
1 file changed, 6 insertions(+), 3 deletions(-)
|
|
|
7711c0 |
|
|
|
7711c0 |
diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt
|
|
|
7711c0 |
index feb711f..cba1787 100644
|
|
|
7711c0 |
--- a/docs/interop/qcow2.txt
|
|
|
7711c0 |
+++ b/docs/interop/qcow2.txt
|
|
|
7711c0 |
@@ -555,7 +555,10 @@ Structure of a bitmap directory entry:
|
|
|
7711c0 |
Bit
|
|
|
7711c0 |
0: in_use
|
|
|
7711c0 |
The bitmap was not saved correctly and may be
|
|
|
7711c0 |
- inconsistent.
|
|
|
7711c0 |
+ inconsistent. Although the bitmap metadata is still
|
|
|
7711c0 |
+ well-formed from a qcow2 perspective, the metadata
|
|
|
7711c0 |
+ (such as the auto flag or bitmap size) or data
|
|
|
7711c0 |
+ contents may be outdated.
|
|
|
7711c0 |
|
|
|
7711c0 |
1: auto
|
|
|
7711c0 |
The bitmap must reflect all changes of the virtual
|
|
|
7711c0 |
@@ -683,8 +686,8 @@ corresponding range of the virtual disk (see above) was written to while the
|
|
|
7711c0 |
bitmap was 'enabled'. An unset bit means that this range was not written to.
|
|
|
7711c0 |
|
|
|
7711c0 |
The software doesn't have to sync the bitmap in the image file with its
|
|
|
7711c0 |
-representation in RAM after each write. Flag 'in_use' should be set while the
|
|
|
7711c0 |
-bitmap is not synced.
|
|
|
7711c0 |
+representation in RAM after each write or metadata change. Flag 'in_use'
|
|
|
7711c0 |
+should be set while the bitmap is not synced.
|
|
|
7711c0 |
|
|
|
7711c0 |
In the image file the 'enabled' state is reflected by the 'auto' flag. If this
|
|
|
7711c0 |
flag is set, the software must consider the bitmap as 'enabled' and start
|
|
|
7711c0 |
--
|
|
|
7711c0 |
1.8.3.1
|
|
|
7711c0 |
|