Blame SOURCES/kvm-docs-interop-firmware.json-Prefer-machine-to-if-pfla.patch

7711c0
From 11a0638c7c56d8653e99b8eab194d1adc70a35f3 Mon Sep 17 00:00:00 2001
7711c0
From: Markus Armbruster <armbru@redhat.com>
7711c0
Date: Fri, 17 May 2019 06:51:18 +0200
7711c0
Subject: [PATCH 51/53] docs/interop/firmware.json: Prefer -machine to
7711c0
 if=pflash
7711c0
MIME-Version: 1.0
7711c0
Content-Type: text/plain; charset=UTF-8
7711c0
Content-Transfer-Encoding: 8bit
7711c0
7711c0
RH-Author: Markus Armbruster <armbru@redhat.com>
7711c0
Message-id: <20190517065120.12028-30-armbru@redhat.com>
7711c0
Patchwork-id: 87994
7711c0
O-Subject: [RHEL-7.7 qemu-kvm-rhev PATCH v3 29/31] docs/interop/firmware.json: Prefer -machine to if=pflash
7711c0
Bugzilla: 1624009
7711c0
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
7711c0
RH-Acked-by: Thomas Huth <thuth@redhat.com>
7711c0
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
7711c0
7711c0
The previous commit added a way to configure firmware with -blockdev
7711c0
rather than -drive if=pflash.  Document it as the preferred way.
7711c0
7711c0
Signed-off-by: Markus Armbruster <armbru@redhat.com>
7711c0
Message-Id: <20190308131445.17502-13-armbru@redhat.com>
7711c0
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
7711c0
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
7711c0
(cherry picked from commit e33763be7cd3769c9ae48e67d775348863fdabdb)
7711c0
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
7711c0
---
7711c0
 docs/interop/firmware.json | 20 ++++++++++++++------
7711c0
 1 file changed, 14 insertions(+), 6 deletions(-)
7711c0
7711c0
diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
7711c0
index 28f9bc1..ff8c2ce 100644
7711c0
--- a/docs/interop/firmware.json
7711c0
+++ b/docs/interop/firmware.json
7711c0
@@ -212,9 +212,13 @@
7711c0
 #
7711c0
 # @executable: Identifies the firmware executable. The firmware
7711c0
 #              executable may be shared by multiple virtual machine
7711c0
-#              definitions. The corresponding QEMU command line option
7711c0
-#              is "-drive
7711c0
-#              if=pflash,unit=0,readonly=on,file=@executable.@filename,format=@executable.@format".
7711c0
+#              definitions. The preferred corresponding QEMU command
7711c0
+#              line options are
7711c0
+#                  -drive if=none,id=pflash0,readonly=on,file=@executable.@filename,format=@executable.@format
7711c0
+#                  -machine pflash0=pflash0
7711c0
+#              or equivalent -blockdev instead of -drive.
7711c0
+#              With QEMU versions older than 4.0, you have to use
7711c0
+#                  -drive if=pflash,unit=0,readonly=on,file=@executable.@filename,format=@executable.@format
7711c0
 #
7711c0
 # @nvram-template: Identifies the NVRAM template compatible with
7711c0
 #                  @executable. Management software instantiates an
7711c0
@@ -225,9 +229,13 @@
7711c0
 #                  individual copies of it are. An NVRAM file is
7711c0
 #                  typically used for persistently storing the
7711c0
 #                  non-volatile UEFI variables of a virtual machine
7711c0
-#                  definition. The corresponding QEMU command line
7711c0
-#                  option is "-drive
7711c0
-#                  if=pflash,unit=1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,format=@nvram-template.@format".
7711c0
+#                  definition. The preferred corresponding QEMU
7711c0
+#                  command line options are
7711c0
+#                      -drive if=none,id=pflash1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,format=@nvram-template.@format
7711c0
+#                      -machine pflash1=pflash1
7711c0
+#                  or equivalent -blockdev instead of -drive.
7711c0
+#                  With QEMU versions older than 4.0, you have to use
7711c0
+#                      -drive if=pflash,unit=1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,format=@nvram-template.@format
7711c0
 #
7711c0
 # Since: 3.0
7711c0
 ##
7711c0
-- 
7711c0
1.8.3.1
7711c0