Blame SOURCES/kvm-docs-interop-firmware.json-Prefer-machine-to-if-pfla.patch

383d26
From 11a0638c7c56d8653e99b8eab194d1adc70a35f3 Mon Sep 17 00:00:00 2001
383d26
From: Markus Armbruster <armbru@redhat.com>
383d26
Date: Fri, 17 May 2019 06:51:18 +0200
383d26
Subject: [PATCH 51/53] docs/interop/firmware.json: Prefer -machine to
383d26
 if=pflash
383d26
MIME-Version: 1.0
383d26
Content-Type: text/plain; charset=UTF-8
383d26
Content-Transfer-Encoding: 8bit
383d26
383d26
RH-Author: Markus Armbruster <armbru@redhat.com>
383d26
Message-id: <20190517065120.12028-30-armbru@redhat.com>
383d26
Patchwork-id: 87994
383d26
O-Subject: [RHEL-7.7 qemu-kvm-rhev PATCH v3 29/31] docs/interop/firmware.json: Prefer -machine to if=pflash
383d26
Bugzilla: 1624009
383d26
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
383d26
RH-Acked-by: Thomas Huth <thuth@redhat.com>
383d26
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
383d26
383d26
The previous commit added a way to configure firmware with -blockdev
383d26
rather than -drive if=pflash.  Document it as the preferred way.
383d26
383d26
Signed-off-by: Markus Armbruster <armbru@redhat.com>
383d26
Message-Id: <20190308131445.17502-13-armbru@redhat.com>
383d26
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
383d26
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
383d26
(cherry picked from commit e33763be7cd3769c9ae48e67d775348863fdabdb)
383d26
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
383d26
---
383d26
 docs/interop/firmware.json | 20 ++++++++++++++------
383d26
 1 file changed, 14 insertions(+), 6 deletions(-)
383d26
383d26
diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
383d26
index 28f9bc1..ff8c2ce 100644
383d26
--- a/docs/interop/firmware.json
383d26
+++ b/docs/interop/firmware.json
383d26
@@ -212,9 +212,13 @@
383d26
 #
383d26
 # @executable: Identifies the firmware executable. The firmware
383d26
 #              executable may be shared by multiple virtual machine
383d26
-#              definitions. The corresponding QEMU command line option
383d26
-#              is "-drive
383d26
-#              if=pflash,unit=0,readonly=on,file=@executable.@filename,format=@executable.@format".
383d26
+#              definitions. The preferred corresponding QEMU command
383d26
+#              line options are
383d26
+#                  -drive if=none,id=pflash0,readonly=on,file=@executable.@filename,format=@executable.@format
383d26
+#                  -machine pflash0=pflash0
383d26
+#              or equivalent -blockdev instead of -drive.
383d26
+#              With QEMU versions older than 4.0, you have to use
383d26
+#                  -drive if=pflash,unit=0,readonly=on,file=@executable.@filename,format=@executable.@format
383d26
 #
383d26
 # @nvram-template: Identifies the NVRAM template compatible with
383d26
 #                  @executable. Management software instantiates an
383d26
@@ -225,9 +229,13 @@
383d26
 #                  individual copies of it are. An NVRAM file is
383d26
 #                  typically used for persistently storing the
383d26
 #                  non-volatile UEFI variables of a virtual machine
383d26
-#                  definition. The corresponding QEMU command line
383d26
-#                  option is "-drive
383d26
-#                  if=pflash,unit=1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,format=@nvram-template.@format".
383d26
+#                  definition. The preferred corresponding QEMU
383d26
+#                  command line options are
383d26
+#                      -drive if=none,id=pflash1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,format=@nvram-template.@format
383d26
+#                      -machine pflash1=pflash1
383d26
+#                  or equivalent -blockdev instead of -drive.
383d26
+#                  With QEMU versions older than 4.0, you have to use
383d26
+#                      -drive if=pflash,unit=1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,format=@nvram-template.@format
383d26
 #
383d26
 # Since: 3.0
383d26
 ##
383d26
-- 
383d26
1.8.3.1
383d26