Blame SOURCES/kvm-check-block-qdict-Rename-qdict_flatten-s-variables-f.patch

1bdc94
From 34251ed7b01f81a0e62fa56548db657a5c238125 Mon Sep 17 00:00:00 2001
1bdc94
From: Markus Armbruster <armbru@redhat.com>
1bdc94
Date: Mon, 18 Jun 2018 08:43:26 +0200
1bdc94
Subject: [PATCH 19/54] check-block-qdict: Rename qdict_flatten()'s variables
1bdc94
 for clarity
1bdc94
1bdc94
RH-Author: Markus Armbruster <armbru@redhat.com>
1bdc94
Message-id: <20180618084330.30009-20-armbru@redhat.com>
1bdc94
Patchwork-id: 80721
1bdc94
O-Subject: [RHEL-7.6 qemu-kvm-rhev PATCH 19/23] check-block-qdict: Rename qdict_flatten()'s variables for clarity
1bdc94
Bugzilla: 1557995
1bdc94
RH-Acked-by: Max Reitz <mreitz@redhat.com>
1bdc94
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
1bdc94
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
1bdc94
1bdc94
Signed-off-by: Markus Armbruster <armbru@redhat.com>
1bdc94
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
1bdc94
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
1bdc94
(cherry picked from commit cddec036830ada5d5d45023bcfba09015b8ab394)
1bdc94
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
1bdc94
---
1bdc94
 tests/check-block-qdict.c | 57 ++++++++++++++++++++++++-----------------------
1bdc94
 1 file changed, 29 insertions(+), 28 deletions(-)
1bdc94
1bdc94
diff --git a/tests/check-block-qdict.c b/tests/check-block-qdict.c
1bdc94
index 5b9f4d5..29f58a2 100644
1bdc94
--- a/tests/check-block-qdict.c
1bdc94
+++ b/tests/check-block-qdict.c
1bdc94
@@ -37,11 +37,11 @@ static void qdict_defaults_test(void)
1bdc94
 
1bdc94
 static void qdict_flatten_test(void)
1bdc94
 {
1bdc94
-    QList *list1 = qlist_new();
1bdc94
-    QList *list2 = qlist_new();
1bdc94
-    QDict *dict1 = qdict_new();
1bdc94
-    QDict *dict2 = qdict_new();
1bdc94
-    QDict *dict3 = qdict_new();
1bdc94
+    QList *e_1 = qlist_new();
1bdc94
+    QList *e = qlist_new();
1bdc94
+    QDict *e_1_2 = qdict_new();
1bdc94
+    QDict *f = qdict_new();
1bdc94
+    QDict *root = qdict_new();
1bdc94
 
1bdc94
     /*
1bdc94
      * Test the flattening of
1bdc94
@@ -79,35 +79,36 @@ static void qdict_flatten_test(void)
1bdc94
      * }
1bdc94
      */
1bdc94
 
1bdc94
-    qdict_put_int(dict1, "a", 0);
1bdc94
-    qdict_put_int(dict1, "b", 1);
1bdc94
+    qdict_put_int(e_1_2, "a", 0);
1bdc94
+    qdict_put_int(e_1_2, "b", 1);
1bdc94
 
1bdc94
-    qlist_append_int(list1, 23);
1bdc94
-    qlist_append_int(list1, 66);
1bdc94
-    qlist_append(list1, dict1);
1bdc94
-    qlist_append_int(list2, 42);
1bdc94
-    qlist_append(list2, list1);
1bdc94
+    qlist_append_int(e_1, 23);
1bdc94
+    qlist_append_int(e_1, 66);
1bdc94
+    qlist_append(e_1, e_1_2);
1bdc94
+    qlist_append_int(e, 42);
1bdc94
+    qlist_append(e, e_1);
1bdc94
 
1bdc94
-    qdict_put_int(dict2, "c", 2);
1bdc94
-    qdict_put_int(dict2, "d", 3);
1bdc94
-    qdict_put(dict3, "e", list2);
1bdc94
-    qdict_put(dict3, "f", dict2);
1bdc94
-    qdict_put_int(dict3, "g", 4);
1bdc94
+    qdict_put_int(f, "c", 2);
1bdc94
+    qdict_put_int(f, "d", 3);
1bdc94
 
1bdc94
-    qdict_flatten(dict3);
1bdc94
+    qdict_put(root, "e", e);
1bdc94
+    qdict_put(root, "f", f);
1bdc94
+    qdict_put_int(root, "g", 4);
1bdc94
 
1bdc94
-    g_assert(qdict_get_int(dict3, "e.0") == 42);
1bdc94
-    g_assert(qdict_get_int(dict3, "e.1.0") == 23);
1bdc94
-    g_assert(qdict_get_int(dict3, "e.1.1") == 66);
1bdc94
-    g_assert(qdict_get_int(dict3, "e.1.2.a") == 0);
1bdc94
-    g_assert(qdict_get_int(dict3, "e.1.2.b") == 1);
1bdc94
-    g_assert(qdict_get_int(dict3, "f.c") == 2);
1bdc94
-    g_assert(qdict_get_int(dict3, "f.d") == 3);
1bdc94
-    g_assert(qdict_get_int(dict3, "g") == 4);
1bdc94
+    qdict_flatten(root);
1bdc94
 
1bdc94
-    g_assert(qdict_size(dict3) == 8);
1bdc94
+    g_assert(qdict_get_int(root, "e.0") == 42);
1bdc94
+    g_assert(qdict_get_int(root, "e.1.0") == 23);
1bdc94
+    g_assert(qdict_get_int(root, "e.1.1") == 66);
1bdc94
+    g_assert(qdict_get_int(root, "e.1.2.a") == 0);
1bdc94
+    g_assert(qdict_get_int(root, "e.1.2.b") == 1);
1bdc94
+    g_assert(qdict_get_int(root, "f.c") == 2);
1bdc94
+    g_assert(qdict_get_int(root, "f.d") == 3);
1bdc94
+    g_assert(qdict_get_int(root, "g") == 4);
1bdc94
 
1bdc94
-    qobject_unref(dict3);
1bdc94
+    g_assert(qdict_size(root) == 8);
1bdc94
+
1bdc94
+    qobject_unref(root);
1bdc94
 }
1bdc94
 
1bdc94
 static void qdict_array_split_test(void)
1bdc94
-- 
1bdc94
1.8.3.1
1bdc94