|
 |
1bdc94 |
From 1dca4e49145a339e84b7cdc2a9b226f0a3afe502 Mon Sep 17 00:00:00 2001
|
|
|
1bdc94 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
1bdc94 |
Date: Tue, 26 Jun 2018 09:47:58 +0200
|
|
|
1bdc94 |
Subject: [PATCH 29/89] blockjob: Improve BlockJobInfo.offset/len documentation
|
|
|
1bdc94 |
|
|
|
1bdc94 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
1bdc94 |
Message-id: <20180626094856.6924-16-kwolf@redhat.com>
|
|
|
1bdc94 |
Patchwork-id: 81087
|
|
|
1bdc94 |
O-Subject: [RHV-7.6 qemu-kvm-rhev PATCH v2 15/73] blockjob: Improve BlockJobInfo.offset/len documentation
|
|
|
1bdc94 |
Bugzilla: 1513543
|
|
|
1bdc94 |
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: Fam Zheng <famz@redhat.com>
|
|
|
1bdc94 |
|
|
|
1bdc94 |
Clarify that len is just an estimation of the end value of offset, and
|
|
|
1bdc94 |
that offset increases monotonically while len can change arbitrarily.
|
|
|
1bdc94 |
|
|
|
1bdc94 |
While touching the documentation of offset, move it directly after len
|
|
|
1bdc94 |
to match the order of the declaration below.
|
|
|
1bdc94 |
|
|
|
1bdc94 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
1bdc94 |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
1bdc94 |
Reviewed-by: John Snow <jsnow@redhat.com>
|
|
|
1bdc94 |
(cherry picked from commit a81e0a825e3b89039a427bca037112f461b95fec)
|
|
|
1bdc94 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
1bdc94 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
1bdc94 |
---
|
|
|
1bdc94 |
qapi/block-core.json | 9 ++++++---
|
|
|
1bdc94 |
1 file changed, 6 insertions(+), 3 deletions(-)
|
|
|
1bdc94 |
|
|
|
1bdc94 |
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
|
|
1bdc94 |
index d24c12b..1f6d4bb 100644
|
|
|
1bdc94 |
--- a/qapi/block-core.json
|
|
|
1bdc94 |
+++ b/qapi/block-core.json
|
|
|
1bdc94 |
@@ -1148,7 +1148,12 @@
|
|
|
1bdc94 |
# @device: The job identifier. Originally the device name but other
|
|
|
1bdc94 |
# values are allowed since QEMU 2.7
|
|
|
1bdc94 |
#
|
|
|
1bdc94 |
-# @len: the maximum progress value
|
|
|
1bdc94 |
+# @len: Estimated @offset value at the completion of the job. This value can
|
|
|
1bdc94 |
+# arbitrarily change while the job is running, in both directions.
|
|
|
1bdc94 |
+#
|
|
|
1bdc94 |
+# @offset: Progress made until now. The unit is arbitrary and the value can
|
|
|
1bdc94 |
+# only meaningfully be used for the ratio of @offset to @len. The
|
|
|
1bdc94 |
+# value is monotonically increasing.
|
|
|
1bdc94 |
#
|
|
|
1bdc94 |
# @busy: false if the job is known to be in a quiescent state, with
|
|
|
1bdc94 |
# no pending I/O. Since 1.3.
|
|
|
1bdc94 |
@@ -1156,8 +1161,6 @@
|
|
|
1bdc94 |
# @paused: whether the job is paused or, if @busy is true, will
|
|
|
1bdc94 |
# pause itself as soon as possible. Since 1.3.
|
|
|
1bdc94 |
#
|
|
|
1bdc94 |
-# @offset: the current progress value
|
|
|
1bdc94 |
-#
|
|
|
1bdc94 |
# @speed: the rate limit, bytes per second
|
|
|
1bdc94 |
#
|
|
|
1bdc94 |
# @io-status: the status of the job (since 1.3)
|
|
|
1bdc94 |
--
|
|
|
1bdc94 |
1.8.3.1
|
|
|
1bdc94 |
|