|
 |
4a2fec |
From 6ce7177922a538b653910bde85d4f03fe2a299d7 Mon Sep 17 00:00:00 2001
|
|
|
4a2fec |
From: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
Date: Wed, 3 Jan 2018 11:30:21 +0100
|
|
|
4a2fec |
Subject: [PATCH 8/9] block/throttle-groups.c: allocate RestartData on the heap
|
|
|
4a2fec |
|
|
|
4a2fec |
RH-Author: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
Message-id: <20180103113021.6954-2-stefanha@redhat.com>
|
|
|
4a2fec |
Patchwork-id: 78510
|
|
|
4a2fec |
O-Subject: [RHV7.5 qemu-kvm-rhev PATCH 1/1] block/throttle-groups.c: allocate RestartData on the heap
|
|
|
4a2fec |
Bugzilla: 1525868
|
|
|
4a2fec |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
4a2fec |
RH-Acked-by: Fam Zheng <famz@redhat.com>
|
|
|
4a2fec |
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
|
|
|
4a2fec |
|
|
|
4a2fec |
From: Manos Pitsidianakis <el13635@mail.ntua.gr>
|
|
|
4a2fec |
|
|
|
4a2fec |
RestartData is the opaque data of the throttle_group_restart_queue_entry
|
|
|
4a2fec |
coroutine. By being stack allocated, it isn't available anymore if
|
|
|
4a2fec |
aio_co_enter schedules the coroutine with a bottom half and runs after
|
|
|
4a2fec |
throttle_group_restart_queue returns.
|
|
|
4a2fec |
|
|
|
4a2fec |
Cc: qemu-stable@nongnu.org
|
|
|
4a2fec |
Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
|
|
|
4a2fec |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
4a2fec |
Reviewed-by: Alberto Garcia <berto@igalia.com>
|
|
|
4a2fec |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
4a2fec |
(cherry picked from commit 43a5dc02fd6070827d5c4ff652b885219fa8cbe1)
|
|
|
4a2fec |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
4a2fec |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
4a2fec |
---
|
|
|
4a2fec |
block/throttle-groups.c | 12 +++++++-----
|
|
|
4a2fec |
1 file changed, 7 insertions(+), 5 deletions(-)
|
|
|
4a2fec |
|
|
|
4a2fec |
diff --git a/block/throttle-groups.c b/block/throttle-groups.c
|
|
|
4a2fec |
index 35c22ac..e6ba336 100644
|
|
|
4a2fec |
--- a/block/throttle-groups.c
|
|
|
4a2fec |
+++ b/block/throttle-groups.c
|
|
|
4a2fec |
@@ -387,17 +387,19 @@ static void coroutine_fn throttle_group_restart_queue_entry(void *opaque)
|
|
|
4a2fec |
schedule_next_request(tgm, is_write);
|
|
|
4a2fec |
qemu_mutex_unlock(&tg->lock);
|
|
|
4a2fec |
}
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+ g_free(data);
|
|
|
4a2fec |
}
|
|
|
4a2fec |
|
|
|
4a2fec |
static void throttle_group_restart_queue(ThrottleGroupMember *tgm, bool is_write)
|
|
|
4a2fec |
{
|
|
|
4a2fec |
Coroutine *co;
|
|
|
4a2fec |
- RestartData rd = {
|
|
|
4a2fec |
- .tgm = tgm,
|
|
|
4a2fec |
- .is_write = is_write
|
|
|
4a2fec |
- };
|
|
|
4a2fec |
+ RestartData *rd = g_new0(RestartData, 1);
|
|
|
4a2fec |
+
|
|
|
4a2fec |
+ rd->tgm = tgm;
|
|
|
4a2fec |
+ rd->is_write = is_write;
|
|
|
4a2fec |
|
|
|
4a2fec |
- co = qemu_coroutine_create(throttle_group_restart_queue_entry, &rd);
|
|
|
4a2fec |
+ co = qemu_coroutine_create(throttle_group_restart_queue_entry, rd);
|
|
|
4a2fec |
aio_co_enter(tgm->aio_context, co);
|
|
|
4a2fec |
}
|
|
|
4a2fec |
|
|
|
4a2fec |
--
|
|
|
4a2fec |
1.8.3.1
|
|
|
4a2fec |
|