|
 |
383d26 |
From 95bfd60b406ed4cce708b5981d4bc3a007d0cec9 Mon Sep 17 00:00:00 2001
|
|
|
383d26 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
383d26 |
Date: Tue, 7 Aug 2018 14:03:59 +0200
|
|
|
383d26 |
Subject: [PATCH 06/13] block/qapi: Add 'qdev' field to query-blockstats result
|
|
|
383d26 |
|
|
|
383d26 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
383d26 |
Message-id: <20180807140401.23995-2-kwolf@redhat.com>
|
|
|
383d26 |
Patchwork-id: 81666
|
|
|
383d26 |
O-Subject: [RHV-7.6 qemu-kvm-rhev PATCH 1/3] block/qapi: Add 'qdev' field to query-blockstats result
|
|
|
383d26 |
Bugzilla: 1612114
|
|
|
383d26 |
RH-Acked-by: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
|
|
|
383d26 |
RH-Acked-by: Markus Armbruster <armbru@redhat.com>
|
|
|
383d26 |
|
|
|
383d26 |
Like for query-block, the client needs to identify which BlockBackend
|
|
|
383d26 |
the returned data is for. Anonymous BlockBackends are identified by the
|
|
|
383d26 |
device model they are attached to. Add a 'qdev' field that contains the
|
|
|
383d26 |
qdev ID or QOM path of the attached device model.
|
|
|
383d26 |
|
|
|
383d26 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
383d26 |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
383d26 |
(cherry picked from commit 5a9cb5a97f1e519f249d9ec482d498b78296b51d)
|
|
|
383d26 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
383d26 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
383d26 |
---
|
|
|
383d26 |
block/qapi.c | 10 ++++++++++
|
|
|
383d26 |
qapi/block-core.json | 14 ++++++++++----
|
|
|
383d26 |
2 files changed, 20 insertions(+), 4 deletions(-)
|
|
|
383d26 |
|
|
|
383d26 |
diff --git a/block/qapi.c b/block/qapi.c
|
|
|
383d26 |
index e12968f..50f867d 100644
|
|
|
383d26 |
--- a/block/qapi.c
|
|
|
383d26 |
+++ b/block/qapi.c
|
|
|
383d26 |
@@ -597,11 +597,21 @@ BlockStatsList *qmp_query_blockstats(bool has_query_nodes,
|
|
|
383d26 |
BlockStatsList *info = g_malloc0(sizeof(*info));
|
|
|
383d26 |
AioContext *ctx = blk_get_aio_context(blk);
|
|
|
383d26 |
BlockStats *s;
|
|
|
383d26 |
+ char *qdev;
|
|
|
383d26 |
|
|
|
383d26 |
aio_context_acquire(ctx);
|
|
|
383d26 |
s = bdrv_query_bds_stats(blk_bs(blk), true);
|
|
|
383d26 |
s->has_device = true;
|
|
|
383d26 |
s->device = g_strdup(blk_name(blk));
|
|
|
383d26 |
+
|
|
|
383d26 |
+ qdev = blk_get_attached_dev_id(blk);
|
|
|
383d26 |
+ if (qdev && *qdev) {
|
|
|
383d26 |
+ s->has_qdev = true;
|
|
|
383d26 |
+ s->qdev = qdev;
|
|
|
383d26 |
+ } else {
|
|
|
383d26 |
+ g_free(qdev);
|
|
|
383d26 |
+ }
|
|
|
383d26 |
+
|
|
|
383d26 |
bdrv_query_blk_stats(s->stats, blk);
|
|
|
383d26 |
aio_context_release(ctx);
|
|
|
383d26 |
|
|
|
383d26 |
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
|
|
383d26 |
index 8a00bec..c6b42eb 100644
|
|
|
383d26 |
--- a/qapi/block-core.json
|
|
|
383d26 |
+++ b/qapi/block-core.json
|
|
|
383d26 |
@@ -867,6 +867,9 @@
|
|
|
383d26 |
#
|
|
|
383d26 |
# @node-name: The node name of the device. (Since 2.3)
|
|
|
383d26 |
#
|
|
|
383d26 |
+# @qdev: The qdev ID, or if no ID is assigned, the QOM path of the block
|
|
|
383d26 |
+# device. (since 3.0)
|
|
|
383d26 |
+#
|
|
|
383d26 |
# @stats: A @BlockDeviceStats for the device.
|
|
|
383d26 |
#
|
|
|
383d26 |
# @parent: This describes the file block device if it has one.
|
|
|
383d26 |
@@ -880,7 +883,7 @@
|
|
|
383d26 |
# Since: 0.14.0
|
|
|
383d26 |
##
|
|
|
383d26 |
{ 'struct': 'BlockStats',
|
|
|
383d26 |
- 'data': {'*device': 'str', '*node-name': 'str',
|
|
|
383d26 |
+ 'data': {'*device': 'str', '*qdev': 'str', '*node-name': 'str',
|
|
|
383d26 |
'stats': 'BlockDeviceStats',
|
|
|
383d26 |
'*parent': 'BlockStats',
|
|
|
383d26 |
'*backing': 'BlockStats'} }
|
|
|
383d26 |
@@ -942,7 +945,8 @@
|
|
|
383d26 |
# "idle_time_ns":2953431879,
|
|
|
383d26 |
# "account_invalid":true,
|
|
|
383d26 |
# "account_failed":false
|
|
|
383d26 |
-# }
|
|
|
383d26 |
+# },
|
|
|
383d26 |
+# "qdev": "/machine/unattached/device[23]"
|
|
|
383d26 |
# },
|
|
|
383d26 |
# {
|
|
|
383d26 |
# "device":"ide1-cd0",
|
|
|
383d26 |
@@ -960,7 +964,8 @@
|
|
|
383d26 |
# "wr_merged":0,
|
|
|
383d26 |
# "account_invalid":false,
|
|
|
383d26 |
# "account_failed":false
|
|
|
383d26 |
-# }
|
|
|
383d26 |
+# },
|
|
|
383d26 |
+# "qdev": "/machine/unattached/device[24]"
|
|
|
383d26 |
# },
|
|
|
383d26 |
# {
|
|
|
383d26 |
# "device":"floppy0",
|
|
|
383d26 |
@@ -978,7 +983,8 @@
|
|
|
383d26 |
# "wr_merged":0,
|
|
|
383d26 |
# "account_invalid":false,
|
|
|
383d26 |
# "account_failed":false
|
|
|
383d26 |
-# }
|
|
|
383d26 |
+# },
|
|
|
383d26 |
+# "qdev": "/machine/unattached/device[16]"
|
|
|
383d26 |
# },
|
|
|
383d26 |
# {
|
|
|
383d26 |
# "device":"sd0",
|
|
|
383d26 |
--
|
|
|
383d26 |
1.8.3.1
|
|
|
383d26 |
|