|
 |
383d26 |
From f969846f7376f6e33b3af86c498a51cb29ca0cca Mon Sep 17 00:00:00 2001
|
|
|
383d26 |
From: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
Date: Wed, 3 Apr 2019 18:18:41 +0200
|
|
|
383d26 |
Subject: [PATCH 136/163] block/dirty-bitmap: remove set/reset assertions
|
|
|
383d26 |
against enabled bit
|
|
|
383d26 |
|
|
|
383d26 |
RH-Author: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
Message-id: <20190403181857.9693-6-jsnow@redhat.com>
|
|
|
383d26 |
Patchwork-id: 85426
|
|
|
383d26 |
O-Subject: [RHEL-7.7 qemu-kvm-rhev PATCH 05/21] block/dirty-bitmap: remove set/reset assertions against enabled bit
|
|
|
383d26 |
Bugzilla: 1677073
|
|
|
383d26 |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
383d26 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
383d26 |
RH-Acked-by: Sergio Lopez Pascual <slp@redhat.com>
|
|
|
383d26 |
|
|
|
383d26 |
bdrv_set_dirty_bitmap and bdrv_reset_dirty_bitmap are only used as an
|
|
|
383d26 |
internal API by the mirror and migration areas of our code. These
|
|
|
383d26 |
calls modify the bitmap, but do so at the behest of QEMU and not the
|
|
|
383d26 |
guest.
|
|
|
383d26 |
|
|
|
383d26 |
Presently, these bitmaps are always "enabled" anyway, but there's no
|
|
|
383d26 |
reason they have to be.
|
|
|
383d26 |
|
|
|
383d26 |
Modify these internal APIs to drop this assertion.
|
|
|
383d26 |
|
|
|
383d26 |
Signed-off-by: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
383d26 |
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
|
|
383d26 |
Message-id: 20190223000614.13894-4-jsnow@redhat.com
|
|
|
383d26 |
Signed-off-by: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
(cherry picked from commit c28ddbb07ef39d79a81941d97faa1a1bb1ce2249)
|
|
|
383d26 |
Signed-off-by: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
383d26 |
---
|
|
|
383d26 |
block/dirty-bitmap.c | 2 --
|
|
|
383d26 |
1 file changed, 2 deletions(-)
|
|
|
383d26 |
|
|
|
383d26 |
diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
|
|
|
383d26 |
index f8984b8..7dc5b55 100644
|
|
|
383d26 |
--- a/block/dirty-bitmap.c
|
|
|
383d26 |
+++ b/block/dirty-bitmap.c
|
|
|
383d26 |
@@ -544,7 +544,6 @@ int64_t bdrv_dirty_iter_next(BdrvDirtyBitmapIter *iter)
|
|
|
383d26 |
void bdrv_set_dirty_bitmap_locked(BdrvDirtyBitmap *bitmap,
|
|
|
383d26 |
int64_t offset, int64_t bytes)
|
|
|
383d26 |
{
|
|
|
383d26 |
- assert(bdrv_dirty_bitmap_enabled(bitmap));
|
|
|
383d26 |
assert(!bdrv_dirty_bitmap_readonly(bitmap));
|
|
|
383d26 |
hbitmap_set(bitmap->bitmap, offset, bytes);
|
|
|
383d26 |
}
|
|
|
383d26 |
@@ -561,7 +560,6 @@ void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap,
|
|
|
383d26 |
void bdrv_reset_dirty_bitmap_locked(BdrvDirtyBitmap *bitmap,
|
|
|
383d26 |
int64_t offset, int64_t bytes)
|
|
|
383d26 |
{
|
|
|
383d26 |
- assert(bdrv_dirty_bitmap_enabled(bitmap));
|
|
|
383d26 |
assert(!bdrv_dirty_bitmap_readonly(bitmap));
|
|
|
383d26 |
hbitmap_reset(bitmap->bitmap, offset, bytes);
|
|
|
383d26 |
}
|
|
|
383d26 |
--
|
|
|
383d26 |
1.8.3.1
|
|
|
383d26 |
|