|
 |
383d26 |
From 68265b080cec07c5a6ba6b1c6fbd867f4d9cf9ba Mon Sep 17 00:00:00 2001
|
|
|
383d26 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
383d26 |
Date: Fri, 14 Sep 2018 10:55:34 +0200
|
|
|
383d26 |
Subject: [PATCH 43/49] block-backend: Decrease in_flight only after callback
|
|
|
383d26 |
|
|
|
383d26 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
383d26 |
Message-id: <20180914105540.18077-37-kwolf@redhat.com>
|
|
|
383d26 |
Patchwork-id: 82187
|
|
|
383d26 |
O-Subject: [RHV-7.6 qemu-kvm-rhev PATCH 36/42] block-backend: Decrease in_flight only after callback
|
|
|
383d26 |
Bugzilla: 1601212
|
|
|
383d26 |
RH-Acked-by: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
383d26 |
RH-Acked-by: Fam Zheng <famz@redhat.com>
|
|
|
383d26 |
|
|
|
383d26 |
Request callbacks can do pretty much anything, including operations that
|
|
|
383d26 |
will yield from the coroutine (such as draining the backend). In that
|
|
|
383d26 |
case, a decreased in_flight would be visible to other code and could
|
|
|
383d26 |
lead to a drain completing while the callback hasn't actually completed
|
|
|
383d26 |
yet.
|
|
|
383d26 |
|
|
|
383d26 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
383d26 |
Reviewed-by: Fam Zheng <famz@redhat.com>
|
|
|
383d26 |
Reviewed-by: Max Reitz <mreitz@redhat.com>
|
|
|
383d26 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
383d26 |
---
|
|
|
383d26 |
block/block-backend.c | 10 +++++++++-
|
|
|
383d26 |
1 file changed, 9 insertions(+), 1 deletion(-)
|
|
|
383d26 |
|
|
|
383d26 |
diff --git a/block/block-backend.c b/block/block-backend.c
|
|
|
383d26 |
index 1adf76b..466bc27 100644
|
|
|
383d26 |
--- a/block/block-backend.c
|
|
|
383d26 |
+++ b/block/block-backend.c
|
|
|
383d26 |
@@ -1341,8 +1341,16 @@ static const AIOCBInfo blk_aio_em_aiocb_info = {
|
|
|
383d26 |
static void blk_aio_complete(BlkAioEmAIOCB *acb)
|
|
|
383d26 |
{
|
|
|
383d26 |
if (acb->has_returned) {
|
|
|
383d26 |
- blk_dec_in_flight(acb->rwco.blk);
|
|
|
383d26 |
+ if (qemu_get_current_aio_context() == qemu_get_aio_context()) {
|
|
|
383d26 |
+ /* If we are in the main thread, the callback is allowed to unref
|
|
|
383d26 |
+ * the BlockBackend, so we have to hold an additional reference */
|
|
|
383d26 |
+ blk_ref(acb->rwco.blk);
|
|
|
383d26 |
+ }
|
|
|
383d26 |
acb->common.cb(acb->common.opaque, acb->rwco.ret);
|
|
|
383d26 |
+ blk_dec_in_flight(acb->rwco.blk);
|
|
|
383d26 |
+ if (qemu_get_current_aio_context() == qemu_get_aio_context()) {
|
|
|
383d26 |
+ blk_unref(acb->rwco.blk);
|
|
|
383d26 |
+ }
|
|
|
383d26 |
qemu_aio_unref(acb);
|
|
|
383d26 |
}
|
|
|
383d26 |
}
|
|
|
383d26 |
--
|
|
|
383d26 |
1.8.3.1
|
|
|
383d26 |
|