|
 |
383d26 |
From 13f0c32e5c77278207f63ade463035d8aaa4898d Mon Sep 17 00:00:00 2001
|
|
|
383d26 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
383d26 |
Date: Fri, 14 Sep 2018 10:55:15 +0200
|
|
|
383d26 |
Subject: [PATCH 24/49] block: Move bdrv_drain_all_begin() out of coroutine
|
|
|
383d26 |
context
|
|
|
383d26 |
|
|
|
383d26 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
383d26 |
Message-id: <20180914105540.18077-18-kwolf@redhat.com>
|
|
|
383d26 |
Patchwork-id: 82169
|
|
|
383d26 |
O-Subject: [RHV-7.6 qemu-kvm-rhev PATCH 17/42] block: Move bdrv_drain_all_begin() out of coroutine context
|
|
|
383d26 |
Bugzilla: 1601212
|
|
|
383d26 |
RH-Acked-by: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
383d26 |
RH-Acked-by: Fam Zheng <famz@redhat.com>
|
|
|
383d26 |
|
|
|
383d26 |
Before we can introduce a single polling loop for all nodes in
|
|
|
383d26 |
bdrv_drain_all_begin(), we must make sure to run it outside of coroutine
|
|
|
383d26 |
context like we already do for bdrv_do_drained_begin().
|
|
|
383d26 |
|
|
|
383d26 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
383d26 |
(cherry picked from commit c8ca33d06def97d909a8511377b82994ae4e5981)
|
|
|
383d26 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
383d26 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
383d26 |
---
|
|
|
383d26 |
block/io.c | 22 +++++++++++++++++-----
|
|
|
383d26 |
1 file changed, 17 insertions(+), 5 deletions(-)
|
|
|
383d26 |
|
|
|
383d26 |
diff --git a/block/io.c b/block/io.c
|
|
|
383d26 |
index 23fe069..b58c91b 100644
|
|
|
383d26 |
--- a/block/io.c
|
|
|
383d26 |
+++ b/block/io.c
|
|
|
383d26 |
@@ -263,11 +263,16 @@ static void bdrv_co_drain_bh_cb(void *opaque)
|
|
|
383d26 |
Coroutine *co = data->co;
|
|
|
383d26 |
BlockDriverState *bs = data->bs;
|
|
|
383d26 |
|
|
|
383d26 |
- bdrv_dec_in_flight(bs);
|
|
|
383d26 |
- if (data->begin) {
|
|
|
383d26 |
- bdrv_do_drained_begin(bs, data->recursive, data->parent, data->poll);
|
|
|
383d26 |
+ if (bs) {
|
|
|
383d26 |
+ bdrv_dec_in_flight(bs);
|
|
|
383d26 |
+ if (data->begin) {
|
|
|
383d26 |
+ bdrv_do_drained_begin(bs, data->recursive, data->parent, data->poll);
|
|
|
383d26 |
+ } else {
|
|
|
383d26 |
+ bdrv_do_drained_end(bs, data->recursive, data->parent);
|
|
|
383d26 |
+ }
|
|
|
383d26 |
} else {
|
|
|
383d26 |
- bdrv_do_drained_end(bs, data->recursive, data->parent);
|
|
|
383d26 |
+ assert(data->begin);
|
|
|
383d26 |
+ bdrv_drain_all_begin();
|
|
|
383d26 |
}
|
|
|
383d26 |
|
|
|
383d26 |
data->done = true;
|
|
|
383d26 |
@@ -293,7 +298,9 @@ static void coroutine_fn bdrv_co_yield_to_drain(BlockDriverState *bs,
|
|
|
383d26 |
.parent = parent,
|
|
|
383d26 |
.poll = poll,
|
|
|
383d26 |
};
|
|
|
383d26 |
- bdrv_inc_in_flight(bs);
|
|
|
383d26 |
+ if (bs) {
|
|
|
383d26 |
+ bdrv_inc_in_flight(bs);
|
|
|
383d26 |
+ }
|
|
|
383d26 |
aio_bh_schedule_oneshot(bdrv_get_aio_context(bs),
|
|
|
383d26 |
bdrv_co_drain_bh_cb, &data);
|
|
|
383d26 |
|
|
|
383d26 |
@@ -463,6 +470,11 @@ void bdrv_drain_all_begin(void)
|
|
|
383d26 |
BlockDriverState *bs;
|
|
|
383d26 |
BdrvNextIterator it;
|
|
|
383d26 |
|
|
|
383d26 |
+ if (qemu_in_coroutine()) {
|
|
|
383d26 |
+ bdrv_co_yield_to_drain(NULL, true, false, NULL, true);
|
|
|
383d26 |
+ return;
|
|
|
383d26 |
+ }
|
|
|
383d26 |
+
|
|
|
383d26 |
/* BDRV_POLL_WHILE() for a node can only be called from its own I/O thread
|
|
|
383d26 |
* or the main loop AioContext. We potentially use BDRV_POLL_WHILE() on
|
|
|
383d26 |
* nodes in several different AioContexts, so make sure we're in the main
|
|
|
383d26 |
--
|
|
|
383d26 |
1.8.3.1
|
|
|
383d26 |
|