Blame SOURCES/kvm-block-Fix-use-after-free-error-in-bdrv_open_inherit.patch

7711c0
From 9fbe06ec1dad1ffc7a2bcc138b7dbd6bf83e36cd Mon Sep 17 00:00:00 2001
7711c0
From: Kevin Wolf <kwolf@redhat.com>
7711c0
Date: Fri, 15 Mar 2019 18:10:02 +0100
7711c0
Subject: [PATCH 006/163] block: Fix use after free error in
7711c0
 bdrv_open_inherit()
7711c0
7711c0
RH-Author: Kevin Wolf <kwolf@redhat.com>
7711c0
Message-id: <20190315181010.14964-7-kwolf@redhat.com>
7711c0
Patchwork-id: 84883
7711c0
O-Subject: [RHEL-7.7 qemu-kvm-rhev PATCH 06/14] block: Fix use after free error in bdrv_open_inherit()
7711c0
Bugzilla: 1685989
7711c0
RH-Acked-by: John Snow <jsnow@redhat.com>
7711c0
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
7711c0
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
7711c0
7711c0
From: Alberto Garcia <berto@igalia.com>
7711c0
7711c0
When a block device is opened with BDRV_O_SNAPSHOT and the
7711c0
bdrv_append_temp_snapshot() call fails then the error code path tries
7711c0
to unref the already destroyed 'options' QDict.
7711c0
7711c0
This can be reproduced easily by setting TMPDIR to a location where
7711c0
the QEMU process can't write:
7711c0
7711c0
   $ TMPDIR=/nonexistent $QEMU -drive driver=null-co,snapshot=on
7711c0
7711c0
Signed-off-by: Alberto Garcia <berto@igalia.com>
7711c0
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
7711c0
(cherry picked from commit 8961be33e8ca7e809c603223803ea66ef7ea5be7)
7711c0
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
7711c0
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
7711c0
---
7711c0
 block.c | 1 +
7711c0
 1 file changed, 1 insertion(+)
7711c0
7711c0
diff --git a/block.c b/block.c
7711c0
index b31124c..25b3fe5 100644
7711c0
--- a/block.c
7711c0
+++ b/block.c
7711c0
@@ -2834,6 +2834,7 @@ static BlockDriverState *bdrv_open_inherit(const char *filename,
7711c0
     bdrv_parent_cb_change_media(bs, true);
7711c0
 
7711c0
     qobject_unref(options);
7711c0
+    options = NULL;
7711c0
 
7711c0
     /* For snapshot=on, create a temporary qcow2 overlay. bs points to the
7711c0
      * temporary snapshot afterwards. */
7711c0
-- 
7711c0
1.8.3.1
7711c0