|
 |
383d26 |
From 428b1ae675f8018ef457d095d726bc2e4cc5b5d4 Mon Sep 17 00:00:00 2001
|
|
|
383d26 |
From: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
Date: Wed, 6 Feb 2019 22:12:40 +0100
|
|
|
383d26 |
Subject: [PATCH 30/33] bloc/qcow2: drop dirty_bitmaps_loaded state variable
|
|
|
383d26 |
|
|
|
383d26 |
RH-Author: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
Message-id: <20190206221243.7407-21-jsnow@redhat.com>
|
|
|
383d26 |
Patchwork-id: 84279
|
|
|
383d26 |
O-Subject: [RHEL-7.7 qemu-kvm-rhev PATCH v2 20/23] bloc/qcow2: drop dirty_bitmaps_loaded state variable
|
|
|
383d26 |
Bugzilla: 1658343
|
|
|
383d26 |
RH-Acked-by: Thomas Huth <thuth@redhat.com>
|
|
|
383d26 |
RH-Acked-by: Laurent Vivier <lvivier@redhat.com>
|
|
|
383d26 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
383d26 |
|
|
|
383d26 |
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
|
|
383d26 |
|
|
|
383d26 |
This variable doesn't work as it should, because it is actually cleared
|
|
|
383d26 |
in qcow2_co_invalidate_cache() by memset(). Drop it, as the following
|
|
|
383d26 |
patch will introduce new behavior.
|
|
|
383d26 |
|
|
|
383d26 |
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
|
|
383d26 |
Reviewed-by: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
Signed-off-by: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
(cherry picked from commit 2ea427effff61efa5d0dc69f9cae126d13879617)
|
|
|
383d26 |
Signed-off-by: John Snow <jsnow@redhat.com>
|
|
|
383d26 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
383d26 |
---
|
|
|
383d26 |
block/qcow2.c | 19 ++-----------------
|
|
|
383d26 |
block/qcow2.h | 1 -
|
|
|
383d26 |
2 files changed, 2 insertions(+), 18 deletions(-)
|
|
|
383d26 |
|
|
|
383d26 |
diff --git a/block/qcow2.c b/block/qcow2.c
|
|
|
383d26 |
index 5c5530d..d260cd6 100644
|
|
|
383d26 |
--- a/block/qcow2.c
|
|
|
383d26 |
+++ b/block/qcow2.c
|
|
|
383d26 |
@@ -1149,7 +1149,6 @@ static int coroutine_fn qcow2_do_open(BlockDriverState *bs, QDict *options,
|
|
|
383d26 |
uint64_t ext_end;
|
|
|
383d26 |
uint64_t l1_vm_state_index;
|
|
|
383d26 |
bool update_header = false;
|
|
|
383d26 |
- bool header_updated = false;
|
|
|
383d26 |
|
|
|
383d26 |
ret = bdrv_pread(bs->file, 0, &header, sizeof(header));
|
|
|
383d26 |
if (ret < 0) {
|
|
|
383d26 |
@@ -1488,23 +1487,9 @@ static int coroutine_fn qcow2_do_open(BlockDriverState *bs, QDict *options,
|
|
|
383d26 |
s->autoclear_features &= QCOW2_AUTOCLEAR_MASK;
|
|
|
383d26 |
}
|
|
|
383d26 |
|
|
|
383d26 |
- if (s->dirty_bitmaps_loaded) {
|
|
|
383d26 |
- /* It's some kind of reopen. There are no known cases where we need to
|
|
|
383d26 |
- * reload bitmaps in such a situation, so it's safer to skip them.
|
|
|
383d26 |
- *
|
|
|
383d26 |
- * Moreover, if we have some readonly bitmaps and we are reopening for
|
|
|
383d26 |
- * rw we should reopen bitmaps correspondingly.
|
|
|
383d26 |
- */
|
|
|
383d26 |
- if (bdrv_has_readonly_bitmaps(bs) &&
|
|
|
383d26 |
- !bdrv_is_read_only(bs) && !(bdrv_get_flags(bs) & BDRV_O_INACTIVE))
|
|
|
383d26 |
- {
|
|
|
383d26 |
- qcow2_reopen_bitmaps_rw_hint(bs, &header_updated, &local_err);
|
|
|
383d26 |
- }
|
|
|
383d26 |
- } else {
|
|
|
383d26 |
- header_updated = qcow2_load_dirty_bitmaps(bs, &local_err);
|
|
|
383d26 |
- s->dirty_bitmaps_loaded = true;
|
|
|
383d26 |
+ if (qcow2_load_dirty_bitmaps(bs, &local_err)) {
|
|
|
383d26 |
+ update_header = false;
|
|
|
383d26 |
}
|
|
|
383d26 |
- update_header = update_header && !header_updated;
|
|
|
383d26 |
if (local_err != NULL) {
|
|
|
383d26 |
error_propagate(errp, local_err);
|
|
|
383d26 |
ret = -EINVAL;
|
|
|
383d26 |
diff --git a/block/qcow2.h b/block/qcow2.h
|
|
|
383d26 |
index d2c63e4..43163b2 100644
|
|
|
383d26 |
--- a/block/qcow2.h
|
|
|
383d26 |
+++ b/block/qcow2.h
|
|
|
383d26 |
@@ -299,7 +299,6 @@ typedef struct BDRVQcow2State {
|
|
|
383d26 |
uint32_t nb_bitmaps;
|
|
|
383d26 |
uint64_t bitmap_directory_size;
|
|
|
383d26 |
uint64_t bitmap_directory_offset;
|
|
|
383d26 |
- bool dirty_bitmaps_loaded;
|
|
|
383d26 |
|
|
|
383d26 |
int flags;
|
|
|
383d26 |
int qcow_version;
|
|
|
383d26 |
--
|
|
|
383d26 |
1.8.3.1
|
|
|
383d26 |
|